From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48568C4332F for ; Thu, 10 Mar 2022 22:19:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F263418C1; Thu, 10 Mar 2022 23:18:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F263418C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646950780; bh=JU7F45BV9tpPf4BWSeA+PrkLQlaX7J6OlFV1hWeqmJY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BnX/7myznD3SUfdl++ivcCjaNYDloG12Jf9FHMuFq5yqdoO9NUESQft0kVmbGlI5i xWoEjPlX5+aeBJvYh+paXszHvB7yxQahfK0eQi05Gc8pskQWJfpvy+DhBBNSSvdnpu mczphgjNnNKaBrog4JnbrDMCIMskaE391yxrPVJU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80C1FF800D2; Thu, 10 Mar 2022 23:18:49 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3C598F80137; Thu, 10 Mar 2022 23:18:48 +0100 (CET) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C3B84F800D2 for ; Thu, 10 Mar 2022 23:18:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C3B84F800D2 Received: by mail-ot1-f45.google.com with SMTP id k25-20020a056830151900b005b25d8588dbso5045497otp.4 for ; Thu, 10 Mar 2022 14:18:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uVBl4IjExhMMGQyqVZdtBYxJhbtlhf7V3EID45rNLsk=; b=CcJiRu4ZIIADSEBPHTqRar3KlVWyr8U25uWgWR1z9LcnjoG5BTw+lJLyORh++Gj7WJ aKQqN5vX4qHgBHd1gEVWuVraWpWZv2Q/CImZzKf/ZriyeEA4Viysy6bCJIvDzcnud+5x M3p+WiMCTu4cL7hA8pzYMVJjaFGKl5nKPQNTGQgBAhRoEvkFW+MQvUY8GgDb0WRHWEwm dRD6snhEeNzR6pjRJbGVEeHWpQRON77s0x7elgTYh+F/RfMyKdULpppw7QPVpWv7me1n WqVzHVuT7ivR/41kpKRZrRAzhGXca+iMWteL2wJK1BmAplNDjGrJnxiqn2/2WQuenGzJ is4g== X-Gm-Message-State: AOAM532Rc6eD1YRUPVSUbK6o2mVj1yiQfWy8H6YKU5cEkVdSDnWQUOlv Izlztf9fTuGuUNW9971LTNlf9etnKg== X-Google-Smtp-Source: ABdhPJymVHkEV5XxQpBNmw5S/gpv0K8uSPo3RhUKisPITsq2PFiS19pD2qkEoukGiphCl2E24hUkYQ== X-Received: by 2002:a9d:77d7:0:b0:5b2:29b0:70cb with SMTP id w23-20020a9d77d7000000b005b229b070cbmr3556144otl.276.1646950718003; Thu, 10 Mar 2022 14:18:38 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i126-20020acab884000000b002d9f958bceesm2925916oif.41.2022.03.10.14.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:18:36 -0800 (PST) Received: (nullmailer pid 2185267 invoked by uid 1000); Thu, 10 Mar 2022 22:18:35 -0000 Date: Thu, 10 Mar 2022 16:18:35 -0600 From: Rob Herring To: Trevor Wu Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8195: add mt8195-mt6359-max98390-rt5682 document Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308072435.22460-6-trevor.wu@mediatek.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-mediatek@lists.infradead.org, yc.hung@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Mar 08, 2022 at 03:24:35PM +0800, Trevor Wu wrote: > This patch adds document for mt8195 board with mt6359, max98390 and > rt5682. > > Signed-off-by: Trevor Wu > --- > .../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > new file mode 100644 > index 000000000000..7ec14d61b109 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8195-mt6359-max98390-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8195 with MT6359, MAX98390 and RT5682 ASoC sound card driver > + > +maintainers: > + - Trevor Wu > + > +description: > + This binding describes the MT8195 sound card. > + > +properties: > + compatible: > + const: mediatek,mt8195_mt6359_max98390_rt5682 You have nodes for each of these components, why do we need new compatible string for each combination. You can figure out the combination by looking at each of those nodes. Second, why does each combination need a new schema doc? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7469CC433EF for ; Thu, 10 Mar 2022 22:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4EsC96bvPB2v1emqTZ1N7j/CfKHPqGbnOoe80MCJ7bg=; b=ceq+0uQxeA3Lzh LZwIYHfnXyONErYpgx949gcnkV03F7NYsq0OtrvQVtlegy+9P5ZCHlxSKalkby6i+F9tJ4/9YTyCy of2AAqD651L6QChXUldoGJe95G076cNCTav9BqAoLTb7X6L0DWaoDzDCPQVf/qyux/WMpsA7BNZjx B6yalCyo7M3oYB5Yk0hr69nc6jSgTYIEvTxSFBkxJIlmTyBp0DK/eusKqvEpF5yyIU81ZK9JgybkE FShkL6AvRwmM34AChytp/1NpgWjCGBC/bjPioYcjbRnvaU4rFQbBSq+IB4Eq1g52s3Hm3/Fi5fC+Z bzgHmVbI1PAocEYffLpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR7J-00EByY-A2; Thu, 10 Mar 2022 22:18:41 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR7G-00EBxs-TW; Thu, 10 Mar 2022 22:18:40 +0000 Received: by mail-ot1-f48.google.com with SMTP id 17-20020a9d0611000000b005b251571643so5048941otn.2; Thu, 10 Mar 2022 14:18:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uVBl4IjExhMMGQyqVZdtBYxJhbtlhf7V3EID45rNLsk=; b=NB7NUFf6lMrzq6RI28HwTCouxV6ZRDUeq0+QmQ4rZyfNbkXeixej25rYC2JscWibBU Z9BVLDINXAVI3icviR47cHXoLVBQVPfDztE8xk6Je2Rq3wPalgTaZtz98tb3wiKgO3Nf DU7b9n5PvpPUkumWmGmnfNbbriz7qgGoAscoCrLlLHU6bI76GK4dRRcyaT2d/FdhhqDz 1OYmrg/K42qOH0LMKxDi3z6dS/dbWIH0MWg9mOwxp0/9BdDuEsSgRaT+VXmXtt+ZlyFU oEh91KQmHHPWQfpA/bWXEjZ5iJQ4fByLTEqjYm4UeXnYR0nQselxk+BQiCNh8r5RQ7mU Dlkg== X-Gm-Message-State: AOAM5330Sw7DkMtxFqhm0U18gWu0NfJTBfUnuQgJyeLezm7UPRa642hI w5TnkpeIDvA6fY6grZNWCg== X-Google-Smtp-Source: ABdhPJymVHkEV5XxQpBNmw5S/gpv0K8uSPo3RhUKisPITsq2PFiS19pD2qkEoukGiphCl2E24hUkYQ== X-Received: by 2002:a9d:77d7:0:b0:5b2:29b0:70cb with SMTP id w23-20020a9d77d7000000b005b229b070cbmr3556144otl.276.1646950718003; Thu, 10 Mar 2022 14:18:38 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i126-20020acab884000000b002d9f958bceesm2925916oif.41.2022.03.10.14.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:18:36 -0800 (PST) Received: (nullmailer pid 2185267 invoked by uid 1000); Thu, 10 Mar 2022 22:18:35 -0000 Date: Thu, 10 Mar 2022 16:18:35 -0600 From: Rob Herring To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, yc.hung@mediatek.com Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8195: add mt8195-mt6359-max98390-rt5682 document Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308072435.22460-6-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_141838_984132_5400C3C9 X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 03:24:35PM +0800, Trevor Wu wrote: > This patch adds document for mt8195 board with mt6359, max98390 and > rt5682. > > Signed-off-by: Trevor Wu > --- > .../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > new file mode 100644 > index 000000000000..7ec14d61b109 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8195-mt6359-max98390-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8195 with MT6359, MAX98390 and RT5682 ASoC sound card driver > + > +maintainers: > + - Trevor Wu > + > +description: > + This binding describes the MT8195 sound card. > + > +properties: > + compatible: > + const: mediatek,mt8195_mt6359_max98390_rt5682 You have nodes for each of these components, why do we need new compatible string for each combination. You can figure out the combination by looking at each of those nodes. Second, why does each combination need a new schema doc? Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9606C433EF for ; Thu, 10 Mar 2022 22:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7i0ITD6bJ9CJz5W3sHfGHO16gXtFFW6Z+6FSIYieeco=; b=yq6wmViHvHQxjH v9PwDOTJGt0tTj7HccmSdzKHZ+zdEku8xhu7zPBLwT2soh3WjkMpUZuwCYQI7Yi91J0VQy2yplU02 WRBadqn4EHCw2bARRqs5qsq/ioOAgOGRTiF6AASFRKj6hT0M41DvPYfUmqYjgoIsuHSRdQ0AZLYbQ fWirqx6mxuVilrkt5B7zKkm/ZYILBCMcHDr5hfDSWuBUrDZTz7DS7CK2LZzbNm6jeMbfdyTWXGMhC 1Qan+EDOgsxdjAmBfzNoHckx69Lp/JSXhnXNJ7CVu3ILGGm2aIilBJS3mztUhhVRhcpRQxPrMuKPe JcAe7XntMfEaSqCj7KGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR7L-00EBz1-Bk; Thu, 10 Mar 2022 22:18:43 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSR7G-00EBxs-TW; Thu, 10 Mar 2022 22:18:40 +0000 Received: by mail-ot1-f48.google.com with SMTP id 17-20020a9d0611000000b005b251571643so5048941otn.2; Thu, 10 Mar 2022 14:18:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uVBl4IjExhMMGQyqVZdtBYxJhbtlhf7V3EID45rNLsk=; b=NB7NUFf6lMrzq6RI28HwTCouxV6ZRDUeq0+QmQ4rZyfNbkXeixej25rYC2JscWibBU Z9BVLDINXAVI3icviR47cHXoLVBQVPfDztE8xk6Je2Rq3wPalgTaZtz98tb3wiKgO3Nf DU7b9n5PvpPUkumWmGmnfNbbriz7qgGoAscoCrLlLHU6bI76GK4dRRcyaT2d/FdhhqDz 1OYmrg/K42qOH0LMKxDi3z6dS/dbWIH0MWg9mOwxp0/9BdDuEsSgRaT+VXmXtt+ZlyFU oEh91KQmHHPWQfpA/bWXEjZ5iJQ4fByLTEqjYm4UeXnYR0nQselxk+BQiCNh8r5RQ7mU Dlkg== X-Gm-Message-State: AOAM5330Sw7DkMtxFqhm0U18gWu0NfJTBfUnuQgJyeLezm7UPRa642hI w5TnkpeIDvA6fY6grZNWCg== X-Google-Smtp-Source: ABdhPJymVHkEV5XxQpBNmw5S/gpv0K8uSPo3RhUKisPITsq2PFiS19pD2qkEoukGiphCl2E24hUkYQ== X-Received: by 2002:a9d:77d7:0:b0:5b2:29b0:70cb with SMTP id w23-20020a9d77d7000000b005b229b070cbmr3556144otl.276.1646950718003; Thu, 10 Mar 2022 14:18:38 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i126-20020acab884000000b002d9f958bceesm2925916oif.41.2022.03.10.14.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:18:36 -0800 (PST) Received: (nullmailer pid 2185267 invoked by uid 1000); Thu, 10 Mar 2022 22:18:35 -0000 Date: Thu, 10 Mar 2022 16:18:35 -0600 From: Rob Herring To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, yc.hung@mediatek.com Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8195: add mt8195-mt6359-max98390-rt5682 document Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220308072435.22460-6-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_141838_984132_5400C3C9 X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 08, 2022 at 03:24:35PM +0800, Trevor Wu wrote: > This patch adds document for mt8195 board with mt6359, max98390 and > rt5682. > > Signed-off-by: Trevor Wu > --- > .../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > new file mode 100644 > index 000000000000..7ec14d61b109 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8195-mt6359-max98390-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8195 with MT6359, MAX98390 and RT5682 ASoC sound card driver > + > +maintainers: > + - Trevor Wu > + > +description: > + This binding describes the MT8195 sound card. > + > +properties: > + compatible: > + const: mediatek,mt8195_mt6359_max98390_rt5682 You have nodes for each of these components, why do we need new compatible string for each combination. You can figure out the combination by looking at each of those nodes. Second, why does each combination need a new schema doc? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3FBC433EF for ; Thu, 10 Mar 2022 22:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344357AbiCJWTl (ORCPT ); Thu, 10 Mar 2022 17:19:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236742AbiCJWTk (ORCPT ); Thu, 10 Mar 2022 17:19:40 -0500 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8ED94F456; Thu, 10 Mar 2022 14:18:38 -0800 (PST) Received: by mail-ot1-f46.google.com with SMTP id o106-20020a9d2273000000b005b21f46878cso5036537ota.3; Thu, 10 Mar 2022 14:18:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uVBl4IjExhMMGQyqVZdtBYxJhbtlhf7V3EID45rNLsk=; b=WIfaa4MTWFgPdWVPTIhscW20nxEv2YZRBZ6MKNUK6tA6jh7CuKuXJza6CnlyBR5zII YH37ztxy/f5SihWbQpbvht0FiVj5DQco41fFOGD0bUC9CQ4CIp7J8cjjHO+FO7RvlgSo Y30P8PLWwTLXveBxecjVxrn492bZhaj+a2B7ZHqwfk1IqqPMmHFioSGnGZNq+Vd+WXUK 6JxXYSH3IES2Hhy1Qx3RfUnWdsy8t7iEmWK/W0JSHqmeFOmgzEEqNa1XPOhRMPCFhHop aFlU5bPBlR1zUCYhHwkuxufBGOqnpctoeNXMiyrJBK6GC3f3D8De0LWjk/KeR3kGVv3U xdbQ== X-Gm-Message-State: AOAM533cVcQ4qmfod0yfrIYWqpiXMRoxHy9KqWpBpqeU8tBaG/3GOoPM NhNOml8Dvh4HIi7xji62mg== X-Google-Smtp-Source: ABdhPJymVHkEV5XxQpBNmw5S/gpv0K8uSPo3RhUKisPITsq2PFiS19pD2qkEoukGiphCl2E24hUkYQ== X-Received: by 2002:a9d:77d7:0:b0:5b2:29b0:70cb with SMTP id w23-20020a9d77d7000000b005b229b070cbmr3556144otl.276.1646950718003; Thu, 10 Mar 2022 14:18:38 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i126-20020acab884000000b002d9f958bceesm2925916oif.41.2022.03.10.14.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 14:18:36 -0800 (PST) Received: (nullmailer pid 2185267 invoked by uid 1000); Thu, 10 Mar 2022 22:18:35 -0000 Date: Thu, 10 Mar 2022 16:18:35 -0600 From: Rob Herring To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, yc.hung@mediatek.com Subject: Re: [PATCH 5/5] dt-bindings: mediatek: mt8195: add mt8195-mt6359-max98390-rt5682 document Message-ID: References: <20220308072435.22460-1-trevor.wu@mediatek.com> <20220308072435.22460-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308072435.22460-6-trevor.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 08, 2022 at 03:24:35PM +0800, Trevor Wu wrote: > This patch adds document for mt8195 board with mt6359, max98390 and > rt5682. > > Signed-off-by: Trevor Wu > --- > .../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > new file mode 100644 > index 000000000000..7ec14d61b109 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mt8195-mt6359-max98390-rt5682.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek MT8195 with MT6359, MAX98390 and RT5682 ASoC sound card driver > + > +maintainers: > + - Trevor Wu > + > +description: > + This binding describes the MT8195 sound card. > + > +properties: > + compatible: > + const: mediatek,mt8195_mt6359_max98390_rt5682 You have nodes for each of these components, why do we need new compatible string for each combination. You can figure out the combination by looking at each of those nodes. Second, why does each combination need a new schema doc? Rob