From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1D87C433EF for ; Thu, 10 Mar 2022 20:52:25 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 312811941; Thu, 10 Mar 2022 21:51:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 312811941 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646945543; bh=DbyPbpik+r/H9bBxxNvLxr+w6StJECFNemwuPbz1loU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ba3tpnuTruMyPHlcRGcmS8/tOln5ln+UjWfZmub0LgOJ+95oEt1OAN8iwdwgC63Xl 21zClWQzMif8u10MPEowzYX3PKuuWwNClMkzOieibRGP9+rPP8d17vBxQlFvmz44+C EiZ1nQPzL1pEy8Tk+uXOJZa489bCz5WiEm0WW5uk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B0A15F8012F; Thu, 10 Mar 2022 21:51:32 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43A2AF80137; Thu, 10 Mar 2022 21:51:30 +0100 (CET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CCE01F8012C for ; Thu, 10 Mar 2022 21:51:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CCE01F8012C Received: by mail-ot1-f43.google.com with SMTP id j3-20020a9d7683000000b005aeed94f4e9so4893967otl.6 for ; Thu, 10 Mar 2022 12:51:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=slxCGGqrUztha0XPfFAUWL5ID7RQgaEMphARvX9hCBs=; b=x80cdeUdYmD7hWDPbYLQeFF6Fo/3aBNARj6wd/STY3yFZZhjk2T59u4sfcmnraHPPv Xr9WrDfhPH+ALT2M1O0I9vQDMDJWV1xh9O26HIcBv4pVY8uKAlCsr/qu2euHGe/5kFx5 BzuzJgGVJAgSu1oaWwUY2OpdcfNnQaNhxuD6xptQquVJGhYod9TAR/g433h31e2ZdBcZ /qoCtQNsYQ8WSHdmnP8L6Z3eRcKDHpftEZy3mPYznXv786OtuJ7EgAhyb53R0EO6TcOO Imui76/1D8tJRM9I/mn7BKSbuWGzTO5xFg/HNNb2885BuK5Vi5aH/nrxN+ZrEz6qE9H7 FtXQ== X-Gm-Message-State: AOAM5302F1i4qDAwUp/gPe3qQnSJmX7nP7QYzmVgu8W7G3hUXqYVZF53 tpJM6/V3ndou7qnFYWGVMg== X-Google-Smtp-Source: ABdhPJz8G/QtOa+879lxZGa2RhwdFvUCb7Fy+vOXp2rvMTapgI5pc7gEgYdwEjMMeo8zWtoeAvPFGw== X-Received: by 2002:a05:6830:22f2:b0:5c4:3f05:33cf with SMTP id t18-20020a05683022f200b005c43f0533cfmr2425782otc.330.1646945475301; Thu, 10 Mar 2022 12:51:15 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y8-20020a544d88000000b002d525da014bsm2668280oix.42.2022.03.10.12.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 12:51:14 -0800 (PST) Received: (nullmailer pid 2046461 invoked by uid 1000); Thu, 10 Mar 2022 20:51:13 -0000 Date: Thu, 10 Mar 2022 14:51:13 -0600 From: Rob Herring To: Alifer Moraes Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support Message-ID: References: <20220307141041.27538-1-alifer.m@variscite.com> <20220307141041.27538-3-alifer.m@variscite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com> Cc: pierluigi.p@variscite.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, shengjiu.wang@gmail.com, tiwai@suse.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, eran.m@variscite.com, broonie@kernel.org, patches@opensource.cirrus.com, festevam@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote: > From: Pierluigi Passaro > > The platform_data structure is not populated when using device trees. > This patch adds optional dts properties to allow populating it: > - gpio-cfg > - mic-cfg > - num-drc-cfgs > - drc-cfg-regs > - drc-cfg-names > - num-retune-mobile-cfgs > - retune-mobile-cfg-regs > - retune-mobile-cfg-names > - retune-mobile-cfg-rates If you want to add all this, convert to DT schema first. They all need vendor prefixes for starters. > > Signed-off-by: Pierluigi Passaro > Signed-off-by: Alifer Moraes > --- > .../devicetree/bindings/sound/wm8904.txt | 53 ++++++++ > sound/soc/codecs/wm8904.c | 113 +++++++++++++++++- Binding changes go in their own patches. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21A99C433EF for ; Thu, 10 Mar 2022 20:51:47 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KF1Sx2FTKz30J6 for ; Fri, 11 Mar 2022 07:51:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.47; helo=mail-ot1-f47.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KF1SR73xJz2ypn for ; Fri, 11 Mar 2022 07:51:19 +1100 (AEDT) Received: by mail-ot1-f47.google.com with SMTP id s35-20020a0568302aa300b005b2463a41faso4888795otu.10 for ; Thu, 10 Mar 2022 12:51:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=slxCGGqrUztha0XPfFAUWL5ID7RQgaEMphARvX9hCBs=; b=1E+6RLzHtwS6e2DN9PZl5QH1pYVnUM6CelokaAnSgZzEU/YOlUG+ZikjwWiyegT8Vq jdjvuCfhOmxC0I1HIXp9gaQWfyoGmJuvuMetLwxA0ZPP2/WgPgpcs6KAizwUghfJKcE5 HJt8lvUt7QRzus8nxzDPQEzfAOoCoj7cVhxKNuq3fDf1u+OBx1jOw5CcQ92aPTeXfjwU FIoi9zIRkfkup2yODijz0wDO9fmX1jmbhIBg6p/YDorBTG3XHqm1WWJsPz5rfoM1fIyd oD8UXsydN2cxFKtVi8zWZDeWrD4zbb+Kp50lU6YO6Issj/bDG71dOgsHIa8eJnC636+h m6kQ== X-Gm-Message-State: AOAM531p3ljHdG3LzYi5zo3Z+ycb5KZsmhiX/mPEU9dpW77PhD5IHNEv 5exJVjgGWhKqN6AS3sKuew== X-Google-Smtp-Source: ABdhPJz8G/QtOa+879lxZGa2RhwdFvUCb7Fy+vOXp2rvMTapgI5pc7gEgYdwEjMMeo8zWtoeAvPFGw== X-Received: by 2002:a05:6830:22f2:b0:5c4:3f05:33cf with SMTP id t18-20020a05683022f200b005c43f0533cfmr2425782otc.330.1646945475301; Thu, 10 Mar 2022 12:51:15 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y8-20020a544d88000000b002d525da014bsm2668280oix.42.2022.03.10.12.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 12:51:14 -0800 (PST) Received: (nullmailer pid 2046461 invoked by uid 1000); Thu, 10 Mar 2022 20:51:13 -0000 Date: Thu, 10 Mar 2022 14:51:13 -0600 From: Rob Herring To: Alifer Moraes Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support Message-ID: References: <20220307141041.27538-1-alifer.m@variscite.com> <20220307141041.27538-3-alifer.m@variscite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pierluigi.p@variscite.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com, linuxppc-dev@lists.ozlabs.org, shengjiu.wang@gmail.com, tiwai@suse.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, eran.m@variscite.com, broonie@kernel.org, patches@opensource.cirrus.com, perex@perex.cz, festevam@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote: > From: Pierluigi Passaro > > The platform_data structure is not populated when using device trees. > This patch adds optional dts properties to allow populating it: > - gpio-cfg > - mic-cfg > - num-drc-cfgs > - drc-cfg-regs > - drc-cfg-names > - num-retune-mobile-cfgs > - retune-mobile-cfg-regs > - retune-mobile-cfg-names > - retune-mobile-cfg-rates If you want to add all this, convert to DT schema first. They all need vendor prefixes for starters. > > Signed-off-by: Pierluigi Passaro > Signed-off-by: Alifer Moraes > --- > .../devicetree/bindings/sound/wm8904.txt | 53 ++++++++ > sound/soc/codecs/wm8904.c | 113 +++++++++++++++++- Binding changes go in their own patches. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A302DC433EF for ; Thu, 10 Mar 2022 20:51:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230053AbiCJUwS (ORCPT ); Thu, 10 Mar 2022 15:52:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232920AbiCJUwR (ORCPT ); Thu, 10 Mar 2022 15:52:17 -0500 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F1E187E29; Thu, 10 Mar 2022 12:51:15 -0800 (PST) Received: by mail-ot1-f47.google.com with SMTP id o106-20020a9d2273000000b005b21f46878cso4894745ota.3; Thu, 10 Mar 2022 12:51:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=slxCGGqrUztha0XPfFAUWL5ID7RQgaEMphARvX9hCBs=; b=lJEqe75HzUSBdhrNcJqdqMK20dq5eYZZtKWTCeH8Jo8/8ATWHO5luO0cOxXENzPDGc fdbjz0zsefTNo7T4nCrJO6f2mE2yTzFU3s4/fVsINEqTP2iVMp1ZD+2O9cWnv/rlvZfW lHdTZUyGgYKIIHtbQUhfhel94OLIyUBMJKIh8RGhMhcdNpbJ1wM1WC70XGxQqMVeR/K5 GzPdMr86AojoX7o+OQOcwSTykZ7QR76eJx7KQZymUwrzaVu/v02w75XiKWIUTO/0b1Vw YAdWpgXpiNF52kXCD5FRsO+SVNB+Ils/DQ9anlTDmaW44IZpFlQnqNEKG9jSTNW7lI8D Wr0Q== X-Gm-Message-State: AOAM53240MQCa7VBTeNEtJ48+zZJ0oVMuwvXg0bcvJVhjyJsd19hRmf8 vp6dFcrhT5MvfkLGs3CxtA== X-Google-Smtp-Source: ABdhPJz8G/QtOa+879lxZGa2RhwdFvUCb7Fy+vOXp2rvMTapgI5pc7gEgYdwEjMMeo8zWtoeAvPFGw== X-Received: by 2002:a05:6830:22f2:b0:5c4:3f05:33cf with SMTP id t18-20020a05683022f200b005c43f0533cfmr2425782otc.330.1646945475301; Thu, 10 Mar 2022 12:51:15 -0800 (PST) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y8-20020a544d88000000b002d525da014bsm2668280oix.42.2022.03.10.12.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 12:51:14 -0800 (PST) Received: (nullmailer pid 2046461 invoked by uid 1000); Thu, 10 Mar 2022 20:51:13 -0000 Date: Thu, 10 Mar 2022 14:51:13 -0600 From: Rob Herring To: Alifer Moraes Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, devicetree@vger.kernel.org, eran.m@variscite.com, festevam@gmail.com, lgirdwood@gmail.com, linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com, patches@opensource.cirrus.com, perex@perex.cz, pierluigi.p@variscite.com, shengjiu.wang@gmail.com, tiwai@suse.com, Xiubo.Lee@gmail.com Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support Message-ID: References: <20220307141041.27538-1-alifer.m@variscite.com> <20220307141041.27538-3-alifer.m@variscite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote: > From: Pierluigi Passaro > > The platform_data structure is not populated when using device trees. > This patch adds optional dts properties to allow populating it: > - gpio-cfg > - mic-cfg > - num-drc-cfgs > - drc-cfg-regs > - drc-cfg-names > - num-retune-mobile-cfgs > - retune-mobile-cfg-regs > - retune-mobile-cfg-names > - retune-mobile-cfg-rates If you want to add all this, convert to DT schema first. They all need vendor prefixes for starters. > > Signed-off-by: Pierluigi Passaro > Signed-off-by: Alifer Moraes > --- > .../devicetree/bindings/sound/wm8904.txt | 53 ++++++++ > sound/soc/codecs/wm8904.c | 113 +++++++++++++++++- Binding changes go in their own patches.