From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E211C433F5 for ; Fri, 11 Mar 2022 05:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232824AbiCKFdH (ORCPT ); Fri, 11 Mar 2022 00:33:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234001AbiCKFdE (ORCPT ); Fri, 11 Mar 2022 00:33:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D9111AC287; Thu, 10 Mar 2022 21:32:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0BD32B82A83; Fri, 11 Mar 2022 05:31:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1FDC340EC; Fri, 11 Mar 2022 05:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646976717; bh=WZxaV6Pf7jSxcq9QhrqU6a6XmApG4E+JJxhTiL/TA4o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ob5ZHIgSUc7ffS1WUTii9bnVJtzk8WPUoL3UEGmI8LA/pPfuNB7aJAOSKJzkWpSQi 6LyEO8syF9aVEj5/kWXYkHf64UtKZowR1dt+yzXVzuHt8QOILVdmvn14AWZfemWF8Z gRioblA5Yz3SMTchKuF0GTeIOFpHmvK2xP0Mt+8Racw4eelPzbjPuQLoTUM9PoLYpb lOoPGvSqe3ouw9n3e/szesfGwcLH1zHCJEA3pyUnIMcJq/RMLFZ79HFRQCQJf92kuL uu20kCmRhPJKE+nq/8Zu1kvu65ugM6zpbwbC3JAuQP+nEoBNPld58rMB3p3IbgSHYE ls+X6siohQP0A== Date: Thu, 10 Mar 2022 21:31:55 -0800 From: Eric Biggers To: Bart Van Assche Cc: "Bean Huo (beanhuo)" , Jens Axboe , "Luca Porzio (lporzio)" , Manjong Lee , "david@fromorbit.com" , "hch@lst.de" , "kbusch@kernel.org" , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-raid@vger.kernel.org" , "sagi@grimberg.me" , "song@kernel.org" , "seunghwan.hyun@samsung.com" , "sookwan7.kim@samsung.com" , "nanich.lee@samsung.com" , "woosung2.lee@samsung.com" , "yt0928.kim@samsung.com" , "junho89.kim@samsung.com" , "jisoo2146.oh@samsung.com" , Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [EXT] Re: [PATCH 2/2] block: remove the per-bio/request write hint. Message-ID: References: <20220306231727.GP3927073@dread.disaster.area> <20220309133119.6915-1-mj0123.lee@samsung.com> <9d645cf0-1685-437a-23e4-b2a01553bba5@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d645cf0-1685-437a-23e4-b2a01553bba5@acm.org> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Mar 10, 2022 at 02:18:19PM -0800, Bart Van Assche wrote: > On 3/10/22 13:52, Bean Huo (beanhuo) wrote: > > Yes, in upstream linux and upstream android, there is no such code. But as we know, > > mobile customers have used bio->bi_write_hint in their products for years. And the > > group ID is set according to bio->bi_write_hint before passing the CDB to UFS. > > > > > > lrbp = &hba->lrb[tag]; > > WARN_ON(lrbp->cmd); > > + if(cmd->cmnd[0] == WRITE_10) > > +{ > > + cmd->cmnd[6] = (0x1f& cmd->request->bio->bi_write_hint); > > +} > > lrbp->cmd = cmd; > > lrbp->sense_bufflen = UFS_SENSE_SIZE; > > lrbp->sense_buffer = cmd->sense_buffer; > > > > I don't know why they don't push these changes to the community, maybe > > it's because changes across the file system and block layers are unacceptable to the > > block layer and FS. but for sure we should now warn them to push to the > > community as soon as possible. > > Thanks Bean for having shared this information. I think the above code sets the GROUP > NUMBER information in the WRITE(10) command and also that the following text from the > UFS specification applies to that information: > > GROUP NUMBER: Notifies the Target device that the data linked to a ContextID: > ----------------------------------------------------------------------------------------- > GROUP NUMBER Value | Function > ----------------------------------------------------------------------------------------- > 00000b | Default, no Context ID is associated with the read operation. > 00001b to 01111b (0XXXXb) | Context ID. (XXXX I from 0001b to 1111b ‐ Context ID value) > 10000b | Data has System Data characteristics > 10001b to 11111b | Reserved > ----------------------------------------------------------------------------------------- > > In case the GROUP NUMBER is set to a reserved value, the operation shall fail and a status > response of CHECK CONDITION will be returned along with the sense key set to ILLEGAL REQUEST. > > > Since there is a desire to remove the write hint information from struct bio, is there > any other information the "system data characteristics" information can be derived from? > How about e.g. deriving that information from request flags like REQ_SYNC, REQ_META and/or > REQ_IDLE? > [+Cc linux-f2fs-devel] I think the f2fs developers will need to chime in here, as it looks like f2fs uses the write hints for different data categories like hot/cold/warm. I'm not sure those can be fully represented by other bio flags. Either way, the good news is that it sounds like this "GROUP NUMBER" thing is part of the UFS standard. So whatever the best way to support it is, it can just be submitted upstream like any other standard UFS feature. Why hasn't that been done? - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C94EAC4332F for ; Fri, 11 Mar 2022 05:32:08 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nSXsm-0004xv-AJ; Fri, 11 Mar 2022 05:32:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSXsk-0004xo-9D for linux-f2fs-devel@lists.sourceforge.net; Fri, 11 Mar 2022 05:32:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Xi7rltOEg8o8nA0ZWFPrxjEnSOPSuRVpnXS1OiiWVsM=; b=Q1kAcfqNz5TsAtWeuz/0JdgRZ0 fHy2itZmJCIRNmvCo1RJNcMmzyQNskvlWlbrkG/fSmdDS3E//h3bO4Rog+CQ2+psf9a+TowfxYta3 +PilinzRC8d1FUStj9N2WEk1NEkhUgn5Z612+vuZ95RJt5ckBbQh9hhJAOcAxF7NUzDY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Xi7rltOEg8o8nA0ZWFPrxjEnSOPSuRVpnXS1OiiWVsM=; b=MKuAIrBvDNICvjbp5/M996Jtn0 ScF/g8cPk4VQUxxU7ZdnuSn5pXpCfx8wSJABRYE32ecKXVB4kh/XM8m0Te9lCLwe6uDbtlmCQgyId ppkLH46wtANqLTY3qiH/pzC+BTRBwRcWz2sCSFAC/DdA+1veVdPRotC6QBAByJITD38k=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nSXsh-0007dc-RX for linux-f2fs-devel@lists.sourceforge.net; Fri, 11 Mar 2022 05:32:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5D27E61AF3; Fri, 11 Mar 2022 05:31:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1FDC340EC; Fri, 11 Mar 2022 05:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646976717; bh=WZxaV6Pf7jSxcq9QhrqU6a6XmApG4E+JJxhTiL/TA4o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ob5ZHIgSUc7ffS1WUTii9bnVJtzk8WPUoL3UEGmI8LA/pPfuNB7aJAOSKJzkWpSQi 6LyEO8syF9aVEj5/kWXYkHf64UtKZowR1dt+yzXVzuHt8QOILVdmvn14AWZfemWF8Z gRioblA5Yz3SMTchKuF0GTeIOFpHmvK2xP0Mt+8Racw4eelPzbjPuQLoTUM9PoLYpb lOoPGvSqe3ouw9n3e/szesfGwcLH1zHCJEA3pyUnIMcJq/RMLFZ79HFRQCQJf92kuL uu20kCmRhPJKE+nq/8Zu1kvu65ugM6zpbwbC3JAuQP+nEoBNPld58rMB3p3IbgSHYE ls+X6siohQP0A== Date: Thu, 10 Mar 2022 21:31:55 -0800 From: Eric Biggers To: Bart Van Assche Message-ID: References: <20220306231727.GP3927073@dread.disaster.area> <20220309133119.6915-1-mj0123.lee@samsung.com> <9d645cf0-1685-437a-23e4-b2a01553bba5@acm.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9d645cf0-1685-437a-23e4-b2a01553bba5@acm.org> X-Headers-End: 1nSXsh-0007dc-RX Subject: Re: [f2fs-dev] [EXT] Re: [PATCH 2/2] block: remove the per-bio/request write hint. X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "woosung2.lee@samsung.com" , "david@fromorbit.com" , "linux-nvme@lists.infradead.org" , "seunghwan.hyun@samsung.com" , "song@kernel.org" , "hch@lst.de" , "Bean Huo \(beanhuo\)" , "sagi@grimberg.me" , "jisoo2146.oh@samsung.com" , "nanich.lee@samsung.com" , "yt0928.kim@samsung.com" , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "sookwan7.kim@samsung.com" , "kbusch@kernel.org" , Jaegeuk Kim , Jens Axboe , "linux-raid@vger.kernel.org" , linux-f2fs-devel@lists.sourceforge.net, "junho89.kim@samsung.com" , Manjong Lee Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gVGh1LCBNYXIgMTAsIDIwMjIgYXQgMDI6MTg6MTlQTSAtMDgwMCwgQmFydCBWYW4gQXNzY2hl IHdyb3RlOgo+IE9uIDMvMTAvMjIgMTM6NTIsIEJlYW4gSHVvIChiZWFuaHVvKSB3cm90ZToKPiA+ IFllcywgaW4gdXBzdHJlYW0gbGludXggYW5kIHVwc3RyZWFtIGFuZHJvaWQsIHRoZXJlIGlzIG5v IHN1Y2ggY29kZS4gQnV0IGFzIHdlIGtub3csCj4gPiBtb2JpbGUgY3VzdG9tZXJzIGhhdmUgdXNl ZCBiaW8tPmJpX3dyaXRlX2hpbnQgaW4gdGhlaXIgcHJvZHVjdHMgZm9yIHllYXJzLiBBbmQgdGhl Cj4gPiBncm91cCBJRCBpcyBzZXQgYWNjb3JkaW5nIHRvIGJpby0+Ymlfd3JpdGVfaGludCBiZWZv cmUgcGFzc2luZyB0aGUgQ0RCIHRvIFVGUy4KPiA+IAo+ID4gCj4gPiAJbHJicCA9ICZoYmEtPmxy Ylt0YWddOwo+ID4gICAgICAgICAgICAgICAgV0FSTl9PTihscmJwLT5jbWQpOwo+ID4gICAgICAg ICAgICAgICArIGlmKGNtZC0+Y21uZFswXSA9PSBXUklURV8xMCkKPiA+ICAgICAgICAgICAgICAg ICt7Cj4gPiAgICAgICAgICAgICAgICAgICsgICAgICAgICAgICAgY21kLT5jbW5kWzZdID0gKDB4 MWYmIGNtZC0+cmVxdWVzdC0+YmlvLT5iaV93cml0ZV9oaW50KTsKPiA+ICAgICAgICAgICAgICAg ICt9Cj4gPiAgICAgICAgICAgICAgICBscmJwLT5jbWQgPSBjbWQ7Cj4gPiAgICAgICAgICAgICAg ICBscmJwLT5zZW5zZV9idWZmbGVuID0gVUZTX1NFTlNFX1NJWkU7Cj4gPiAgICAgICAgICAgICAg ICBscmJwLT5zZW5zZV9idWZmZXIgPSBjbWQtPnNlbnNlX2J1ZmZlcjsKPiA+IAo+ID4gSSBkb24n dCBrbm93IHdoeSB0aGV5IGRvbid0IHB1c2ggdGhlc2UgY2hhbmdlcyB0byB0aGUgY29tbXVuaXR5 LCBtYXliZQo+ID4gaXQncyBiZWNhdXNlIGNoYW5nZXMgYWNyb3NzIHRoZSBmaWxlIHN5c3RlbSBh bmQgYmxvY2sgbGF5ZXJzIGFyZSB1bmFjY2VwdGFibGUgdG8gdGhlCj4gPiBibG9jayBsYXllciBh bmQgRlMuIGJ1dCBmb3Igc3VyZSB3ZSBzaG91bGQgbm93IHdhcm4gdGhlbSB0byBwdXNoIHRvIHRo ZQo+ID4gY29tbXVuaXR5IGFzIHNvb24gYXMgcG9zc2libGUuCj4gCj4gVGhhbmtzIEJlYW4gZm9y IGhhdmluZyBzaGFyZWQgdGhpcyBpbmZvcm1hdGlvbi4gSSB0aGluayB0aGUgYWJvdmUgY29kZSBz ZXRzIHRoZSBHUk9VUAo+IE5VTUJFUiBpbmZvcm1hdGlvbiBpbiB0aGUgV1JJVEUoMTApIGNvbW1h bmQgYW5kIGFsc28gdGhhdCB0aGUgZm9sbG93aW5nIHRleHQgZnJvbSB0aGUKPiBVRlMgc3BlY2lm aWNhdGlvbiBhcHBsaWVzIHRvIHRoYXQgaW5mb3JtYXRpb246Cj4gPHF1b3RlPgo+IEdST1VQIE5V TUJFUjogTm90aWZpZXMgdGhlIFRhcmdldCBkZXZpY2UgdGhhdCB0aGUgZGF0YSBsaW5rZWQgdG8g YSBDb250ZXh0SUQ6Cj4gIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gICAgIEdS T1VQIE5VTUJFUiBWYWx1ZSAgICAgfCAgRnVuY3Rpb24KPiAgLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KPiAgMDAwMDBiICAgICAgICAgICAgICAgICAgICB8IERlZmF1bHQsIG5vIENv bnRleHQgSUQgaXMgYXNzb2NpYXRlZCB3aXRoIHRoZSByZWFkIG9wZXJhdGlvbi4KPiAgMDAwMDFi IHRvIDAxMTExYiAoMFhYWFhiKSB8IENvbnRleHQgSUQuIChYWFhYIEkgZnJvbSAwMDAxYiB0byAx MTExYiDigJAgQ29udGV4dCBJRCB2YWx1ZSkKPiAgMTAwMDBiICAgICAgICAgICAgICAgICAgICB8 IERhdGEgaGFzIFN5c3RlbSBEYXRhIGNoYXJhY3RlcmlzdGljcwo+ICAxMDAwMWIgdG8gMTExMTFi ICAgICAgICAgIHwgUmVzZXJ2ZWQKPiAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K PiAKPiBJbiBjYXNlIHRoZSBHUk9VUCBOVU1CRVIgaXMgc2V0IHRvIGEgcmVzZXJ2ZWQgdmFsdWUs IHRoZSBvcGVyYXRpb24gc2hhbGwgZmFpbCBhbmQgYSBzdGF0dXMKPiByZXNwb25zZSBvZiBDSEVD SyBDT05ESVRJT04gd2lsbCBiZSByZXR1cm5lZCBhbG9uZyB3aXRoIHRoZSBzZW5zZSBrZXkgc2V0 IHRvIElMTEVHQUwgUkVRVUVTVC4KPiA8L3F1b3RlPgo+IAo+IFNpbmNlIHRoZXJlIGlzIGEgZGVz aXJlIHRvIHJlbW92ZSB0aGUgd3JpdGUgaGludCBpbmZvcm1hdGlvbiBmcm9tIHN0cnVjdCBiaW8s IGlzIHRoZXJlCj4gYW55IG90aGVyIGluZm9ybWF0aW9uIHRoZSAic3lzdGVtIGRhdGEgY2hhcmFj dGVyaXN0aWNzIiBpbmZvcm1hdGlvbiBjYW4gYmUgZGVyaXZlZCBmcm9tPwo+IEhvdyBhYm91dCBl LmcuIGRlcml2aW5nIHRoYXQgaW5mb3JtYXRpb24gZnJvbSByZXF1ZXN0IGZsYWdzIGxpa2UgUkVR X1NZTkMsIFJFUV9NRVRBIGFuZC9vcgo+IFJFUV9JRExFPwo+IAoKWytDYyBsaW51eC1mMmZzLWRl dmVsXQoKSSB0aGluayB0aGUgZjJmcyBkZXZlbG9wZXJzIHdpbGwgbmVlZCB0byBjaGltZSBpbiBo ZXJlLCBhcyBpdCBsb29rcyBsaWtlIGYyZnMKdXNlcyB0aGUgd3JpdGUgaGludHMgZm9yIGRpZmZl cmVudCBkYXRhIGNhdGVnb3JpZXMgbGlrZSBob3QvY29sZC93YXJtLiAgSSdtIG5vdApzdXJlIHRo b3NlIGNhbiBiZSBmdWxseSByZXByZXNlbnRlZCBieSBvdGhlciBiaW8gZmxhZ3MuCgpFaXRoZXIg d2F5LCB0aGUgZ29vZCBuZXdzIGlzIHRoYXQgaXQgc291bmRzIGxpa2UgdGhpcyAiR1JPVVAgTlVN QkVSIiB0aGluZyBpcwpwYXJ0IG9mIHRoZSBVRlMgc3RhbmRhcmQuICBTbyB3aGF0ZXZlciB0aGUg YmVzdCB3YXkgdG8gc3VwcG9ydCBpdCBpcywgaXQgY2FuCmp1c3QgYmUgc3VibWl0dGVkIHVwc3Ry ZWFtIGxpa2UgYW55IG90aGVyIHN0YW5kYXJkIFVGUyBmZWF0dXJlLiAgV2h5IGhhc24ndCB0aGF0 CmJlZW4gZG9uZT8KCi0gRXJpYwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMtZGV2 ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0L2xp c3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK