From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E44FC433F5 for ; Fri, 11 Mar 2022 16:33:25 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.289174.490618 (Exim 4.92) (envelope-from ) id 1nSiCG-0007dp-LE; Fri, 11 Mar 2022 16:32:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 289174.490618; Fri, 11 Mar 2022 16:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nSiCG-0007di-IN; Fri, 11 Mar 2022 16:32:56 +0000 Received: by outflank-mailman (input) for mailman id 289174; Fri, 11 Mar 2022 16:32:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nSiCE-0007db-Kl for xen-devel@lists.xenproject.org; Fri, 11 Mar 2022 16:32:54 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4dca70a-a158-11ec-8eba-a37418f5ba1a; Fri, 11 Mar 2022 17:32:52 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9B6855C0281; Fri, 11 Mar 2022 11:32:50 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 11 Mar 2022 11:32:50 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Mar 2022 11:32:49 -0500 (EST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4dca70a-a158-11ec-8eba-a37418f5ba1a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7AhpJBKPcuqB+//iI 3WdKqhkxmxc6gcb4790oS/b6Y0=; b=fMEye0MUm/bNsvzUMfHUY8wx0vhbqNOjd mU2t5eAwjjEVkYKX0KMyPL0sTeBRkGFtLaZVLA6J0TD73yPIvperwR5QyUlB59TP DtFgDQFyXe8af82VlSB9YtAGCAuaxw/N+hs522SyrYEXWbpzWQKutnzG1lDbt5j9 0VNJXp94wz2WCf28VsPUsTaVqKhOpHtPBJIC/sB6c4ga3K+VeIwuACRMB2lytV65 m8nb6dnwmRz+2NtnCr7WVKOVSzTdgvkmMjmRfJrw8CObJna9W8JP0TRY4fXwjAK2 +FLqqpRjppfTQjoYvAGYWrLL8IWdDtHQVIxbRy+fjxh8/oS4MxK8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvvddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeetveff iefghfekhffggeeffffhgeevieektedthfehveeiheeiiedtudegfeetffenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhes ihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Date: Fri, 11 Mar 2022 17:32:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Julien Grall , Jan Beulich , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs Message-ID: References: <53361d65-2bd8-c07b-938c-91b95f2d68ad@suse.com> <3055b4a5-2d55-9cf1-1069-8c57208bf0af@xen.org> <2a5c59ad-2fa5-b668-8bce-0d55e89a4afd@xen.org> <5cedf43b-3903-9668-69a0-01b8ba339ba7@xen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lWJNIGd8CEP9PnML" Content-Disposition: inline In-Reply-To: --lWJNIGd8CEP9PnML Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 11 Mar 2022 17:32:45 +0100 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Roger Pau =?utf-8?B?TW9ubsOp?= Cc: Julien Grall , Jan Beulich , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs On Fri, Mar 11, 2022 at 04:43:22PM +0100, Roger Pau Monn=C3=A9 wrote: > Sorry, maybe this wasn't clear. My suggestion was not to just do this > fix and call it done, but rather to add this check for sanity and then > figure out how to properly handle this specific device. Yes, I agree. Having it properly configured is preferred. Linux manages to do that, but I'm not sure how exactly. But ... > So adding the check here is not a workaround in order to support Intel > LPSS, but rather a generic fix to ns16550 for an issue which happens > to be triggered by Intel LPSS. We would still need to figure how to > handle that specific Line value. I haven't looked at the docs, will do > on Monday hopefully. =2E.. having fallback to a poll mode is still better than crashing the hypervisor or not using such console at all. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --lWJNIGd8CEP9PnML Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmIrea4ACgkQ24/THMrX 1yzoQAf9EC+6Z9gQeTqZM3USmxOkjfKZDoG2g6kGqCYUxUGULHJfy8/e0aSeaWOH BWKzX3EMcG931WTZgroBqLYxYePWiM8M7GIr9s4tj5hgndQkAYf3zDaRH9Z5Opno y/3OdeYQhTZdePqj2X1pU0JmdFfHbyYYWo7HNga/Rxax0Bu0u3UO1fGXGDTRQKhz H6niPuykyfB4EgK3Dh5HmJkb96dSQZ9uE6WmQyedxILOOa3gn9gtuOKtIKQows5t kXTsMdKYmYhlPFUkJfvOyqsC/cD44Wgai9WX0aHCiT7o4WUaGis1AatAK6ZaFetk xR/iqBN93Hq8DzhwlXuH2kZJFUGm4Q== =tKWg -----END PGP SIGNATURE----- --lWJNIGd8CEP9PnML--