Re: [LTP] [PATCH v2 5/6] shell: Add test for TST_FORMAT_DEVICE=1

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > > +TST_FORMAT_DEVICE=1
> > > +TST_TESTFUNC=test
> > > +TST_CNT=2
> > > +TST_DEV_FS_OPTS="-b 1024 -O quota"
> > > +TST_DEV_EXTRA_OPTS="5m"
> > > +TST_NEEDS_CMDS="df lsblk"
> This is left over from previous versions => should be deleted.
> > > +. tst_test.sh
> > > +
> > > +test1()
> > > +{
> > > +	tst_res TPASS "device formatted"
> > > +}
> > > +
> > > +test2()
> > > +{
> > > +	tst_check_cmds df || return
> > We have checked df command in TST_NEEDS_CMDS, why still check it again
> > in here?
> Correct, TST_NEEDS_CMDS should be removed so that at least creating the device
> (test1) is supported even SUT is missing df.

And what do we need the lsblk command for?

Other than the TST_NEEDS_CMD= variable:

Reviwed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp