From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/9] Rewrite userns01.c using new LTP API
Date: Fri, 25 Mar 2022 11:24:37 +0100 [thread overview]
Message-ID: <Yj2YZWJqGL2R7oja@pevik> (raw)
In-Reply-To: <20220325093626.11114-2-andrea.cervesato@suse.de>
Hi Andrea,
> diff --git a/testcases/kernel/containers/userns/userns01.c b/testcases/kernel/containers/userns/userns01.c
> -/*
> - * Verify that:
> - * If a user ID has no mapping inside the namespace, user ID and group
> - * ID will be the value defined in the file /proc/sys/kernel/overflowuid(65534)
> - * and /proc/sys/kernel/overflowgid(65534). A child process has a full set
> - * of permitted and effective capabilities, even though the program was
> - * run from an unprivileged account.
> +/*\
> + * [Description]
> + *
> + * Verify that if a user ID has no mapping inside the namespace, user ID and
> + * group ID will be the value defined in the file /proc/sys/kernel/overflowuid(65534)
> + * and /proc/sys/kernel/overflowgid(65534). A child process has a full set of
> + * permitted and effective capabilities, even though the program was run from an
> + * unprivileged account.
> */
nit:
-/proc/sys/kernel/overflowuid(65534)
+/proc/sys/kernel/overflowuid (defaults 65534)
and to overflowgid.
to make it a bit more readable. Can be done before merge.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-25 10:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 9:36 [LTP] [PATCH v3 0/9] Rewrite userns testing suite using new LTP API Andrea Cervesato
2022-03-25 9:36 ` [LTP] [PATCH v3 1/9] Rewrite userns01.c " Andrea Cervesato
2022-03-25 10:24 ` Petr Vorel [this message]
2022-03-25 15:43 ` Cyril Hrubis
2022-03-25 9:36 ` [LTP] [PATCH v3 2/9] Rewrite userns02.c " Andrea Cervesato
2022-03-25 10:25 ` Petr Vorel
2022-03-25 10:27 ` Petr Vorel
2022-03-25 10:28 ` Petr Vorel
2022-03-25 15:58 ` Cyril Hrubis
2022-03-28 20:50 ` Petr Vorel
2022-03-25 9:36 ` [LTP] [PATCH v3 3/9] Rewrite userns03.c " Andrea Cervesato
2022-03-25 10:28 ` Petr Vorel
2022-03-25 16:29 ` Cyril Hrubis
2022-03-25 9:36 ` [LTP] [PATCH v3 4/9] " Andrea Cervesato
2022-03-25 10:29 ` Petr Vorel
2022-03-25 10:30 ` Petr Vorel
2022-03-29 10:48 ` Cyril Hrubis
2022-03-25 9:36 ` [LTP] [PATCH v3 5/9] Rewrite userns05.c " Andrea Cervesato
2022-03-25 10:31 ` Petr Vorel
2022-03-29 12:36 ` Cyril Hrubis
2022-03-25 9:36 ` [LTP] [PATCH v3 6/9] Rewrite userns06.c " Andrea Cervesato
2022-03-25 10:32 ` Petr Vorel
2022-03-29 12:35 ` Cyril Hrubis
2022-03-25 9:36 ` [LTP] [PATCH v3 7/9] Rewrite userns07.c " Andrea Cervesato
2022-03-25 10:33 ` Petr Vorel
2022-03-29 14:27 ` Cyril Hrubis
2022-03-25 9:36 ` [LTP] [PATCH v3 8/9] Remove libclone dependency from userns suite Andrea Cervesato
2022-03-25 10:33 ` Petr Vorel
2022-03-25 9:36 ` [LTP] [PATCH v3 9/9] Remove obsolete userns_helper.h " Andrea Cervesato
2022-03-25 10:34 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj2YZWJqGL2R7oja@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.