All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <ak@linux.intel.com>, Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 1/3] perf lock: Add --synth=no option for record
Date: Fri, 25 Mar 2022 15:26:32 -0300	[thread overview]
Message-ID: <Yj4JWOeiRUy4jlGd@kernel.org> (raw)
In-Reply-To: <20220323230259.288494-1-namhyung@kernel.org>

Em Wed, Mar 23, 2022 at 04:02:57PM -0700, Namhyung Kim escreveu:
> The perf lock command has nothing to symbolize and lock names come
> from the tracepoint.  Moreover, kernel symbols are available even the
> --synth=no option is given.
> 
> This will reduce the startup time by avoiding unnecessary synthesis.

Thanks, applied the series.

- Arnaldo

 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-lock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index 57b9ebd7118a..1ebff88bc5ba 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -990,7 +990,7 @@ static int __cmd_report(bool display_info)
>  static int __cmd_record(int argc, const char **argv)
>  {
>  	const char *record_args[] = {
> -		"record", "-R", "-m", "1024", "-c", "1",
> +		"record", "-R", "-m", "1024", "-c", "1", "--synth", "no",
>  	};
>  	unsigned int rec_argc, i, j, ret;
>  	const char **rec_argv;
> -- 
> 2.35.1.894.gb6a874cedc-goog

-- 

- Arnaldo

      parent reply	other threads:[~2022-03-25 19:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 23:02 [PATCH 1/3] perf lock: Add --synth=no option for record Namhyung Kim
2022-03-23 23:02 ` [PATCH 2/3] perf lock: Extend struct lock_key to have print function Namhyung Kim
2022-03-23 23:02 ` [PATCH 3/3] perf lock: Add -F/--field option to control output Namhyung Kim
2022-03-25 18:26 ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yj4JWOeiRUy4jlGd@kernel.org \
    --to=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.