From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D7AC433F5 for ; Sat, 26 Mar 2022 14:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232620AbiCZOGi (ORCPT ); Sat, 26 Mar 2022 10:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231482AbiCZOGi (ORCPT ); Sat, 26 Mar 2022 10:06:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5C43166E2D; Sat, 26 Mar 2022 07:05:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 47E6C60EF5; Sat, 26 Mar 2022 14:05:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F896C340EE; Sat, 26 Mar 2022 14:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648303500; bh=YV78RkwSqUG0hLwgVwl5hr9tAbUXieZCvNBdqQm1qeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T95ZysXDWz4DxLK2/bdoG2u1QAl1UMbT7gLNzWUboVeAHh7jV4bLRV+7JzYUWnhVn 2RXOBc7kF2oYb7VKWJi0rjrJGCCXpYO2D0DF8yaGNWQ6dI1IWiRoG8/ZJZARmAUe6c LSuMIO8rhK6/YJYLAuAAm39D7HBhsO/esZNGlmXgUB0zi+Tv7o5/7kG/ShwleFC+JI 6WxUJhUBo/YVE/nHoXYCB/C8yin0zbjnDeGupOrvxXjpK37PYw57Ybed+JloBXKIu5 RM4pzu6u9qktN1YtmiGc4OScezfpAR1kXqfNj4y8EvHvTYhfrNofwopT2PIP8vuHQF AE9Ts1e9JQf0g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 6AF8D40407; Sat, 26 Mar 2022 11:04:58 -0300 (-03) Date: Sat, 26 Mar 2022 11:04:58 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, german.gomez@arm.com, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v4 2/4] perf arm-spe: Use SPE data source for neoverse cores Message-ID: References: <20220324183323.31414-1-alisaidi@amazon.com> <20220324183323.31414-3-alisaidi@amazon.com> <20220326134754.GD20556@leoy-ThinkPad-X240s> <20220326135653.GE20556@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220326135653.GE20556@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org Em Sat, Mar 26, 2022 at 09:56:53PM +0800, Leo Yan escreveu: > On Sat, Mar 26, 2022 at 10:52:01AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sat, Mar 26, 2022 at 09:47:54PM +0800, Leo Yan escreveu: > > > On Thu, Mar 24, 2022 at 06:33:21PM +0000, Ali Saidi wrote: > > > > +static void arm_spe__synth_data_source_neoverse(const struct arm_spe_record *record, > > > > + union perf_mem_data_src *data_src) > > > > { > > > > - union perf_mem_data_src data_src = { 0 }; > > > > + /* > > > > + * Even though four levels of cache hierarchy are possible, no known > > > > + * production Neoverse systems currently include more than three levels > > > > + * so for the time being we assume three exist. If a production system > > > > + * is built with four the this function would have to be changed to > > > > + * detect the number of levels for reporting. > > > > + */ > > > > - if (record->op == ARM_SPE_LD) > > > > - data_src.mem_op = PERF_MEM_OP_LOAD; > > > > - else > > > > - data_src.mem_op = PERF_MEM_OP_STORE; > > > Firstly, apologize that I didn't give clear idea when Ali sent patch sets > > > v2 and v3. > > Ok, removing this as well. > > Thanks for reviewing. > Thanks a lot, Arnaldo. Yeah, it's good to give a bit more time to > dismiss the concerns in this patch. Sure, at least it was build tested on many distros/cross compilers and this part is ok 8-) > Sorry again for the inconvenience. np. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45F45C433F5 for ; Sat, 26 Mar 2022 14:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QLnrHQskhq5C1eZLRODfpmyAXWLWc6bTVMVd21uRXpQ=; b=Bl9U8RroQlzXaf cQa1V6oUq0NS2iIReaytJhXQdAHzyeJX1T8PW+mPLsaWVNW1PBgJvlvxvY83u3DyNEtYZjN+nZ45B 0T5J0sPj2nqEOJh3leCx6c5lu2SHvcpCamRKdmf7tX/Pp/0v2X2HERxd2eV+woaJ6n/uQE+3V9jnI VpZ38k5T60MCTkOTdhAdKWHbnOpsrFk0yqR2gOcK5/fhEHsk4BFekrmyjqMR7D3YuurT4BgnhMCp6 t4cW5k1qbDKF3LWerrciylIBw5OsMsSf6FrT35gzBzTesDx/YkBO1a3RSfb35MrbKASPHPVT6hlim 9QljCzGT6yD8dFlsvNmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY72P-004MD9-0e; Sat, 26 Mar 2022 14:05:05 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY72M-004MCr-QZ for linux-arm-kernel@bombadil.infradead.org; Sat, 26 Mar 2022 14:05:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bj0zisU+J0UJw8y3oNUSuAmYQeTTo83lLWRdDGnZvTE=; b=LPUGX8YtOVW7ilocLjEvGpl5tG aSS3IzWGhi4xoTZMnfHdUaFoQ8mJPAGvUDu17v8lcAKk6anES2F4aEbJjt0Zsgu27uYpT27gITKsR k2RBChMsHt9pn5WtY0lFgDvHb3qYbdzuOB6RwqAzMs8akaVdPlOqKTealQ6QjkL9m+sYy2D/4zm3U 4Fy0Z9+VMnhNMC2CmjzgAZ4bB0MosT2qze9+v1lvzabD5YO4/qSRum8ui/VsbS+969xd1hPtRSo/T PUHeJtLxM/A4cdojK4YPZwn2YBFLSZU+8/pho0SRlDdcIEGdBHziTfrDzxyDkFo4TYiUZtEIhMKPS edJ3JTBQ==; Received: from [187.19.238.43] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY72L-00FIZ5-7Q; Sat, 26 Mar 2022 14:05:01 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 6AF8D40407; Sat, 26 Mar 2022 11:04:58 -0300 (-03) Date: Sat, 26 Mar 2022 11:04:58 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, german.gomez@arm.com, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v4 2/4] perf arm-spe: Use SPE data source for neoverse cores Message-ID: References: <20220324183323.31414-1-alisaidi@amazon.com> <20220324183323.31414-3-alisaidi@amazon.com> <20220326134754.GD20556@leoy-ThinkPad-X240s> <20220326135653.GE20556@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220326135653.GE20556@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Sat, Mar 26, 2022 at 09:56:53PM +0800, Leo Yan escreveu: > On Sat, Mar 26, 2022 at 10:52:01AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sat, Mar 26, 2022 at 09:47:54PM +0800, Leo Yan escreveu: > > > On Thu, Mar 24, 2022 at 06:33:21PM +0000, Ali Saidi wrote: > > > > +static void arm_spe__synth_data_source_neoverse(const struct arm_spe_record *record, > > > > + union perf_mem_data_src *data_src) > > > > { > > > > - union perf_mem_data_src data_src = { 0 }; > > > > + /* > > > > + * Even though four levels of cache hierarchy are possible, no known > > > > + * production Neoverse systems currently include more than three levels > > > > + * so for the time being we assume three exist. If a production system > > > > + * is built with four the this function would have to be changed to > > > > + * detect the number of levels for reporting. > > > > + */ > > > > - if (record->op == ARM_SPE_LD) > > > > - data_src.mem_op = PERF_MEM_OP_LOAD; > > > > - else > > > > - data_src.mem_op = PERF_MEM_OP_STORE; > > > Firstly, apologize that I didn't give clear idea when Ali sent patch sets > > > v2 and v3. > > Ok, removing this as well. > > Thanks for reviewing. > Thanks a lot, Arnaldo. Yeah, it's good to give a bit more time to > dismiss the concerns in this patch. Sure, at least it was build tested on many distros/cross compilers and this part is ok 8-) > Sorry again for the inconvenience. np. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel