From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Craig Hesling <hesling@chromium.org>,
Tom Hughes <tomhughes@chromium.org>,
Alexandru M Stan <amstan@chromium.org>
Subject: Re: [PATCH 1/2] dt-bindings: mfd: Add ChromeOS fingerprint binding
Date: Tue, 15 Mar 2022 11:08:47 +0800 [thread overview]
Message-ID: <YjADP+8mNnlkcGF7@google.com> (raw)
In-Reply-To: <20220314232214.4183078-2-swboyd@chromium.org>
On Mon, Mar 14, 2022 at 04:22:13PM -0700, Stephen Boyd wrote:
> Add a binding to describe the fingerprint processor found on Chromeboks
> with a fingerprint sensor.
Nit: s/Chromeboks/Chromebooks/.
> +properties:
> + compatible:
> + const: google,cros-ec-fp
Not sure if it could make sense for FPS with other interfaces: would
cros-ec-fp-spi or cros-ec-spi-fp be a better name? I am wondering because
there are cros-ec-spi specific properties "google,cros-ec-spi-pre-delay" and
"google,cros-ec-spi-msg-delay" in the binding.
> + reset-gpios:
> + maxItems: 1
> + description: reset signal (active low).
> +
> + boot0-gpios:
> + maxItems: 1
> + description: boot signal (low for normal boot; high for bootloader).
> +
> + vdd-supply:
> + description: Power supply for the fingerprint controller.
To be consistent: s/Power/power/.
next prev parent reply other threads:[~2022-03-15 3:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 23:22 [PATCH 0/2] Update cros-ec-spi for fingerprint devices Stephen Boyd
2022-03-14 23:22 ` [PATCH 1/2] dt-bindings: mfd: Add ChromeOS fingerprint binding Stephen Boyd
2022-03-15 0:23 ` Alexandru M Stan
2022-03-15 15:50 ` Stephen Boyd
2022-03-15 3:08 ` Tzung-Bi Shih [this message]
2022-03-15 15:38 ` Stephen Boyd
2022-03-15 10:41 ` Krzysztof Kozlowski
2022-03-15 11:10 ` Lee Jones
2022-03-15 11:22 ` Krzysztof Kozlowski
2022-03-15 11:30 ` Lee Jones
2022-03-15 15:41 ` Stephen Boyd
2022-03-15 15:48 ` Lee Jones
2022-03-15 16:19 ` Stephen Boyd
2022-03-16 7:25 ` Lee Jones
2022-03-14 23:22 ` [PATCH 2/2] platform/chrome: cros_ec_spi: Boot fingerprint processor during probe Stephen Boyd
2022-03-15 0:36 ` Alexandru M Stan
2022-03-15 16:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjADP+8mNnlkcGF7@google.com \
--to=tzungbi@kernel.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=hesling@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tomhughes@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.