From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E108C433EF for ; Tue, 15 Mar 2022 14:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WsnKurcMUf3Syk9QGRDyQ2hpWviqz5U3BZKSILkuK4o=; b=ajZG3MJLzwIlj0 6M81TePlZHHbFZ+Jqif5mipFNd6WvV7l4DiSVkIbbIDMeLQZgDfvHhAKRwMNPWfGn+9sINwhglVub fm1whxqGkH6pxuBNezd9R/PNsRF2e3/PsjUuoXOWvkPS4IwVKd5ahq5pfsrdyXM0SSv5O136YuXWS TM9Xtkg19+aBl5n34/u4DQdwyEU83Ev4qOV5uDu3gzrbYpvWPv5rfRclIXDt0Noz+A1UPM4xHLfJa rfWT3faWvWElAiUHHAOkfniiOT7p5w68u5TZgVvCnUu0kUuzerjB/cTin60FN5ZArRwANj8V2lY09 h4CBF6BsRbSmcEOllDbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU8Ah-009Rp1-V7; Tue, 15 Mar 2022 14:29:12 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU8Ad-009RnI-PS for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 14:29:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GxMzfNRQtZ04+lHo/O1UCEwaB2Ydbfpf2yzGh5HPxHc=; b=olC8YY+DSx6sXmlZVmrtQDGF50 04E3CKz3W/4CMUH8fsWmF8Mu0+RcSMZEzzPIkruCbYjw5rkXzg0lzMSycIvLuXicr9N9VEON67G9l lxmB3rRgBHTIH85AAh/Vjr9VDBs+sZLs3TteZ/CveoanmoAm0TA4/npRKzTXwCXWz8Xg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nU8AM-00AyZC-FB; Tue, 15 Mar 2022 15:28:50 +0100 Date: Tue, 15 Mar 2022 15:28:50 +0100 From: Andrew Lunn To: Chris Packham Cc: "robh+dt@kernel.org" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 7/8] arm64: dts: marvell: Add Armada 98DX2530 SoC and RD-AC5X board Message-ID: References: <20220314213143.2404162-1-chris.packham@alliedtelesis.co.nz> <20220314213143.2404162-8-chris.packham@alliedtelesis.co.nz> <7b78853e-71ec-7c57-4cac-5cd6303f3b13@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7b78853e-71ec-7c57-4cac-5cd6303f3b13@alliedtelesis.co.nz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_072907_859389_B7A8D47A X-CRM114-Status: GOOD ( 17.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 15, 2022 at 02:11:56AM +0000, Chris Packham wrote: > > On 15/03/22 13:24, Andrew Lunn wrote: > >> diff --git a/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi b/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi > >> new file mode 100644 > >> index 000000000000..ebe464b9ebd2 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi > >> @@ -0,0 +1,343 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Device Tree For AC5. > >> + * > >> + * Copyright (C) 2021 Marvell > >> + * > >> + */ > >> + > >> +/dts-v1/; > >> + memory@0 { > >> + device_type = "memory"; > >> + reg = <0x2 0x00000000 0x0 0x40000000>; > >> + // linux,usable-memory = <0x2 0x00000000 0x0 0x80000000>; > >> + }; > > Is the memory part of the SoC, or is it on the board? Normally it is > > on the board, so should be in the .dts file. But Apple M1 etc... > I also wasn't sure about linux,usable-memory. It's commented out so it's > obviously doing nothing but should it? No other in-tree dts files have it. Hi Chris I've no idea what it means. Maybe search the SDK and see if they have some code and what it does. But i would drop it. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0053C433EF for ; Tue, 15 Mar 2022 14:29:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245565AbiCOOaQ (ORCPT ); Tue, 15 Mar 2022 10:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233525AbiCOOaQ (ORCPT ); Tue, 15 Mar 2022 10:30:16 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1457344779; Tue, 15 Mar 2022 07:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GxMzfNRQtZ04+lHo/O1UCEwaB2Ydbfpf2yzGh5HPxHc=; b=olC8YY+DSx6sXmlZVmrtQDGF50 04E3CKz3W/4CMUH8fsWmF8Mu0+RcSMZEzzPIkruCbYjw5rkXzg0lzMSycIvLuXicr9N9VEON67G9l lxmB3rRgBHTIH85AAh/Vjr9VDBs+sZLs3TteZ/CveoanmoAm0TA4/npRKzTXwCXWz8Xg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nU8AM-00AyZC-FB; Tue, 15 Mar 2022 15:28:50 +0100 Date: Tue, 15 Mar 2022 15:28:50 +0100 From: Andrew Lunn To: Chris Packham Cc: "robh+dt@kernel.org" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 7/8] arm64: dts: marvell: Add Armada 98DX2530 SoC and RD-AC5X board Message-ID: References: <20220314213143.2404162-1-chris.packham@alliedtelesis.co.nz> <20220314213143.2404162-8-chris.packham@alliedtelesis.co.nz> <7b78853e-71ec-7c57-4cac-5cd6303f3b13@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b78853e-71ec-7c57-4cac-5cd6303f3b13@alliedtelesis.co.nz> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 15, 2022 at 02:11:56AM +0000, Chris Packham wrote: > > On 15/03/22 13:24, Andrew Lunn wrote: > >> diff --git a/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi b/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi > >> new file mode 100644 > >> index 000000000000..ebe464b9ebd2 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi > >> @@ -0,0 +1,343 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Device Tree For AC5. > >> + * > >> + * Copyright (C) 2021 Marvell > >> + * > >> + */ > >> + > >> +/dts-v1/; > >> + memory@0 { > >> + device_type = "memory"; > >> + reg = <0x2 0x00000000 0x0 0x40000000>; > >> + // linux,usable-memory = <0x2 0x00000000 0x0 0x80000000>; > >> + }; > > Is the memory part of the SoC, or is it on the board? Normally it is > > on the board, so should be in the .dts file. But Apple M1 etc... > I also wasn't sure about linux,usable-memory. It's commented out so it's > obviously doing nothing but should it? No other in-tree dts files have it. Hi Chris I've no idea what it means. Maybe search the SDK and see if they have some code and what it does. But i would drop it. Andrew