From: Greg KH <gregkh@linuxfoundation.org>
To: Charlie Sands <sandsch@northvilleschools.net>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues.
Date: Wed, 16 Mar 2022 07:29:08 +0100 [thread overview]
Message-ID: <YjGDtLvysfyVQHLm@kroah.com> (raw)
In-Reply-To: <YjEB27xzf+krm3ew@sckzor-linux.localdomain>
On Tue, Mar 15, 2022 at 05:15:07PM -0400, Charlie Sands wrote:
> > Always test-build your patches. Applying this change results in a build
> > failure :(
> My apologies, I ran a build test on a copy of the repository with my changes
> stashed in order to look at the original checkpatch warnings.
>
> > Please fix up and resend.
> It should now fix the below issues without build warnings.
None of this should be in the changelog, please fix this up and send a
version 2 of this patch, properly listing what changed from the previous
version. Instructions on how to do that should be in the documentation.
thanks,
greg k-h
next prev parent reply other threads:[~2022-03-16 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 21:15 [PATCH] staging: rts5208: Resolve checkpath.pl issues Charlie Sands
2022-03-16 6:29 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-16 0:30 kernel test robot
2022-03-15 2:27 Charlie Sands
2022-03-15 14:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjGDtLvysfyVQHLm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sandsch@northvilleschools.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.