All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/2] tst_kernel: Fix search for foo-x86-64 module
Date: Wed, 16 Mar 2022 15:11:30 +0100	[thread overview]
Message-ID: <YjHwEt+hAVQ7bN/D@pevik> (raw)
In-Reply-To: <6231852C.5020506@fujitsu.com>

> Hi Petr
> I don't understand why we must serach foo-x86-64 module, so what problem 
> do you meet?

> I used 5.17-rc8,  it still use foo-x86_64 named rule for 
> kernel/arch/x86/crypto/libblake2s-x86_64.ko.

> If kernel has libblake2s-x86_64 module, then tst_check_driver will use 
> libblake2s_x86_64 to find, it should succeed.

> If kernel doesn't have libblake2s-x86_64 module, then tst_ckeck_driver 
> will search twice ,the first time use libblake2s-x86_64  and the second
> time use libblake2s_x86_64, then search failed.

tst_check_driver.sh is failing on intel based systems. Well, we could make sure
it does not try to test libblake2s-x86-64, IMHO it'd be better to make sure
tst_search_driver() works with it, because modinfo/modprobe works with it:

$ modinfo libblake2s-x86-64
name:           libblake2s_x86_64
filename:       (builtin)
license:        GPL v2
file:           arch/x86/crypto/libblake2s-x86_64

Sure, it's a corner case, but I'd still fix it.
Let's see what other think.

Kind regards,
Petr

> Best Regards
> Yang Xu

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-03-16 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 12:25 [LTP] [PATCH 0/2] Fix tst_search_driver for x86-64 modules Petr Vorel
2022-03-15 12:25 ` [LTP] [PATCH 1/2] tst_kernel: Fix search for foo-x86-64 module Petr Vorel
2022-03-16  6:34   ` xuyang2018.jy
2022-03-16 14:11     ` Petr Vorel [this message]
2022-03-18  7:40       ` Li Wang
2022-03-18  9:50         ` Petr Vorel
2022-03-21  8:19           ` Li Wang
2022-03-15 12:25 ` [LTP] [PATCH 2/2] tst_check_driver.sh: Add test for x68_64 module Petr Vorel
2022-07-27 13:05   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjHwEt+hAVQ7bN/D@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.