From: Matthias Kaehlcke <mka@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Alexandru M Stan <amstan@chromium.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc7280-herobrine: Drop outputs on fpmcu pins
Date: Thu, 17 Mar 2022 14:54:05 -0700 [thread overview]
Message-ID: <YjOt/aVJTLh4wqGo@google.com> (raw)
In-Reply-To: <20220317010640.2498502-2-swboyd@chromium.org>
On Wed, Mar 16, 2022 at 06:06:39PM -0700, Stephen Boyd wrote:
> Having these pins with outputs is good on a fresh boot because it puts
> the boot and reset pins in a known "good" state. Unfortunately, that
> conflicts with the fingerprint firmware flashing code. The firmware
> flashing process binds and unbinds the cros-ec and spidev drivers and
> that reapplies the pin output values after the flashing code has
> overridden the gpio values. This causes a problem because we try to put
> the device into bootloader mode, bind the spidev driver and that
> inadvertently puts it right back into normal boot mode, breaking the
> flashing process.
>
> Fix this by removing the outputs. We'll introduce a binding for
> fingerprint cros-ec specifically to set the gpios properly via gpio APIs
> during cros-ec driver probe instead.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2022-03-17 21:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 1:06 [PATCH 0/2] Fix and update fingerprint flashing on herobrine Stephen Boyd
2022-03-17 1:06 ` [PATCH 1/2] arm64: dts: qcom: sc7280-herobrine: Drop outputs on fpmcu pins Stephen Boyd
2022-03-17 21:54 ` Matthias Kaehlcke [this message]
2022-03-18 20:50 ` Doug Anderson
2022-03-17 1:06 ` [PATCH 2/2] arm64: dts: qcom: Fully describe fingerprint node on Herobrine Stephen Boyd
2022-03-17 22:06 ` Matthias Kaehlcke
2022-03-17 22:11 ` Stephen Boyd
2022-03-17 22:50 ` Matthias Kaehlcke
2022-03-18 20:55 ` Doug Anderson
2022-03-21 18:53 ` Stephen Boyd
2022-04-11 21:00 ` [PATCH 0/2] Fix and update fingerprint flashing on herobrine patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjOt/aVJTLh4wqGo@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=amstan@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.