From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Pawel Laszczak <pawell@cadence.com>,
Peter Chen <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_ppratap@quicinc.com
Subject: Re: [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion
Date: Fri, 18 Mar 2022 13:01:04 +0100 [thread overview]
Message-ID: <YjR0gNPdeI5FTBGs@kroah.com> (raw)
In-Reply-To: <1646130507-26796-3-git-send-email-quic_c_sanm@quicinc.com>
On Tue, Mar 01, 2022 at 03:58:26PM +0530, Sandeep Maheswaram wrote:
> Remove the header file and forward declare struct usb_hcd.
Why?
>
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
> include/linux/usb/xhci-plat.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/usb/xhci-plat.h b/include/linux/usb/xhci-plat.h
> index 906e907..576e400 100644
> --- a/include/linux/usb/xhci-plat.h
> +++ b/include/linux/usb/xhci-plat.h
> @@ -9,7 +9,8 @@
> #define _XHCI_PLAT_H
>
> #include <linux/types.h>
> -#include <linux/usb/hcd.h>
> +
> +struct usb_hcd;
>
> struct xhci_plat_priv {
> const char *firmware_name;
> --
> 2.7.4
>
Where did this come from? Is this fixing a build breakage from a
previous patch? If not, why is this needed?
confused,
greg k-h
next prev parent reply other threads:[~2022-03-18 12:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 10:28 [PATCH v2 0/3] Refactor xhci quirks and plat private data Sandeep Maheswaram
2022-03-01 10:28 ` [PATCH v2 1/3] usb: xhci: refactor " Sandeep Maheswaram
2022-03-18 12:00 ` Greg Kroah-Hartman
2022-03-01 10:28 ` [PATCH v2 2/3] usb: xhci: Remove unwanted header inclusion Sandeep Maheswaram
2022-03-18 12:01 ` Greg Kroah-Hartman [this message]
2022-03-21 9:17 ` Sandeep Maheswaram (Temp)
2022-03-21 9:34 ` Greg Kroah-Hartman
2022-03-01 10:28 ` [PATCH v2 3/3] usb: dwc: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT Sandeep Maheswaram
2022-03-18 12:01 ` Greg Kroah-Hartman
2022-03-21 6:09 ` Sandeep Maheswaram (Temp)
2022-03-17 5:47 ` [PATCH v2 0/3] Refactor xhci quirks and plat private data Sandeep Maheswaram (Temp)
2022-03-18 11:59 ` Greg Kroah-Hartman
2022-03-21 6:21 ` Sandeep Maheswaram (Temp)
2022-03-22 15:53 ` Mathias Nyman
2022-03-23 3:07 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjR0gNPdeI5FTBGs@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a-govindraju@ti.com \
--cc=balbi@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mka@chromium.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=quic_c_sanm@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=rogerq@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.