From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C816C433EF for ; Fri, 18 Mar 2022 17:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EFz6fC25LXXsEJKk2JQTMfnSc8+mqqOxhd4lABalEuI=; b=wptteNks/ZNqdP WaPL5NSXwhAGCs2TAdWZIHTv6uclSRSezMA26ymXfvd79JkOIe4cn0RKKV+hBxDuIIgy0eWiILlnA iH6IOjEXgz7c/MahTX+IO0XKTvJeZb01tskIbsKb4g5vtwg7zRX228fiPw9Z60GRxSqS6pR82T5u8 3kX27bpl0gy+2U/GcWyT7BMhbqTnWGoKXonTnRkBxksADLVYwtjLksbaGIi2EFVLFvVet+OSDjMdd HCLh1XyPvG+Ew6m25raA/nZ6Dqj3MaVw8W1mQmddwePR7mmDvSAOSKNkKzsXYwj+itX72BohdyUFn 725ekEzp4Hea+iSTA/fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVGFJ-002TY7-5o; Fri, 18 Mar 2022 17:18:37 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVGF6-002TVL-Ru; Fri, 18 Mar 2022 17:18:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54A7D619B6; Fri, 18 Mar 2022 17:18:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80BEDC340E8; Fri, 18 Mar 2022 17:18:20 +0000 (UTC) Date: Fri, 18 Mar 2022 17:18:16 +0000 From: Catalin Marinas To: Tong Tiangen Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pasha Tatashin , Andrew Morton , Will Deacon , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH -next 3/4] arm64: mm: add support for page table check Message-ID: References: <20220317141203.3646253-1-tongtiangen@huawei.com> <20220317141203.3646253-4-tongtiangen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_101824_970560_BBA23A76 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMTgsIDIwMjIgYXQgMTE6NTg6MjJBTSArMDgwMCwgVG9uZyBUaWFuZ2VuIHdy b3RlOgo+IOWcqCAyMDIyLzMvMTggMzowMCwgQ2F0YWxpbiBNYXJpbmFzIOWGmemBkzoKPiA+IE9u IFRodSwgTWFyIDE3LCAyMDIyIGF0IDAyOjEyOjAyUE0gKzAwMDAsIFRvbmcgVGlhbmdlbiB3cm90 ZToKPiA+ID4gQEAgLTYyOCw2ICs2NDcsMjUgQEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25n IHBtZF9wYWdlX3ZhZGRyKHBtZF90IHBtZCkKPiA+ID4gICAjZGVmaW5lIHB1ZF9sZWFmKHB1ZCkJ CXB1ZF9zZWN0KHB1ZCkKPiA+ID4gICAjZGVmaW5lIHB1ZF92YWxpZChwdWQpCQlwdGVfdmFsaWQo cHVkX3B0ZShwdWQpKQo+ID4gPiArI2lmZGVmIENPTkZJR19QQUdFX1RBQkxFX0NIRUNLCj4gPiA+ ICtzdGF0aWMgaW5saW5lIGJvb2wgcHRlX3VzZXJfYWNjZXNzaWJsZV9wYWdlKHB0ZV90IHB0ZSkK PiA+ID4gK3sKPiA+ID4gKwlyZXR1cm4gKHB0ZV92YWwocHRlKSAmIFBURV9WQUxJRCkgJiYgKHB0 ZV92YWwocHRlKSAmIFBURV9VU0VSKTsKPiA+ID4gK30KWy4uLl0KPiA+IERvIHdlIGNhcmUgYWJv dXQgUFJPVF9OT05FIG1hcHBpbmdzIGhlcmU/IFRoZXkgaGF2ZSB0aGUgdmFsaWQgYml0Cj4gPiBj bGVhcmVkIGJ1dCBwdGVfcHJlc2VudCgpIGlzIHRydWUuCj4gPiAKPiAKPiBQVEMgd2lsbCBub3Qg Y2hlY2sgdGhpcyBzcGVjaWFsIHR5cGUoUFJPVF9OT05FKSBvZiBwYWdlLgoKUFJPVF9OT05FIGlz IGp1c3QgYSBwZXJtaXNzaW9uIGJ1dCBzaW5jZSB3ZSBkb24ndCBoYXZlIGluZGVwZW5kZW50IHJl YWQKYW5kIHdyaXRlIGJpdHMgaW4gdGhlIHB0ZSwgd2UgaW1wbGVtZW50IGl0IGFzIGFuIGludmFs aWQgcHRlIChiaXQgMApjbGVhcmVkKS4gVGhlIG90aGVyIGNvbnRlbnQgb2YgdGhlIHB0ZSBpcyBm aW5lLCBzbyBwdGVfcGZuKCkgc2hvdWxkCnN0aWxsIHdvcmsuIFBUQyBjb3VsZCBhcyB3ZWxsIGNo ZWNrIHRoaXMsIEkgZG9uJ3QgdGhpbmsgaXQgaHVydHMuCgo+ID4gPiArc3RhdGljIGlubGluZSBi b29sIHBtZF91c2VyX2FjY2Vzc2libGVfcGFnZShwbWRfdCBwbWQpCj4gPiA+ICt7Cj4gPiA+ICsJ cmV0dXJuIHBtZF9sZWFmKHBtZCkgJiYgKHBtZF92YWwocG1kKSAmIFBURV9WQUxJRCkgJiYKPiA+ ID4gKwkJKHBtZF92YWwocG1kKSAmIFBURV9VU0VSKTsKPiA+ID4gK30KPiA+IAo+ID4gcG1kX2xl YWYoKSBpbXBsaWVzIHZhbGlkLCBzbyB5b3UgY2FuIHNraXAgaXQgaWYgdGhhdCdzIHRoZSBhaW0u Cj4gCj4gUFRDIG9ubHkgY2hlY2tzIHdoZXRoZXIgdGhlIG1lbW9yeSBibG9jayBjb3JyZXNwb25k aW5nIHRvIHRoZSBwbWRfbGVhZiB0eXBlCj4gY2FuIGFjY2VzcywgZm9yICFwbWRfbGVhZiwgUFRD IGNoZWNrcyBhdCB0aGUgcHRlIGxldmVsLiBTbyBpIHRoaW5rIHRoaXMgaXMKPiBuZWNlc3Nhcnku CgpNeSBwb2ludCBpcyB0aGF0IHRoZSAocG1kX3ZhbChwbWQpICYgUFRFX1ZBTElEKSBjaGVjayBp cyBzdXBlcmZsdW91cwpzaW5jZSB0aGF0J3MgY292ZXJlZCBieSBwbWRfbGVhZigpIGFscmVhZHku CgotLSAKQ2F0YWxpbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1y aXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFAF5C433F5 for ; Fri, 18 Mar 2022 17:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KLWupU4QbOo0wrwGriMUfpvjCCCssEJZIhmWbCS5XI4=; b=GaYdhR8RoUQuQ+ ecafXuFH2IRGCVL0Ef7wr15VNTh2A2C+4dFLimY3M7uHNGUlcPuHZPPYdfvKEnimRsgYi+SqlQ+KH cGJS7qlHpTh+MuoVXf3FC4YlvGaqLnodSR+0N0/unSFmz5HqLDp/9G7PdMvFqzN2kvL8jVaPvEm+g y9wwTBGL4qyMrESFrP7xxYSu8l0zExfF0j538L8E+XLyZ5o3d6Hsv4yiuixF+B2BmmBMUN3ckS8cT H7K2PjeHXb+/54aG1o4jVXXhNQmhvTYz8vRDwR0xeU70siXr03+f5PYz6N0z+BrWXFRzuxN0jBKbe 5hgEMFyNfoDSGay1NurQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVGFA-002TWR-Vi; Fri, 18 Mar 2022 17:18:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVGF6-002TVL-Ru; Fri, 18 Mar 2022 17:18:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54A7D619B6; Fri, 18 Mar 2022 17:18:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80BEDC340E8; Fri, 18 Mar 2022 17:18:20 +0000 (UTC) Date: Fri, 18 Mar 2022 17:18:16 +0000 From: Catalin Marinas To: Tong Tiangen Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pasha Tatashin , Andrew Morton , Will Deacon , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH -next 3/4] arm64: mm: add support for page table check Message-ID: References: <20220317141203.3646253-1-tongtiangen@huawei.com> <20220317141203.3646253-4-tongtiangen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_101824_970560_BBA23A76 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMTgsIDIwMjIgYXQgMTE6NTg6MjJBTSArMDgwMCwgVG9uZyBUaWFuZ2VuIHdy b3RlOgo+IOWcqCAyMDIyLzMvMTggMzowMCwgQ2F0YWxpbiBNYXJpbmFzIOWGmemBkzoKPiA+IE9u IFRodSwgTWFyIDE3LCAyMDIyIGF0IDAyOjEyOjAyUE0gKzAwMDAsIFRvbmcgVGlhbmdlbiB3cm90 ZToKPiA+ID4gQEAgLTYyOCw2ICs2NDcsMjUgQEAgc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25n IHBtZF9wYWdlX3ZhZGRyKHBtZF90IHBtZCkKPiA+ID4gICAjZGVmaW5lIHB1ZF9sZWFmKHB1ZCkJ CXB1ZF9zZWN0KHB1ZCkKPiA+ID4gICAjZGVmaW5lIHB1ZF92YWxpZChwdWQpCQlwdGVfdmFsaWQo cHVkX3B0ZShwdWQpKQo+ID4gPiArI2lmZGVmIENPTkZJR19QQUdFX1RBQkxFX0NIRUNLCj4gPiA+ ICtzdGF0aWMgaW5saW5lIGJvb2wgcHRlX3VzZXJfYWNjZXNzaWJsZV9wYWdlKHB0ZV90IHB0ZSkK PiA+ID4gK3sKPiA+ID4gKwlyZXR1cm4gKHB0ZV92YWwocHRlKSAmIFBURV9WQUxJRCkgJiYgKHB0 ZV92YWwocHRlKSAmIFBURV9VU0VSKTsKPiA+ID4gK30KWy4uLl0KPiA+IERvIHdlIGNhcmUgYWJv dXQgUFJPVF9OT05FIG1hcHBpbmdzIGhlcmU/IFRoZXkgaGF2ZSB0aGUgdmFsaWQgYml0Cj4gPiBj bGVhcmVkIGJ1dCBwdGVfcHJlc2VudCgpIGlzIHRydWUuCj4gPiAKPiAKPiBQVEMgd2lsbCBub3Qg Y2hlY2sgdGhpcyBzcGVjaWFsIHR5cGUoUFJPVF9OT05FKSBvZiBwYWdlLgoKUFJPVF9OT05FIGlz IGp1c3QgYSBwZXJtaXNzaW9uIGJ1dCBzaW5jZSB3ZSBkb24ndCBoYXZlIGluZGVwZW5kZW50IHJl YWQKYW5kIHdyaXRlIGJpdHMgaW4gdGhlIHB0ZSwgd2UgaW1wbGVtZW50IGl0IGFzIGFuIGludmFs aWQgcHRlIChiaXQgMApjbGVhcmVkKS4gVGhlIG90aGVyIGNvbnRlbnQgb2YgdGhlIHB0ZSBpcyBm aW5lLCBzbyBwdGVfcGZuKCkgc2hvdWxkCnN0aWxsIHdvcmsuIFBUQyBjb3VsZCBhcyB3ZWxsIGNo ZWNrIHRoaXMsIEkgZG9uJ3QgdGhpbmsgaXQgaHVydHMuCgo+ID4gPiArc3RhdGljIGlubGluZSBi b29sIHBtZF91c2VyX2FjY2Vzc2libGVfcGFnZShwbWRfdCBwbWQpCj4gPiA+ICt7Cj4gPiA+ICsJ cmV0dXJuIHBtZF9sZWFmKHBtZCkgJiYgKHBtZF92YWwocG1kKSAmIFBURV9WQUxJRCkgJiYKPiA+ ID4gKwkJKHBtZF92YWwocG1kKSAmIFBURV9VU0VSKTsKPiA+ID4gK30KPiA+IAo+ID4gcG1kX2xl YWYoKSBpbXBsaWVzIHZhbGlkLCBzbyB5b3UgY2FuIHNraXAgaXQgaWYgdGhhdCdzIHRoZSBhaW0u Cj4gCj4gUFRDIG9ubHkgY2hlY2tzIHdoZXRoZXIgdGhlIG1lbW9yeSBibG9jayBjb3JyZXNwb25k aW5nIHRvIHRoZSBwbWRfbGVhZiB0eXBlCj4gY2FuIGFjY2VzcywgZm9yICFwbWRfbGVhZiwgUFRD IGNoZWNrcyBhdCB0aGUgcHRlIGxldmVsLiBTbyBpIHRoaW5rIHRoaXMgaXMKPiBuZWNlc3Nhcnku CgpNeSBwb2ludCBpcyB0aGF0IHRoZSAocG1kX3ZhbChwbWQpICYgUFRFX1ZBTElEKSBjaGVjayBp cyBzdXBlcmZsdW91cwpzaW5jZSB0aGF0J3MgY292ZXJlZCBieSBwbWRfbGVhZigpIGFscmVhZHku CgotLSAKQ2F0YWxpbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04121C433F5 for ; Fri, 18 Mar 2022 17:18:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FCE68D0002; Fri, 18 Mar 2022 13:18:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D2188D0001; Fri, 18 Mar 2022 13:18:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 399498D0002; Fri, 18 Mar 2022 13:18:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 2B1268D0001 for ; Fri, 18 Mar 2022 13:18:26 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D50FC6040B for ; Fri, 18 Mar 2022 17:18:25 +0000 (UTC) X-FDA: 79258165770.13.F1D5C1C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 457C14001E for ; Fri, 18 Mar 2022 17:18:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54A7D619B6; Fri, 18 Mar 2022 17:18:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80BEDC340E8; Fri, 18 Mar 2022 17:18:20 +0000 (UTC) Date: Fri, 18 Mar 2022 17:18:16 +0000 From: Catalin Marinas To: Tong Tiangen Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Pasha Tatashin , Andrew Morton , Will Deacon , Paul Walmsley , Palmer Dabbelt , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH -next 3/4] arm64: mm: add support for page table check Message-ID: References: <20220317141203.3646253-1-tongtiangen@huawei.com> <20220317141203.3646253-4-tongtiangen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 457C14001E X-Stat-Signature: 1wxp6wkxnjdygteohtesjxyshsxbqdr3 Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf01.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Rspam-User: X-HE-Tag: 1647623905-702153 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 18, 2022 at 11:58:22AM +0800, Tong Tiangen wrote: > 在 2022/3/18 3:00, Catalin Marinas 写道: > > On Thu, Mar 17, 2022 at 02:12:02PM +0000, Tong Tiangen wrote: > > > @@ -628,6 +647,25 @@ static inline unsigned long pmd_page_vaddr(pmd_t pmd) > > > #define pud_leaf(pud) pud_sect(pud) > > > #define pud_valid(pud) pte_valid(pud_pte(pud)) > > > +#ifdef CONFIG_PAGE_TABLE_CHECK > > > +static inline bool pte_user_accessible_page(pte_t pte) > > > +{ > > > + return (pte_val(pte) & PTE_VALID) && (pte_val(pte) & PTE_USER); > > > +} [...] > > Do we care about PROT_NONE mappings here? They have the valid bit > > cleared but pte_present() is true. > > > > PTC will not check this special type(PROT_NONE) of page. PROT_NONE is just a permission but since we don't have independent read and write bits in the pte, we implement it as an invalid pte (bit 0 cleared). The other content of the pte is fine, so pte_pfn() should still work. PTC could as well check this, I don't think it hurts. > > > +static inline bool pmd_user_accessible_page(pmd_t pmd) > > > +{ > > > + return pmd_leaf(pmd) && (pmd_val(pmd) & PTE_VALID) && > > > + (pmd_val(pmd) & PTE_USER); > > > +} > > > > pmd_leaf() implies valid, so you can skip it if that's the aim. > > PTC only checks whether the memory block corresponding to the pmd_leaf type > can access, for !pmd_leaf, PTC checks at the pte level. So i think this is > necessary. My point is that the (pmd_val(pmd) & PTE_VALID) check is superfluous since that's covered by pmd_leaf() already. -- Catalin