From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ADD1C433F5 for ; Sun, 20 Mar 2022 21:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343727AbiCTVXZ (ORCPT ); Sun, 20 Mar 2022 17:23:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236574AbiCTVXZ (ORCPT ); Sun, 20 Mar 2022 17:23:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A058F18A3E9; Sun, 20 Mar 2022 14:22:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5FA5DB80EFA; Sun, 20 Mar 2022 21:22:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9552CC340E9; Sun, 20 Mar 2022 21:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647811319; bh=VCO2HOCuTBN+Xv7u6MBQ5uA0+TGwA+QA643VoWQB4s0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RH/gyeIDR4Y6vBxwoPf+bvJnNWspNNBT6gVUuJ9ByOxDzlcnQ1M4u09mnX13tV9c6 q2FQMNR7zBKXmEBj4OcDYHkQD9+QXNGC4phBUINAh4Kq2rtvmRzsDQcAehbLm2zTFZ S66yZl1SlynQdT7eBHOzO79uVIDut3UFF8vGeXrmAKHLyMZIhWNHKAnCNTR/e7eFeV +FuwOc7ufk2jvR348NiSyo2dQrWbV3wGyizX1vilR/Hd6b8ie8XpkyYI/G23x9B6r6 CcKnrUa1WLRAkGNRJ7MWVgFuTQxUwA6HrZYXC3XPfGlN8aWOtjje1HxTnhfYttgLgR IGANPRJRxzQow== Date: Sun, 20 Mar 2022 23:23:00 +0200 From: Jarkko Sakkinen To: Stefan Berger Cc: Xiu Jianfeng , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, peterhuewe@gmx.de, jgg@ziepe.ca, nayna@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe() Message-ID: References: <20220318060201.50488-1-xiujianfeng@huawei.com> <977ccc4b-3b30-f301-aa1c-ef2aaa32cacd@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <977ccc4b-3b30-f301-aa1c-ef2aaa32cacd@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Fri, Mar 18, 2022 at 09:54:46AM -0400, Stefan Berger wrote: > > > On 3/18/22 02:02, Xiu Jianfeng wrote: > > Currently it returns zero when CRQ response timed out, it should return > > an error code instead. > > > > Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding") > > Signed-off-by: Xiu Jianfeng > > Reviewed-by: Stefan Berger Thank you, I applied this. BR, Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C01F6C433F5 for ; Sun, 20 Mar 2022 21:22:37 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KM9gw3YZkz300L for ; Mon, 21 Mar 2022 08:22:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=RH/gyeID; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=RH/gyeID; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KM9gF6cCgz2xt0 for ; Mon, 21 Mar 2022 08:22:01 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC64B6123C; Sun, 20 Mar 2022 21:21:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9552CC340E9; Sun, 20 Mar 2022 21:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647811319; bh=VCO2HOCuTBN+Xv7u6MBQ5uA0+TGwA+QA643VoWQB4s0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RH/gyeIDR4Y6vBxwoPf+bvJnNWspNNBT6gVUuJ9ByOxDzlcnQ1M4u09mnX13tV9c6 q2FQMNR7zBKXmEBj4OcDYHkQD9+QXNGC4phBUINAh4Kq2rtvmRzsDQcAehbLm2zTFZ S66yZl1SlynQdT7eBHOzO79uVIDut3UFF8vGeXrmAKHLyMZIhWNHKAnCNTR/e7eFeV +FuwOc7ufk2jvR348NiSyo2dQrWbV3wGyizX1vilR/Hd6b8ie8XpkyYI/G23x9B6r6 CcKnrUa1WLRAkGNRJ7MWVgFuTQxUwA6HrZYXC3XPfGlN8aWOtjje1HxTnhfYttgLgR IGANPRJRxzQow== Date: Sun, 20 Mar 2022 23:23:00 +0200 From: Jarkko Sakkinen To: Stefan Berger Subject: Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe() Message-ID: References: <20220318060201.50488-1-xiujianfeng@huawei.com> <977ccc4b-3b30-f301-aa1c-ef2aaa32cacd@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <977ccc4b-3b30-f301-aa1c-ef2aaa32cacd@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiu Jianfeng , nayna@linux.ibm.com, linux-kernel@vger.kernel.org, jgg@ziepe.ca, paulus@samba.org, peterhuewe@gmx.de, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 18, 2022 at 09:54:46AM -0400, Stefan Berger wrote: > > > On 3/18/22 02:02, Xiu Jianfeng wrote: > > Currently it returns zero when CRQ response timed out, it should return > > an error code instead. > > > > Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding") > > Signed-off-by: Xiu Jianfeng > > Reviewed-by: Stefan Berger Thank you, I applied this. BR, Jarkko