From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B983BC433EF for ; Mon, 21 Mar 2022 15:14:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0604D173D; Mon, 21 Mar 2022 16:13:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0604D173D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647875641; bh=ipkgJQjf5K2R+S1QsRulpTCFGjeQCivNGHqHR4lHm5g=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Eg2tT8MS8n9jmMfP3+hVnLqXLPE7ch7BiHGLUXDcXIady39BhQZ5W8VjhhEasLE0Y GmYrNsZLYbgUaqmwlUcULVS3j7T1PAB+5myluTomiOTD+DLVaoi9emRzgRXmdreN+1 oHqGjTPpZQpJ32Y85yC+LAUmjr9xqEr6KzusfTAk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C2B8EF804BB; Mon, 21 Mar 2022 16:13:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6B0A4F80515; Mon, 21 Mar 2022 16:13:01 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11E1BF804AE for ; Mon, 21 Mar 2022 16:12:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11E1BF804AE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NlAnS+O1" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 543AFB8170A; Mon, 21 Mar 2022 15:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8905C340E8; Mon, 21 Mar 2022 15:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647875577; bh=ipkgJQjf5K2R+S1QsRulpTCFGjeQCivNGHqHR4lHm5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NlAnS+O1h0ZwjtCK+NlIhwFXGU5XDIfc6JGdZ3urIL2RJgtikmxARsu5T/xn2sG44 +sMa8uQKAJl5lDfb0Gtk130vRqiUiPP4k7Ew+S0s4pW6avdeWP4xku+nyMuhTN2Rmp iPSaHZ/oH4lRowbTla4PbRXLvuADQ/+xfZAP3HMpj7TQNLOIM2sr1tYVt+2Vt7cOKO fY2tr+LI2U4d3OjryhCDpf+ExYtyfDMrOm2C/W/LtZRXW0qUNsEhHhU0rpggDyVl5b yPNWxbwu/5SL1vBKAPkQ5TKZrNkyEeob1ohw/VLGf7GFhUoKlpm7JKIIKcT3ys79Cl yMdFEDZAz58Qw== Date: Mon, 21 Mar 2022 23:12:52 +0800 From: Tzung-Bi Shih To: Trevor Wu Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682 Message-ID: References: <20220321072312.14972-1-trevor.wu@mediatek.com> <20220321072312.14972-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-mediatek@lists.infradead.org, yc.hung@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote: > diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c [...] > #define RT1011_SPEAKER_AMP_PRESENT BIT(0) > #define RT1019_SPEAKER_AMP_PRESENT BIT(1) > +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2) > + > +#define MAX98390_CODEC_DAI "max98390-aif1" > +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */ > +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */ > > #define RT1011_CODEC_DAI "rt1011-aif" > #define RT1011_DEV0_NAME "rt1011.2-0038" The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after RT1019_DEV0_NAME to maintain the order. > +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd) [...] > + > + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes, > + ARRAY_SIZE(mt8195_max98390_routes)); > + > + if (ret) Remove the extra blank line. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF6FFC433EF for ; Mon, 21 Mar 2022 15:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YEJutGurVYq9V1AyldYdRkA26U9OmW3/MFJMC9WuzKI=; b=t36lobh9LTpZJI pR1wFPF+YcOX+BJXtgXLIpMeJvAVYL+Hp/JvOkotUVq8fW77VEpDI5YwXFFWdJKsCHTe2nrsTaRBl fP37JBlBlUjCRc3mMv2kyvoHtAu+yJawHFZUbj/lW1yXjipj+tz2mh25EADorrCFY+EyZooqe/wdy U8sOWkbtn/4/1mJHHA6qVsBwfkwIyF2nvdwtlcp/e0M2cJF0+rLCwgMhw8Pb27yWbbKyS4mTwwavA cKHF7hs+VbR7vO6l+EkmvwepHfGyb87/95hgGRJwnAgRMInSkyayF1Qg2dGyN5kAOJPY2FXmHWZ0G Gmem3al6wDVxIu03ixcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJib-0087jB-Q5; Mon, 21 Mar 2022 15:13:13 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJiN-0087cb-N3; Mon, 21 Mar 2022 15:13:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 543AFB8170A; Mon, 21 Mar 2022 15:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8905C340E8; Mon, 21 Mar 2022 15:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647875577; bh=ipkgJQjf5K2R+S1QsRulpTCFGjeQCivNGHqHR4lHm5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NlAnS+O1h0ZwjtCK+NlIhwFXGU5XDIfc6JGdZ3urIL2RJgtikmxARsu5T/xn2sG44 +sMa8uQKAJl5lDfb0Gtk130vRqiUiPP4k7Ew+S0s4pW6avdeWP4xku+nyMuhTN2Rmp iPSaHZ/oH4lRowbTla4PbRXLvuADQ/+xfZAP3HMpj7TQNLOIM2sr1tYVt+2Vt7cOKO fY2tr+LI2U4d3OjryhCDpf+ExYtyfDMrOm2C/W/LtZRXW0qUNsEhHhU0rpggDyVl5b yPNWxbwu/5SL1vBKAPkQ5TKZrNkyEeob1ohw/VLGf7GFhUoKlpm7JKIIKcT3ys79Cl yMdFEDZAz58Qw== Date: Mon, 21 Mar 2022 23:12:52 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, angelogioacchino.delregno@collabora.com, yc.hung@mediatek.com Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682 Message-ID: References: <20220321072312.14972-1-trevor.wu@mediatek.com> <20220321072312.14972-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_081259_927353_D813E4ED X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote: > diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c [...] > #define RT1011_SPEAKER_AMP_PRESENT BIT(0) > #define RT1019_SPEAKER_AMP_PRESENT BIT(1) > +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2) > + > +#define MAX98390_CODEC_DAI "max98390-aif1" > +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */ > +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */ > > #define RT1011_CODEC_DAI "rt1011-aif" > #define RT1011_DEV0_NAME "rt1011.2-0038" The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after RT1019_DEV0_NAME to maintain the order. > +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd) [...] > + > + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes, > + ARRAY_SIZE(mt8195_max98390_routes)); > + > + if (ret) Remove the extra blank line. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79EC7C433F5 for ; Mon, 21 Mar 2022 15:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s5zkBUwCrufrfRCWq+MnmQ7nJ4GkXvb34P3h6Zh40Z8=; b=pqK6qvhRlcoZ4x jfildC6zP3FZkxpTrqRPIztkYadGe+yc/2dK4d0gWURYWPaQPD9q0UvUPw5NDVlVBviBRHRZyRzrU bbFZiE+hVlCWY7RxVcuu5A0KPqK7hykqKdKlMMFEthUSdCvfzfUWsVTaU51cqNOwxLL/1mFzEN0Jg SGg+wu8t2NpY5EBuVwm+8DbRAT77dselvGWfgoEvYtPMCT7NjlRjkwb2uYaMij5K6hw8Dm7TbJwAR drjeaZNimWIC9ZIp1F6ZbAfnw1jXinjYV2yn58z/1SupuHxJqElDfOXl47kVYJ7rR7noMCgnXaaBH CmQh11OrFJtUcS9h19jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJiR-0087e9-EN; Mon, 21 Mar 2022 15:13:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWJiN-0087cb-N3; Mon, 21 Mar 2022 15:13:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 543AFB8170A; Mon, 21 Mar 2022 15:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8905C340E8; Mon, 21 Mar 2022 15:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647875577; bh=ipkgJQjf5K2R+S1QsRulpTCFGjeQCivNGHqHR4lHm5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NlAnS+O1h0ZwjtCK+NlIhwFXGU5XDIfc6JGdZ3urIL2RJgtikmxARsu5T/xn2sG44 +sMa8uQKAJl5lDfb0Gtk130vRqiUiPP4k7Ew+S0s4pW6avdeWP4xku+nyMuhTN2Rmp iPSaHZ/oH4lRowbTla4PbRXLvuADQ/+xfZAP3HMpj7TQNLOIM2sr1tYVt+2Vt7cOKO fY2tr+LI2U4d3OjryhCDpf+ExYtyfDMrOm2C/W/LtZRXW0qUNsEhHhU0rpggDyVl5b yPNWxbwu/5SL1vBKAPkQ5TKZrNkyEeob1ohw/VLGf7GFhUoKlpm7JKIIKcT3ys79Cl yMdFEDZAz58Qw== Date: Mon, 21 Mar 2022 23:12:52 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, angelogioacchino.delregno@collabora.com, yc.hung@mediatek.com Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682 Message-ID: References: <20220321072312.14972-1-trevor.wu@mediatek.com> <20220321072312.14972-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_081259_927353_D813E4ED X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote: > diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c [...] > #define RT1011_SPEAKER_AMP_PRESENT BIT(0) > #define RT1019_SPEAKER_AMP_PRESENT BIT(1) > +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2) > + > +#define MAX98390_CODEC_DAI "max98390-aif1" > +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */ > +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */ > > #define RT1011_CODEC_DAI "rt1011-aif" > #define RT1011_DEV0_NAME "rt1011.2-0038" The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after RT1019_DEV0_NAME to maintain the order. > +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd) [...] > + > + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes, > + ARRAY_SIZE(mt8195_max98390_routes)); > + > + if (ret) Remove the extra blank line. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3BFC433F5 for ; Mon, 21 Mar 2022 15:13:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243001AbiCUPOY (ORCPT ); Mon, 21 Mar 2022 11:14:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349852AbiCUPOX (ORCPT ); Mon, 21 Mar 2022 11:14:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04ED665BA; Mon, 21 Mar 2022 08:12:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9798760F3C; Mon, 21 Mar 2022 15:12:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8905C340E8; Mon, 21 Mar 2022 15:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647875577; bh=ipkgJQjf5K2R+S1QsRulpTCFGjeQCivNGHqHR4lHm5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NlAnS+O1h0ZwjtCK+NlIhwFXGU5XDIfc6JGdZ3urIL2RJgtikmxARsu5T/xn2sG44 +sMa8uQKAJl5lDfb0Gtk130vRqiUiPP4k7Ew+S0s4pW6avdeWP4xku+nyMuhTN2Rmp iPSaHZ/oH4lRowbTla4PbRXLvuADQ/+xfZAP3HMpj7TQNLOIM2sr1tYVt+2Vt7cOKO fY2tr+LI2U4d3OjryhCDpf+ExYtyfDMrOm2C/W/LtZRXW0qUNsEhHhU0rpggDyVl5b yPNWxbwu/5SL1vBKAPkQ5TKZrNkyEeob1ohw/VLGf7GFhUoKlpm7JKIIKcT3ys79Cl yMdFEDZAz58Qw== Date: Mon, 21 Mar 2022 23:12:52 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, angelogioacchino.delregno@collabora.com, yc.hung@mediatek.com Subject: Re: [PATCH v3 5/6] ASoC: mediatek: mt8195: add machine support for max98390 and rt5682 Message-ID: References: <20220321072312.14972-1-trevor.wu@mediatek.com> <20220321072312.14972-6-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321072312.14972-6-trevor.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Mar 21, 2022 at 03:23:11PM +0800, Trevor Wu wrote: > diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359.c b/sound/soc/mediatek/mt8195/mt8195-mt6359.c [...] > #define RT1011_SPEAKER_AMP_PRESENT BIT(0) > #define RT1019_SPEAKER_AMP_PRESENT BIT(1) > +#define MAX98390_SPEAKER_AMP_PRESENT BIT(2) > + > +#define MAX98390_CODEC_DAI "max98390-aif1" > +#define MAX98390_DEV0_NAME "max98390.2-0038" /* right */ > +#define MAX98390_DEV1_NAME "max98390.2-0039" /* left */ > > #define RT1011_CODEC_DAI "rt1011-aif" > #define RT1011_DEV0_NAME "rt1011.2-0038" The quirk bit order: RT1011, RT1019, and MAX98390. To be neat, move MAX98390_CODEC_DAI, MAX98390_DEV0_NAME, and MAX98390_DEV1_NAME after RT1019_DEV0_NAME to maintain the order. > +static int mt8195_max98390_init(struct snd_soc_pcm_runtime *rtd) [...] > + > + ret = snd_soc_dapm_add_routes(&card->dapm, mt8195_max98390_routes, > + ARRAY_SIZE(mt8195_max98390_routes)); > + > + if (ret) Remove the extra blank line.