From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 10/10] iio: adc: ti-ads1015: Switch to read_avail
Date: Mon, 21 Mar 2022 18:19:01 +0200 [thread overview]
Message-ID: <YjildQUsDyehNHqs@smile.fi.intel.com> (raw)
In-Reply-To: <8c5772a7-6939-ac33-7b10-acded2b7b9ac@denx.de>
On Mon, Mar 21, 2022 at 03:44:24PM +0100, Marek Vasut wrote:
> On 3/21/22 10:27, Andy Shevchenko wrote:
> > On Sun, Mar 20, 2022 at 8:14 PM Marek Vasut <marex@denx.de> wrote:
...
> > > +static const int ads1015_fullscale_range[] = {
> > > 6144, 4096, 2048, 1024, 512, 256, 256, 256
> >
> > Keep a comma at the end.
> > Also applies to the rest of the modified data structures below.
>
> Why ? We don't expect these arrays to grow new values, if there is ever some
> new ADC, it will likely have its own array.
Just for the sake of a common style. But it's not critical,
so I leave it to the maintainers.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-21 16:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 18:14 [PATCH v3 01/10] dt-bindings: iio: adc: ti,ads1015: Add missing ADS1115 compatible string Marek Vasut
2022-03-20 18:14 ` [PATCH v3 02/10] dt-bindings: iio: adc: ti,ads1015: Add TLA2024 " Marek Vasut
2022-03-20 18:14 ` [PATCH v3 03/10] iio: adc: ti-ads1015: Switch to static const writeable ranges table Marek Vasut
2022-03-20 18:14 ` [PATCH v3 04/10] iio: adc: ti-ads1015: Deduplicate channel macros Marek Vasut
2022-03-20 18:14 ` [PATCH v3 05/10] iio: adc: ti-ads1015: Make channel event_spec optional Marek Vasut
2022-03-20 18:14 ` [PATCH v3 06/10] iio: adc: ti-ads1015: Add TLA2024 support Marek Vasut
2022-03-20 18:14 ` [PATCH v3 07/10] iio: adc: ti-ads1015: Add static assert to test if shifted realbits fit into storagebits Marek Vasut
2022-03-20 18:14 ` [PATCH v3 08/10] iio: adc: ti-ads1015: Convert to OF match data Marek Vasut
2022-03-21 9:24 ` Andy Shevchenko
2022-03-22 21:00 ` Jonathan Cameron
2022-03-22 21:41 ` Marek Vasut
2022-03-20 18:14 ` [PATCH v3 09/10] iio: adc: ti-ads1015: Replace data_rate with chip data struct ads1015_data Marek Vasut
2022-03-21 9:26 ` Andy Shevchenko
2022-03-21 14:41 ` Marek Vasut
2022-03-21 16:17 ` Andy Shevchenko
2022-03-22 20:48 ` Jonathan Cameron
2022-03-20 18:14 ` [PATCH v3 10/10] iio: adc: ti-ads1015: Switch to read_avail Marek Vasut
2022-03-21 9:27 ` Andy Shevchenko
2022-03-21 14:44 ` Marek Vasut
2022-03-21 16:19 ` Andy Shevchenko [this message]
2022-03-21 19:46 ` Marek Vasut
2022-03-22 20:50 ` Jonathan Cameron
2022-03-22 21:15 ` Jonathan Cameron
2022-03-22 21:39 ` Marek Vasut
2022-03-22 22:03 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjildQUsDyehNHqs@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=daniel.baluta@nxp.com \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.