From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94794C433F5 for ; Mon, 21 Mar 2022 18:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ukukIJuuwwuCL/w1SwCLkEQmvS8W4Eh+dADAnMQVeA0=; b=2iJTLHrVTIDY2G R3YV4be3SeqxLzkZlr+1ND2F+0JzG98jpczCtBaxxUiH9jBmHj4qh2ZgC+zKyLSodajwENwSCtCAB AiasvIoGlVqNofnddgZtS4yrD6u+coIlzts76UMMXx+moU5OJGRz2KEQ2SmW9nLdQ1Plr94KKy2oZ Pro/rpg+Cc21oH6kgSsYefxweN+x+snqWDdJmFdttIZJ+a/86NZvlPIJAT5qWAS/LSO8SOHUha63N xG8ZMhnJXFHsH7VqbhNi1yiZhEvxirfANsvILOwiJgb1RvEvZW/9qkxKQyZLQKk1dQjCSJGAxB1hi 2VFyi+Ng368FuDg9jkGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWNA4-008mAI-6K; Mon, 21 Mar 2022 18:53:48 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWN9r-008m7y-Hu; Mon, 21 Mar 2022 18:53:36 +0000 Received: by mail-oi1-f174.google.com with SMTP id q129so15214760oif.4; Mon, 21 Mar 2022 11:53:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a7Xyf2QArSyizp0F9X7a7N1r4113OGPHtnk41fQc9lc=; b=VHxVO0fVMQh48ajeouVgazPH0BE2717Z43+HH5kXaZKCHIyvp20idwIMP8Pzz9mDIh qtLn4uu4OyVvHA19PG04r+96vWbQhltkpdW4zAjH3xUAV8O+5O97mUcwgG6BwK9a6RMK k9pXdxEWc1wb5LfhB1ywSMJ3zCqLogQvD30AMDOKqZwhCAS/sNw13nF9xDGPiAbT/M1l yBKW0/Lqe5M/B50szKtn1PXO1X979EsHNWqDj7nv1ThQZ6BHDpFuEfexHN/MKZ6HCALf oYlYrxZsshCzHZwVWvcYiLtPRwk6l9sgYE/8yTKRLV63Sy4wXhZwWPnjWTZIo0SpR2Zh neAQ== X-Gm-Message-State: AOAM531mK9SqOXGGs9ZNMT0re+dzDfbIq9cUwo7hJ2c/4yxu7b8viDrZ bYhndHcS+7FEq11AYPwvzQ== X-Google-Smtp-Source: ABdhPJym1cVJ6hIiuqEDxMhZRQrspeqqkZR5PA/kFVaC8hdwQ5SdvwfkufWH3kcX6wu+LcnGMs9IxQ== X-Received: by 2002:a05:6808:f88:b0:2da:850d:18f0 with SMTP id o8-20020a0568080f8800b002da850d18f0mr270615oiw.19.1647888810502; Mon, 21 Mar 2022 11:53:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e8-20020a9d63c8000000b005b235a56831sm7783461otl.49.2022.03.21.11.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 11:53:29 -0700 (PDT) Received: (nullmailer pid 359469 invoked by uid 1000); Mon, 21 Mar 2022 18:53:27 -0000 Date: Mon, 21 Mar 2022 13:53:27 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Thomas Gleixner , Marc Zyngier , Krzysztof Kozlowski , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Michael Walle , Mark-PK Tsai , Daniel Palmer , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Palmer Dabbelt , Paul Walmsley , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Neil Armstrong , Dinh Nguyen , Cristian Ciocaltea , Joakim Zhang , Lucas Stach , Paul Cercueil , Jiaxun Yang , Claudiu Beznea , Jason Cooper , Paul Burton , Thomas Bogendoerfer , Birger Koblitz , Bert Vermeulen , John Crispin , Geert Uytterhoeven , Sagar Kadam , Suman Anna , Lokesh Vutla , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, openbmc@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-oxnas@groups.io Subject: Re: [PATCH 00/18] dt-bindings: irqchip: include generic schema Message-ID: References: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_115335_623433_D8D3DD5E X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Mar 17, 2022 at 12:55:24PM +0100, Krzysztof Kozlowski wrote: > Hi, > > The DTS patches can be picked up independently. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (18): > ARM: dts: nspire: use lower case hex addresses in node unit addresses > ARM: dts: ox820: align interrupt controller node name with dtschema > ARM: dts: socfpga: align interrupt controller node name with dtschema > dt-bindings: irqchip: actions,owl-sirq: include generic schema > dt-bindings: irqchip: fsl: include generic schema > dt-bindings: irqchip: ingenic: include generic schema > dt-bindings: irqchip: intel,ixp4xx: include generic schema > dt-bindings: irqchip: kontron,sl28cpld: include generic schema > dt-bindings: irqchip: loongson: include generic schema > dt-bindings: irqchip: microchip,eic: include generic schema > dt-bindings: irqchip: mrvl,intc: include generic schema > dt-bindings: irqchip: mstar,mst-intc: include generic schema > dt-bindings: irqchip: mti,gic: include generic schema > dt-bindings: irqchip: nuvoton,wpcm450-aic: include generic schema > dt-bindings: irqchip: realtek,rtl-intc: include generic schema > dt-bindings: irqchip: renesas: include generic schema > dt-bindings: irqchip: sifive: include generic schema > dt-bindings: irqchip: ti: include generic schema I'm somewhat on the fence about these. Originally only devices with a bus or child nodes included a common schema. For 'simple' providers with mainly a '#-cells' property, we had to set the constraints on the number of cells anyways, so referencing another schema doesn't save anything. It is nice to declare the 'class' of the device though. It makes the schema be applied twice (if the node name matches). That's not all bad because it finds cases of wrong node name. However, sometimes we have devices which are multiple providers and can't set the node name. So those can't reference interrupt-controller.yaml. It also means that 'interrupt-map' for example is now valid. That could be fixed by splitting 'interrupt-map' related properties to its own schema. Rob _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34E7BC433EF for ; Wed, 23 Mar 2022 01:12:34 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KNVhK40Yjz30J6 for ; Wed, 23 Mar 2022 12:12:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.174; helo=mail-oi1-f174.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KMkKW4Dvgz3036 for ; Tue, 22 Mar 2022 05:53:34 +1100 (AEDT) Received: by mail-oi1-f174.google.com with SMTP id n7so17212864oif.5 for ; Mon, 21 Mar 2022 11:53:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a7Xyf2QArSyizp0F9X7a7N1r4113OGPHtnk41fQc9lc=; b=F7+I0l9vrDsIZHksOKJ4RW7E7O8fk55jdaUW9HBIpJFmbFGO5TCzkU9zf/pN5YzT1P 1bKTetnZZwbTrcWQjJogtUUej3qf1ZeGRB1D15W9GcZwDtUTOVz33H9cOv2ytVrA+yET i2gV9NiRFDRZdTqf1E7ekXAqmvFEG8LF/pQwUYzsRwi5N0Xaj5xn1T7EWsBokRp6WNAu 2jhmSrdMQvvJ4mZuBpjGL/U8zg5ZdyB7IymTl+r9t/5QkvdXnLWIipvcmWvv5D8fcAiv vOtJMyf3KNM1C2f5Xyc5o5UkWHNYLhU3wDXoJBECUKGK3e5FoEnoijbCkcXxpL4y446y ZNRw== X-Gm-Message-State: AOAM532P4OJ0EI3+AcInSCZMU4RcwLenoajn542RzmQkbClVkh0rX2Z8 w03sgYeIaTDXzVqkTYQjHA== X-Google-Smtp-Source: ABdhPJym1cVJ6hIiuqEDxMhZRQrspeqqkZR5PA/kFVaC8hdwQ5SdvwfkufWH3kcX6wu+LcnGMs9IxQ== X-Received: by 2002:a05:6808:f88:b0:2da:850d:18f0 with SMTP id o8-20020a0568080f8800b002da850d18f0mr270615oiw.19.1647888810502; Mon, 21 Mar 2022 11:53:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e8-20020a9d63c8000000b005b235a56831sm7783461otl.49.2022.03.21.11.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 11:53:29 -0700 (PDT) Received: (nullmailer pid 359469 invoked by uid 1000); Mon, 21 Mar 2022 18:53:27 -0000 Date: Mon, 21 Mar 2022 13:53:27 -0500 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH 00/18] dt-bindings: irqchip: include generic schema Message-ID: References: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> X-Mailman-Approved-At: Wed, 23 Mar 2022 12:12:09 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Bert Vermeulen , Geert Uytterhoeven , Neil Armstrong , Lokesh Vutla , Paul Walmsley , Jiaxun Yang , Cristian Ciocaltea , Paul Cercueil , Daniel Palmer , Sagar Kadam , linux-riscv@lists.infradead.org, Suman Anna , Mark-PK Tsai , Paul Burton , Marc Zyngier , openbmc@lists.ozlabs.org, John Crispin , Birger Koblitz , linux-oxnas@groups.io, devicetree@vger.kernel.org, Jason Cooper , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Krzysztof Halasa , Santosh Shilimkar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Tero Kristo , Linus Walleij , Joakim Zhang , Claudiu Beznea , Dinh Nguyen , Michael Walle , Palmer Dabbelt , Krzysztof Kozlowski , Imre Kaloz , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Lucas Stach Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Mar 17, 2022 at 12:55:24PM +0100, Krzysztof Kozlowski wrote: > Hi, > > The DTS patches can be picked up independently. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (18): > ARM: dts: nspire: use lower case hex addresses in node unit addresses > ARM: dts: ox820: align interrupt controller node name with dtschema > ARM: dts: socfpga: align interrupt controller node name with dtschema > dt-bindings: irqchip: actions,owl-sirq: include generic schema > dt-bindings: irqchip: fsl: include generic schema > dt-bindings: irqchip: ingenic: include generic schema > dt-bindings: irqchip: intel,ixp4xx: include generic schema > dt-bindings: irqchip: kontron,sl28cpld: include generic schema > dt-bindings: irqchip: loongson: include generic schema > dt-bindings: irqchip: microchip,eic: include generic schema > dt-bindings: irqchip: mrvl,intc: include generic schema > dt-bindings: irqchip: mstar,mst-intc: include generic schema > dt-bindings: irqchip: mti,gic: include generic schema > dt-bindings: irqchip: nuvoton,wpcm450-aic: include generic schema > dt-bindings: irqchip: realtek,rtl-intc: include generic schema > dt-bindings: irqchip: renesas: include generic schema > dt-bindings: irqchip: sifive: include generic schema > dt-bindings: irqchip: ti: include generic schema I'm somewhat on the fence about these. Originally only devices with a bus or child nodes included a common schema. For 'simple' providers with mainly a '#-cells' property, we had to set the constraints on the number of cells anyways, so referencing another schema doesn't save anything. It is nice to declare the 'class' of the device though. It makes the schema be applied twice (if the node name matches). That's not all bad because it finds cases of wrong node name. However, sometimes we have devices which are multiple providers and can't set the node name. So those can't reference interrupt-controller.yaml. It also means that 'interrupt-map' for example is now valid. That could be fixed by splitting 'interrupt-map' related properties to its own schema. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 958A7C433EF for ; Mon, 21 Mar 2022 18:55:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v1pYcbm+VYY3nQpxp0ftdxCJlcy6mv7UHczvnoxz3pg=; b=UibTduPNvyBLVb B/G69gkyZUlqcxuO1oBsYDlkfxGsW9A54PwB1vk0DT2/gmxmtNmKmUAbXwS4zacjpwdlaNhXGH8vq Q2kOdPMmdoW0aObxkFhXbdakxZomtC1Y2+ue2bkfaGg/ubQedwbq6YHUMeCLvDAKkDLmdLadgSb9I wL+IRsRU3w1xcBhv8tRZWeGuKGDVHD+X9ZV4kUihn4ikdTU99YY6ire7I4rCJRefRiwjVhac2sJ30 Ye50fUUiygIV8RmsDTgvzV2mrLSIFxnD3z9IXCKf1PvJBEX2RDTSd9yos0iZRg8B7jn8onTMZpQ81 jvavIZHgcqn78vqj+VvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWN9v-008m8x-Rc; Mon, 21 Mar 2022 18:53:39 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWN9r-008m7y-Hu; Mon, 21 Mar 2022 18:53:36 +0000 Received: by mail-oi1-f174.google.com with SMTP id q129so15214760oif.4; Mon, 21 Mar 2022 11:53:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a7Xyf2QArSyizp0F9X7a7N1r4113OGPHtnk41fQc9lc=; b=VHxVO0fVMQh48ajeouVgazPH0BE2717Z43+HH5kXaZKCHIyvp20idwIMP8Pzz9mDIh qtLn4uu4OyVvHA19PG04r+96vWbQhltkpdW4zAjH3xUAV8O+5O97mUcwgG6BwK9a6RMK k9pXdxEWc1wb5LfhB1ywSMJ3zCqLogQvD30AMDOKqZwhCAS/sNw13nF9xDGPiAbT/M1l yBKW0/Lqe5M/B50szKtn1PXO1X979EsHNWqDj7nv1ThQZ6BHDpFuEfexHN/MKZ6HCALf oYlYrxZsshCzHZwVWvcYiLtPRwk6l9sgYE/8yTKRLV63Sy4wXhZwWPnjWTZIo0SpR2Zh neAQ== X-Gm-Message-State: AOAM531mK9SqOXGGs9ZNMT0re+dzDfbIq9cUwo7hJ2c/4yxu7b8viDrZ bYhndHcS+7FEq11AYPwvzQ== X-Google-Smtp-Source: ABdhPJym1cVJ6hIiuqEDxMhZRQrspeqqkZR5PA/kFVaC8hdwQ5SdvwfkufWH3kcX6wu+LcnGMs9IxQ== X-Received: by 2002:a05:6808:f88:b0:2da:850d:18f0 with SMTP id o8-20020a0568080f8800b002da850d18f0mr270615oiw.19.1647888810502; Mon, 21 Mar 2022 11:53:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e8-20020a9d63c8000000b005b235a56831sm7783461otl.49.2022.03.21.11.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 11:53:29 -0700 (PDT) Received: (nullmailer pid 359469 invoked by uid 1000); Mon, 21 Mar 2022 18:53:27 -0000 Date: Mon, 21 Mar 2022 13:53:27 -0500 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH 00/18] dt-bindings: irqchip: include generic schema Message-ID: References: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220321_115335_623433_D8D3DD5E X-CRM114-Status: GOOD ( 12.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Bert Vermeulen , Geert Uytterhoeven , Neil Armstrong , Lokesh Vutla , Paul Walmsley , Jiaxun Yang , Cristian Ciocaltea , Paul Cercueil , Daniel Palmer , Sagar Kadam , linux-riscv@lists.infradead.org, Mark-PK Tsai , Paul Burton , Marc Zyngier , openbmc@lists.ozlabs.org, John Crispin , Birger Koblitz , linux-oxnas@groups.io, devicetree@vger.kernel.org, Jason Cooper , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Krzysztof Halasa , Santosh Shilimkar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Tero Kristo , Linus Walleij , Joakim Zhang , Claudiu Beznea , Dinh Nguyen , Michael Walle , Palmer Dabbelt , Krzysztof Kozlowski , Imre Kaloz , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 17, 2022 at 12:55:24PM +0100, Krzysztof Kozlowski wrote: > Hi, > > The DTS patches can be picked up independently. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (18): > ARM: dts: nspire: use lower case hex addresses in node unit addresses > ARM: dts: ox820: align interrupt controller node name with dtschema > ARM: dts: socfpga: align interrupt controller node name with dtschema > dt-bindings: irqchip: actions,owl-sirq: include generic schema > dt-bindings: irqchip: fsl: include generic schema > dt-bindings: irqchip: ingenic: include generic schema > dt-bindings: irqchip: intel,ixp4xx: include generic schema > dt-bindings: irqchip: kontron,sl28cpld: include generic schema > dt-bindings: irqchip: loongson: include generic schema > dt-bindings: irqchip: microchip,eic: include generic schema > dt-bindings: irqchip: mrvl,intc: include generic schema > dt-bindings: irqchip: mstar,mst-intc: include generic schema > dt-bindings: irqchip: mti,gic: include generic schema > dt-bindings: irqchip: nuvoton,wpcm450-aic: include generic schema > dt-bindings: irqchip: realtek,rtl-intc: include generic schema > dt-bindings: irqchip: renesas: include generic schema > dt-bindings: irqchip: sifive: include generic schema > dt-bindings: irqchip: ti: include generic schema I'm somewhat on the fence about these. Originally only devices with a bus or child nodes included a common schema. For 'simple' providers with mainly a '#-cells' property, we had to set the constraints on the number of cells anyways, so referencing another schema doesn't save anything. It is nice to declare the 'class' of the device though. It makes the schema be applied twice (if the node name matches). That's not all bad because it finds cases of wrong node name. However, sometimes we have devices which are multiple providers and can't set the node name. So those can't reference interrupt-controller.yaml. It also means that 'interrupt-map' for example is now valid. That could be fixed by splitting 'interrupt-map' related properties to its own schema. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED401C433F5 for ; Mon, 21 Mar 2022 18:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352325AbiCUSy7 (ORCPT ); Mon, 21 Mar 2022 14:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239977AbiCUSy7 (ORCPT ); Mon, 21 Mar 2022 14:54:59 -0400 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7E401E3CF; Mon, 21 Mar 2022 11:53:32 -0700 (PDT) Received: by mail-oi1-f170.google.com with SMTP id w127so17187695oig.10; Mon, 21 Mar 2022 11:53:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a7Xyf2QArSyizp0F9X7a7N1r4113OGPHtnk41fQc9lc=; b=aV2yM1r0WWvSwXYRBg7uM6+gGIxDQVX11JTcT1uxi9UfjB48Z7GE83boFwsXca1wk8 rQJVucvUgZP9gEQo7lSBwkD93xrceFN4lLasU0bY8mn6A3sCiwnXUva8lrhiEeJQnQqj FMV5qxI7t0rwcmInMvFcavIz2+NjXy05f2fXp7pxI/DmxB/0edXZDgIpFYXEI5hqNcqG eB8LEtS9SbEiaLOHGEkr7wTgf8yre6luXN3TGKOHHWgBHZrBhWBdSppPvPvegu1dBOCs zlDrx450R7YehlhFGlJqfcU8PfxCnjOy0PH4MEkipfS0q3HdCh2URu5JO3j1KKg/imKi V0Ew== X-Gm-Message-State: AOAM531JQuLjXDk3QH9enP9s1KMfX3DI1g4NM1GhGJCbqBKLTzk4cAkL toWoYWhGK2Y0lKaGfjO13A== X-Google-Smtp-Source: ABdhPJym1cVJ6hIiuqEDxMhZRQrspeqqkZR5PA/kFVaC8hdwQ5SdvwfkufWH3kcX6wu+LcnGMs9IxQ== X-Received: by 2002:a05:6808:f88:b0:2da:850d:18f0 with SMTP id o8-20020a0568080f8800b002da850d18f0mr270615oiw.19.1647888810502; Mon, 21 Mar 2022 11:53:30 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id e8-20020a9d63c8000000b005b235a56831sm7783461otl.49.2022.03.21.11.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 11:53:29 -0700 (PDT) Received: (nullmailer pid 359469 invoked by uid 1000); Mon, 21 Mar 2022 18:53:27 -0000 Date: Mon, 21 Mar 2022 13:53:27 -0500 From: Rob Herring To: Krzysztof Kozlowski Cc: Thomas Gleixner , Marc Zyngier , Krzysztof Kozlowski , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Michael Walle , Mark-PK Tsai , Daniel Palmer , =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= , Palmer Dabbelt , Paul Walmsley , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Neil Armstrong , Dinh Nguyen , Cristian Ciocaltea , Joakim Zhang , Lucas Stach , Paul Cercueil , Jiaxun Yang , Claudiu Beznea , Jason Cooper , Paul Burton , Thomas Bogendoerfer , Birger Koblitz , Bert Vermeulen , John Crispin , Geert Uytterhoeven , Sagar Kadam , Suman Anna , Lokesh Vutla , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, openbmc@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-oxnas@groups.io Subject: Re: [PATCH 00/18] dt-bindings: irqchip: include generic schema Message-ID: References: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 17, 2022 at 12:55:24PM +0100, Krzysztof Kozlowski wrote: > Hi, > > The DTS patches can be picked up independently. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (18): > ARM: dts: nspire: use lower case hex addresses in node unit addresses > ARM: dts: ox820: align interrupt controller node name with dtschema > ARM: dts: socfpga: align interrupt controller node name with dtschema > dt-bindings: irqchip: actions,owl-sirq: include generic schema > dt-bindings: irqchip: fsl: include generic schema > dt-bindings: irqchip: ingenic: include generic schema > dt-bindings: irqchip: intel,ixp4xx: include generic schema > dt-bindings: irqchip: kontron,sl28cpld: include generic schema > dt-bindings: irqchip: loongson: include generic schema > dt-bindings: irqchip: microchip,eic: include generic schema > dt-bindings: irqchip: mrvl,intc: include generic schema > dt-bindings: irqchip: mstar,mst-intc: include generic schema > dt-bindings: irqchip: mti,gic: include generic schema > dt-bindings: irqchip: nuvoton,wpcm450-aic: include generic schema > dt-bindings: irqchip: realtek,rtl-intc: include generic schema > dt-bindings: irqchip: renesas: include generic schema > dt-bindings: irqchip: sifive: include generic schema > dt-bindings: irqchip: ti: include generic schema I'm somewhat on the fence about these. Originally only devices with a bus or child nodes included a common schema. For 'simple' providers with mainly a '#-cells' property, we had to set the constraints on the number of cells anyways, so referencing another schema doesn't save anything. It is nice to declare the 'class' of the device though. It makes the schema be applied twice (if the node name matches). That's not all bad because it finds cases of wrong node name. However, sometimes we have devices which are multiple providers and can't set the node name. So those can't reference interrupt-controller.yaml. It also means that 'interrupt-map' for example is now valid. That could be fixed by splitting 'interrupt-map' related properties to its own schema. Rob