From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D076C433EF for ; Tue, 22 Mar 2022 09:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231705AbiCVJFi (ORCPT ); Tue, 22 Mar 2022 05:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232253AbiCVJFh (ORCPT ); Tue, 22 Mar 2022 05:05:37 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBAA041FB6 for ; Tue, 22 Mar 2022 02:04:10 -0700 (PDT) Date: Tue, 22 Mar 2022 10:04:07 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1647939848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO6vUklIrcTLsgRyqLgfukUerZ1d7RWzBvSLxQ/M7Y4=; b=32EASTAS22tQY1CsFG7nTQzhrC3LAqM6etN8tEos708PRm8+Qv+8R9lv6JZ0UO4qInFVUY 2KQFSB8nNe6/mKyf/1SISA3nXiYlcPBqlw1yyVNZBZkKX8hsMkxZibSfxTx8CMV0a4PsEZ LZAEn6QyvKqXEyv84EREEWcrgIOmtfgzVrneKGi3xWlakB7GkJ7kWA9zu6bWQdjdgs5iu6 l6uFIQdIk+Y/Vg3Oo+NZfBi4Og/PYPrYredepXb583E+KsUvTYAWlQcciTCBWfJAz721Nk m3IfeJGxoSg38QUhfAjiSXnWohhtIb0rpqg0cZKDNYGczVXmwJxgLtMXoWtKcQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1647939848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO6vUklIrcTLsgRyqLgfukUerZ1d7RWzBvSLxQ/M7Y4=; b=YJOUT3KIJM3FSMTtmwptu6UTG9uwWGGIW0TFgcI5s875/boUoNr6zpHeYM1F6J5wtCGdZA VrNcJ6RVgvuePHDg== From: Sebastian Andrzej Siewior To: Ard Biesheuvel Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , Tony Lindgren , Marc Zyngier , Vladimir Murzin , Jesse Taube , Thomas Gleixner Subject: Re: [PATCH v5 24/32] ARM: run softirqs on the per-CPU IRQ stack Message-ID: References: <20220124174744.1054712-1-ardb@kernel.org> <20220124174744.1054712-25-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220124174744.1054712-25-ardb@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On 2022-01-24 18:47:36 [+0100], Ard Biesheuvel wrote: > @@ -58,6 +61,17 @@ static void __init init_irq_stacks(void) > } > } > > +static void ____do_softirq(void *arg) > +{ > + __do_softirq(); > +} > + > +void do_softirq_own_stack(void) > +{ > + call_with_stack(____do_softirq, NULL, > + __this_cpu_read(irq_stack_ptr)); > +} > + Do I miss the obvious here or is the irq_stack_ptr only used for softirqs and not for hardirqs? > int arch_show_interrupts(struct seq_file *p, int prec) > { > #ifdef CONFIG_FIQ Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2869C433F5 for ; Tue, 22 Mar 2022 09:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8WgWoy4gHm4R48a5J8gFLxjN/mGRMXzbgIcW/2xOI7s=; b=SL6iJBUpazT5ST 1uQpHfx+rr1mFccGTfTudgBUnXWIOwZBPARb3gJzRo5C3b1qY3Kanpeqp7o1ZtBeJWgEmZttr/xyO rpUyDGsIezn8UCBYEnhPHZB7cKBXuNkyv3wusfyv9b3Y3MU94FKs29uBqYFwtTz9R9P4daxLiw4T3 fauMuyLwMT2D6JwfvyNGPEac6CpP08H/CrbiyJgb+Y7CEAzISLUTn9w7vJv/7HJhuS5oCcQvFzzQ0 80unkIzC8h/r1mV22xwU2/KFFtXbPa+EFyj2i6nEJV2sGM+wI2lj4FIbibdKriB18D5pOqtRBWlfF 4ua0L/HWc5OdHxcXaLlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWaR8-00AWSk-S2; Tue, 22 Mar 2022 09:04:19 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWaR0-00AWRm-TJ for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 09:04:12 +0000 Date: Tue, 22 Mar 2022 10:04:07 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1647939848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO6vUklIrcTLsgRyqLgfukUerZ1d7RWzBvSLxQ/M7Y4=; b=32EASTAS22tQY1CsFG7nTQzhrC3LAqM6etN8tEos708PRm8+Qv+8R9lv6JZ0UO4qInFVUY 2KQFSB8nNe6/mKyf/1SISA3nXiYlcPBqlw1yyVNZBZkKX8hsMkxZibSfxTx8CMV0a4PsEZ LZAEn6QyvKqXEyv84EREEWcrgIOmtfgzVrneKGi3xWlakB7GkJ7kWA9zu6bWQdjdgs5iu6 l6uFIQdIk+Y/Vg3Oo+NZfBi4Og/PYPrYredepXb583E+KsUvTYAWlQcciTCBWfJAz721Nk m3IfeJGxoSg38QUhfAjiSXnWohhtIb0rpqg0cZKDNYGczVXmwJxgLtMXoWtKcQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1647939848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO6vUklIrcTLsgRyqLgfukUerZ1d7RWzBvSLxQ/M7Y4=; b=YJOUT3KIJM3FSMTtmwptu6UTG9uwWGGIW0TFgcI5s875/boUoNr6zpHeYM1F6J5wtCGdZA VrNcJ6RVgvuePHDg== From: Sebastian Andrzej Siewior To: Ard Biesheuvel Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , Tony Lindgren , Marc Zyngier , Vladimir Murzin , Jesse Taube , Thomas Gleixner Subject: Re: [PATCH v5 24/32] ARM: run softirqs on the per-CPU IRQ stack Message-ID: References: <20220124174744.1054712-1-ardb@kernel.org> <20220124174744.1054712-25-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124174744.1054712-25-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_020411_140168_A4CD9C8B X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-01-24 18:47:36 [+0100], Ard Biesheuvel wrote: > @@ -58,6 +61,17 @@ static void __init init_irq_stacks(void) > } > } > > +static void ____do_softirq(void *arg) > +{ > + __do_softirq(); > +} > + > +void do_softirq_own_stack(void) > +{ > + call_with_stack(____do_softirq, NULL, > + __this_cpu_read(irq_stack_ptr)); > +} > + Do I miss the obvious here or is the irq_stack_ptr only used for softirqs and not for hardirqs? > int arch_show_interrupts(struct seq_file *p, int prec) > { > #ifdef CONFIG_FIQ Sebastian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel