From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Kshitij Suri <kshitij.suri@nutanix.com>
Cc: soham.ghosh@nutanix.com, thuth@redhat.com,
prerna.saxena@nutanix.com, armbru@redhat.com,
qemu-devel@nongnu.org, philippe.mathieu.daude@gmail.com,
kraxel@redhat.com, prachatos.mitra@nutanix.com,
eblake@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG
Date: Tue, 22 Mar 2022 09:42:17 +0000 [thread overview]
Message-ID: <YjmZ+TdhAOAg+H73@redhat.com> (raw)
In-Reply-To: <20220322081845.19680-1-kshitij.suri@nutanix.com>
On Tue, Mar 22, 2022 at 08:18:44AM +0000, Kshitij Suri wrote:
> Libpng is only detected if VNC is enabled currently. This patch adds a
> generalised png option in the meson build which is aimed to replace use of
> CONFIG_VNC_PNG with CONFIG_PNG.
>
> Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>
> ---
> meson.build | 9 ++++-----
> meson_options.txt | 4 ++--
> ui/vnc-enc-tight.c | 18 +++++++++---------
> ui/vnc.c | 4 ++--
> ui/vnc.h | 2 +-
> 5 files changed, 18 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-03-22 9:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 8:18 [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG Kshitij Suri
2022-03-22 8:18 ` [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG Kshitij Suri
2022-03-22 9:47 ` Daniel P. Berrangé
2022-03-22 9:56 ` Kshitij Suri
2022-03-22 10:15 ` Markus Armbruster
2022-03-22 10:19 ` Kshitij Suri
2022-03-22 9:42 ` Daniel P. Berrangé [this message]
2022-03-22 9:52 ` [PATCH v2 1/2] Replacing CONFIG_VNC_PNG with CONFIG_PNG Kshitij Suri
-- strict thread matches above, loose matches on Subject: below --
2022-03-28 16:54 Kshitij Suri
2022-03-22 10:49 Kshitij Suri
2022-03-28 9:49 ` Kshitij Suri
2022-03-15 4:47 Kshitij Suri
2022-03-15 9:17 ` Paolo Bonzini
2022-03-01 6:44 Kshitij Suri
2022-03-07 16:40 ` Kshitij Suri
2022-02-28 5:22 Kshitij Suri
2022-02-28 12:52 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjmZ+TdhAOAg+H73@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=kshitij.suri@nutanix.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=prachatos.mitra@nutanix.com \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=soham.ghosh@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.