From: Tejun Heo <tj@kernel.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] block: avoid to call blkg_free() in atomic context
Date: Tue, 22 Mar 2022 06:42:31 -1000 [thread overview]
Message-ID: <Yjn8d6t2gIBcDMUJ@slm.duckdns.org> (raw)
In-Reply-To: <20220322161238.2006448-1-ming.lei@redhat.com>
On Wed, Mar 23, 2022 at 12:12:38AM +0800, Ming Lei wrote:
> blkg_free() may be called in atomic context, either spin lock is held,
> or run in rcu callback. Meantime either request queue's release handler
> or ->pd_free_fn can sleep.
>
> Fix the issue by scheduling work function for freeing blkcg_gq instance.
>
> Cc: Tejun Heo <tj@kernel.org>
> Fixes: 0a9a25ca7843 ("block: let blkcg_gq grab request queue's refcnt")
> Reported-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Do you have an example of this being a problem?
Thanks.
--
tejun
next prev parent reply other threads:[~2022-03-22 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 16:12 [PATCH] block: avoid to call blkg_free() in atomic context Ming Lei
2022-03-22 16:42 ` Tejun Heo [this message]
2022-03-23 0:13 ` kernel test robot
2022-03-23 1:05 ` Ming Lei
2022-03-23 1:05 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjn8d6t2gIBcDMUJ@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.