Re: [PATCH] fdtoverlay: Fix usage string to not mention "<type>"

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

On Tue, Mar 22, 2022 at 09:08:59AM +0100, Uwe Kleine-König wrote:
> fdtoverlay doesn't have a -t option, so explaining the type formats and
> modifier prefixes doesn't make much sense.
> ---
> Hello,
> 
> I was unsure if I'm supposed to add a signed-off-by line. It's not
> formalized in the git repo, so I assume it won't have any juristical
> semantic anyhow and I didn't add it.

It's true we've never formalized this, but I do generally prefer S-o-b
lines to be present.

The patch LGTM, so if you could resent with the signoff I'll apply.

> 
> Best regards
> Uwe
> 
>  fdtoverlay.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fdtoverlay.c b/fdtoverlay.c
> index 5350af65679f..cac6b6576c28 100644
> --- a/fdtoverlay.c
> +++ b/fdtoverlay.c
> @@ -23,9 +23,7 @@
>  /* Usage related data. */
>  static const char usage_synopsis[] =
>  	"apply a number of overlays to a base blob\n"
> -	"	fdtoverlay <options> [<overlay.dtbo> [<overlay.dtbo>]]\n"
> -	"\n"
> -	USAGE_TYPE_MSG;
> +	"	fdtoverlay <options> [<overlay.dtbo> [<overlay.dtbo>]]";
>  static const char usage_short_opts[] = "i:o:v" USAGE_COMMON_SHORT_OPTS;
>  static struct option const usage_long_opts[] = {
>  	{"input",            required_argument, NULL, 'i'},
> 
> base-commit: c001fc01a43e7a06447c06ea3d50bd60641322b8

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]