From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 23 Mar 2022 15:59:25 +0100 Subject: [PATCH v2] kexec-xen: Allow xen_kexec_exec() to return in case of Live Update In-Reply-To: <20220323144418.1658-1-raphning@gmail.com> References: <20220323144418.1658-1-raphning@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org On Wed, Mar 23, 2022 at 02:44:18PM +0000, Raphael Ning wrote: > From: Raphael Ning > > Currently, my_exec() does not expect the Xen KEXEC_CMD_kexec hypercall > to return on success, because it assumes that the hypercall always > triggers an immediate reboot. However, for Live Update, the hypercall > merely schedules the kexec operation and returns; the actual reboot > happens asynchronously. [1] > > Therefore, rework the Xen code path of my_exec() such that it does not > treat a successfully processed Live Update request as an error. Also, > rephrase the comment above the function to remove ambiguity. > > [1] https://lists.xen.org/archives/html/xen-devel/2021-05/msg00286.html > > Signed-off-by: Raphael Ning Thanks, applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C333C433EF for ; Wed, 23 Mar 2022 14:59:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.293928.499519 (Exim 4.92) (envelope-from ) id 1nX2SP-0001p2-1e; Wed, 23 Mar 2022 14:59:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 293928.499519; Wed, 23 Mar 2022 14:59:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nX2SO-0001ov-V3; Wed, 23 Mar 2022 14:59:28 +0000 Received: by outflank-mailman (input) for mailman id 293928; Wed, 23 Mar 2022 14:59:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nX2SN-0001op-EJ for xen-devel@lists.xenproject.org; Wed, 23 Mar 2022 14:59:27 +0000 Received: from zeeaster.vergenet.net (zeeaster.vergenet.net [206.189.110.174]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d507d751-aab9-11ec-8fbc-03012f2f19d4; Wed, 23 Mar 2022 15:59:26 +0100 (CET) Received: from madeliefje.horms.nl (2a02-a44a-2918-403-201-8eff-fe22-8fea.fixed6.kpn.net [IPv6:2a02:a44a:2918:403:201:8eff:fe22:8fea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by zeeaster.vergenet.net (Postfix) with ESMTPSA id CEF2B20138; Wed, 23 Mar 2022 14:59:25 +0000 (UTC) Received: by madeliefje.horms.nl (Postfix, from userid 7100) id 7914A2ECE; Wed, 23 Mar 2022 15:59:25 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d507d751-aab9-11ec-8fbc-03012f2f19d4 Date: Wed, 23 Mar 2022 15:59:25 +0100 From: Simon Horman To: Raphael Ning Cc: kexec@lists.infradead.org, Julien Grall , xen-devel@lists.xenproject.org, Raphael Ning Subject: Re: [PATCH v2] kexec-xen: Allow xen_kexec_exec() to return in case of Live Update Message-ID: References: <20220323144418.1658-1-raphning@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220323144418.1658-1-raphning@gmail.com> Organisation: Horms Solutions BV X-Virus-Scanned: clamav-milter 0.103.5 at zeeaster X-Virus-Status: Clean On Wed, Mar 23, 2022 at 02:44:18PM +0000, Raphael Ning wrote: > From: Raphael Ning > > Currently, my_exec() does not expect the Xen KEXEC_CMD_kexec hypercall > to return on success, because it assumes that the hypercall always > triggers an immediate reboot. However, for Live Update, the hypercall > merely schedules the kexec operation and returns; the actual reboot > happens asynchronously. [1] > > Therefore, rework the Xen code path of my_exec() such that it does not > treat a successfully processed Live Update request as an error. Also, > rephrase the comment above the function to remove ambiguity. > > [1] https://lists.xen.org/archives/html/xen-devel/2021-05/msg00286.html > > Signed-off-by: Raphael Ning Thanks, applied.