From: Mark Brown <broonie@kernel.org>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: "Navada Kanyana, Mukund" <navada@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
Raphael-Xu <13691752556@139.com>, "Xu, Yang" <raphael-xu@ti.com>
Subject: Re: [EXTERNAL] Re: [PATCH v4 3/3] update tas27xx.h to support either TAS2764 or TAS2780
Date: Wed, 23 Mar 2022 16:50:08 +0000 [thread overview]
Message-ID: <YjtPwKaH68HPsfDC@sirena.org.uk> (raw)
In-Reply-To: <eda347eb-f7dd-fe05-d670-5365899b74f5@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
On Wed, Mar 23, 2022 at 10:56:04AM +0100, Amadeusz Sławiński wrote:
> this would be probably overdoing it, 4 patches should be enough.
> Patch 1 and 3 seem ok to me, I would just split patch 2, and reorder a bit,
> so something like:
> 1. [PATCH v4 1/3] rename tas2764 to tas27xx-Makefile and Kconfig
> 2. here patch renaming variables (2764 -> xxxx)
> 3. [PATCH v4 3/3] update tas27xx.h to support either TAS2764 or TAS2780
> 4. here patch adding TAS2780 support
That looks like a good plan.
> The reason why patch 3, should go before one adding support is that there is
> dependency on information present in header, and you don't want to break
> build when someone does git bisect with your driver enabled.
Indeed I test for this when applying patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-03-23 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 4:26 [PATCH v4 1/3] rename tas2764 to tas27xx-Makefile and Kconfig Raphael-Xu
2022-03-23 4:26 ` [PATCH v4 2/3] update tas27xx.c to support either TAS2764 or TAS2780 Raphael-Xu
2022-03-23 8:28 ` Amadeusz Sławiński
2022-03-23 4:26 ` [PATCH v4 3/3] update tas27xx.h " Raphael-Xu
2022-03-23 8:29 ` Amadeusz Sławiński
2022-03-23 9:41 ` [EXTERNAL] " Xu, Yang
2022-03-23 9:56 ` Amadeusz Sławiński
2022-03-23 16:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjtPwKaH68HPsfDC@sirena.org.uk \
--to=broonie@kernel.org \
--cc=13691752556@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=navada@ti.com \
--cc=raphael-xu@ti.com \
--cc=shenghao-ding@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.