From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8396AC433F5 for ; Thu, 24 Mar 2022 07:46:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D72EF1721; Thu, 24 Mar 2022 08:45:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D72EF1721 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1648107981; bh=BnVHS6h5Gh84trbMb8OgFB+LCVYnDXlcMEKuxFAbQcU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MpbTj4HOL4dp786XcMRchC+BLplaVI2MAyZkOq2KPv8duOoW5gnXBTg6lvU3Iving YnHOv2hn1EH10+DRRV6gfRUqrYz5RgidWD1JLtFbl/sPapOC0F7SpFcaI8qe2mECZo CNRQX8OwSvgNt71q8ZKOIgfAWPqaNN1/AXYsWhSE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4D730F80115; Thu, 24 Mar 2022 08:45:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AD128F80165; Thu, 24 Mar 2022 08:45:29 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 64C0AF80115 for ; Thu, 24 Mar 2022 08:45:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 64C0AF80115 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bLutvu2Q" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82630B8217F; Thu, 24 Mar 2022 07:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAE70C340EC; Thu, 24 Mar 2022 07:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648107919; bh=BnVHS6h5Gh84trbMb8OgFB+LCVYnDXlcMEKuxFAbQcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLutvu2QgVXaYjMT9E6LteYKjL0MKAyLoZowrNBoFir1ic9GvP5pxB8Qn+2krNKsT e1nlqE+9Bxi+0O3yEKZlZAGGVG82yli47FYUoYtax9xqqFh2rz96FWGBaZ5yU51wLI IkIMjFwjwpyNOziCmgcUrchi+2Sls7dW24IYek69lHVfmNdarcIh051zIU47N+5Q1F mLUnF3S6L/VLwxyL7tckyP/ZL+0xGa6McgkCyET9q1abHUFUWANes+Pr4ehah0j46m PhjzhAHi/9qhbAyijiH7i+11LmXPxdatS8iuWtRQZ/aeU+zusa3p8PAIUymuuILivI 7IaVWPk3AYkhw== Date: Thu, 24 Mar 2022 15:45:14 +0800 From: Tzung-Bi Shih To: Trevor Wu Subject: Re: [PATCH v4 2/6] ASoC: mediatek: mt8195: merge machine driver Message-ID: References: <20220324053851.27350-1-trevor.wu@mediatek.com> <20220324053851.27350-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324053851.27350-3-trevor.wu@mediatek.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, miles.chen@mediatek.com, broonie@kernel.org, linux-mediatek@lists.infradead.org, yc.hung@mediatek.com, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Mar 24, 2022 at 01:38:47PM +0800, Trevor Wu wrote: > Because most functions can be reused in different codec combinations, > mt8195 machine drivers are combined to one common file. > > The model and compatible string are used to decide which codecs are > being used. > > As a result, We can prevent from copy-paste functions when new codec > combination is introduced. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C946C433F5 for ; Thu, 24 Mar 2022 07:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Tb2qAN2iHQnwI5opx2JlaJTjjl52AeJuUveOcZcQo4=; b=znZTOFWWSFZbLc HYwTNp9PxzAt6IQbmqzwJCuMYTuB+LvSqx5w4IT4gQu+7Vq8XMWYuvNroI8xNmoUo1X5ndSfuMfYF TQjmob4CVoq+sIoUBw959dcYmGNUxzxK48uB3NXha3IGVzzyOKa4wLY3HKUj33/QN2jYjkzjUoSfc lN9l90rQ3fEf9bRZmLNoDudS4UnskHPBqtutit2459BZWVsh5GWPw6aezhIwMfQWIOp4SA6z7z/Vb zoiZsaMJPbUKkkvdRdh7E7lYThkl8Ol4uPgIR0ls/xyF8Z4iFC2Nnt9vwmYaks32Z5P1RQWLwqkMp RPJba+umHASuMCojfoKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXIA2-00Fybo-4k; Thu, 24 Mar 2022 07:45:34 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXI9q-00FyZl-3C; Thu, 24 Mar 2022 07:45:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82630B8217F; Thu, 24 Mar 2022 07:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAE70C340EC; Thu, 24 Mar 2022 07:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648107919; bh=BnVHS6h5Gh84trbMb8OgFB+LCVYnDXlcMEKuxFAbQcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLutvu2QgVXaYjMT9E6LteYKjL0MKAyLoZowrNBoFir1ic9GvP5pxB8Qn+2krNKsT e1nlqE+9Bxi+0O3yEKZlZAGGVG82yli47FYUoYtax9xqqFh2rz96FWGBaZ5yU51wLI IkIMjFwjwpyNOziCmgcUrchi+2Sls7dW24IYek69lHVfmNdarcIh051zIU47N+5Q1F mLUnF3S6L/VLwxyL7tckyP/ZL+0xGa6McgkCyET9q1abHUFUWANes+Pr4ehah0j46m PhjzhAHi/9qhbAyijiH7i+11LmXPxdatS8iuWtRQZ/aeU+zusa3p8PAIUymuuILivI 7IaVWPk3AYkhw== Date: Thu, 24 Mar 2022 15:45:14 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, angelogioacchino.delregno@collabora.com, miles.chen@mediatek.com, yc.hung@mediatek.com Subject: Re: [PATCH v4 2/6] ASoC: mediatek: mt8195: merge machine driver Message-ID: References: <20220324053851.27350-1-trevor.wu@mediatek.com> <20220324053851.27350-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220324053851.27350-3-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220324_004522_312756_644190D5 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Mar 24, 2022 at 01:38:47PM +0800, Trevor Wu wrote: > Because most functions can be reused in different codec combinations, > mt8195 machine drivers are combined to one common file. > > The model and compatible string are used to decide which codecs are > being used. > > As a result, We can prevent from copy-paste functions when new codec > combination is introduced. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E25CC433EF for ; Thu, 24 Mar 2022 07:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GQ86vNXOE/YbmWPWJgXX94UtKpSM9JJq+CjhZuFD5eU=; b=T0ROYfnl2mSqm4 69o1oFhLkYAnA1BNV0EvQhEiWHmtRUma+Dor7kfEOSl9KiG6wgqo35q1rR0syz3OlNc6MSeufPH07 8JFaT6Dhq8UgCVDOChMn8UK0TU93BIwg1tz1QVboAQzUdB9WA7M1icdGO/sH+ZFXqjTGYLjA0YiI2 ts/v22ALC7JSvyvCZwrypCPHKqJ0ytvverpNnnwkvx+YqCQGiTeem5Woy1IbaSTdYUYdd5Wr3jRn3 hecSafQGOmQpfdg46Dg/ylj1M+lqfXtbmf6gQLCFgh8jhnEF4ZmcqQtGHp53pqkTOqnjFrp6/pSGO ovGjfpvOxbQix5XnQG8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXI9t-00FyaE-Lf; Thu, 24 Mar 2022 07:45:25 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXI9q-00FyZl-3C; Thu, 24 Mar 2022 07:45:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82630B8217F; Thu, 24 Mar 2022 07:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAE70C340EC; Thu, 24 Mar 2022 07:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648107919; bh=BnVHS6h5Gh84trbMb8OgFB+LCVYnDXlcMEKuxFAbQcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLutvu2QgVXaYjMT9E6LteYKjL0MKAyLoZowrNBoFir1ic9GvP5pxB8Qn+2krNKsT e1nlqE+9Bxi+0O3yEKZlZAGGVG82yli47FYUoYtax9xqqFh2rz96FWGBaZ5yU51wLI IkIMjFwjwpyNOziCmgcUrchi+2Sls7dW24IYek69lHVfmNdarcIh051zIU47N+5Q1F mLUnF3S6L/VLwxyL7tckyP/ZL+0xGa6McgkCyET9q1abHUFUWANes+Pr4ehah0j46m PhjzhAHi/9qhbAyijiH7i+11LmXPxdatS8iuWtRQZ/aeU+zusa3p8PAIUymuuILivI 7IaVWPk3AYkhw== Date: Thu, 24 Mar 2022 15:45:14 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, angelogioacchino.delregno@collabora.com, miles.chen@mediatek.com, yc.hung@mediatek.com Subject: Re: [PATCH v4 2/6] ASoC: mediatek: mt8195: merge machine driver Message-ID: References: <20220324053851.27350-1-trevor.wu@mediatek.com> <20220324053851.27350-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220324053851.27350-3-trevor.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220324_004522_312756_644190D5 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 24, 2022 at 01:38:47PM +0800, Trevor Wu wrote: > Because most functions can be reused in different codec combinations, > mt8195 machine drivers are combined to one common file. > > The model and compatible string are used to decide which codecs are > being used. > > As a result, We can prevent from copy-paste functions when new codec > combination is introduced. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC48DC433EF for ; Thu, 24 Mar 2022 07:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241100AbiCXHqy (ORCPT ); Thu, 24 Mar 2022 03:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239716AbiCXHqx (ORCPT ); Thu, 24 Mar 2022 03:46:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10AF4972BD; Thu, 24 Mar 2022 00:45:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8FECAB82228; Thu, 24 Mar 2022 07:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAE70C340EC; Thu, 24 Mar 2022 07:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648107919; bh=BnVHS6h5Gh84trbMb8OgFB+LCVYnDXlcMEKuxFAbQcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLutvu2QgVXaYjMT9E6LteYKjL0MKAyLoZowrNBoFir1ic9GvP5pxB8Qn+2krNKsT e1nlqE+9Bxi+0O3yEKZlZAGGVG82yli47FYUoYtax9xqqFh2rz96FWGBaZ5yU51wLI IkIMjFwjwpyNOziCmgcUrchi+2Sls7dW24IYek69lHVfmNdarcIh051zIU47N+5Q1F mLUnF3S6L/VLwxyL7tckyP/ZL+0xGa6McgkCyET9q1abHUFUWANes+Pr4ehah0j46m PhjzhAHi/9qhbAyijiH7i+11LmXPxdatS8iuWtRQZ/aeU+zusa3p8PAIUymuuILivI 7IaVWPk3AYkhw== Date: Thu, 24 Mar 2022 15:45:14 +0800 From: Tzung-Bi Shih To: Trevor Wu Cc: broonie@kernel.org, tiwai@suse.com, robh+dt@kernel.org, matthias.bgg@gmail.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aaronyu@google.com, angelogioacchino.delregno@collabora.com, miles.chen@mediatek.com, yc.hung@mediatek.com Subject: Re: [PATCH v4 2/6] ASoC: mediatek: mt8195: merge machine driver Message-ID: References: <20220324053851.27350-1-trevor.wu@mediatek.com> <20220324053851.27350-3-trevor.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220324053851.27350-3-trevor.wu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 24, 2022 at 01:38:47PM +0800, Trevor Wu wrote: > Because most functions can be reused in different codec combinations, > mt8195 machine drivers are combined to one common file. > > The model and compatible string are used to decide which codecs are > being used. > > As a result, We can prevent from copy-paste functions when new codec > combination is introduced. > > Signed-off-by: Trevor Wu Reviewed-by: Tzung-Bi Shih