From: Justin Forbes <jforbes@fedoraproject.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Limonciello, Mario" <Mario.Limonciello@amd.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [GIT PULL] ata changes for 5.18-rc1
Date: Thu, 24 Mar 2022 07:49:19 -0500 [thread overview]
Message-ID: <Yjxoz+fojG3csrVi@fedora64.linuxtx.org> (raw)
In-Reply-To: <55df3e41-6252-47e3-1e2f-bf96dce6c304@opensource.wdc.com>
On Thu, Mar 24, 2022 at 03:38:00PM +0900, Damien Le Moal wrote:
> On 3/24/22 15:28, Christoph Hellwig wrote:
> > On Thu, Mar 24, 2022 at 08:45:56AM +0900, Damien Le Moal wrote:
> >> Mario, let's check what other distros do first before deciding. Fedora for
> >> sure has a default of 3 and I have never seen any issue with it (and I
> >> have been using Fedora for a long time with many different drives).
> >>
> >> Not sure what distro you are using, but if it is not Fedora, please check.
> >> We should check at least Debian, Ubuntu, SUSE, RHEL and CentOS. I can
> >> check some other minor ones too as I know users.
> >
> > Debian:
> >
> > hch@brick:~/work/linux$ grep CONFIG_SATA_MOBILE_LPM_POLICY /boot/config-5.10.0-1*
> > /boot/config-5.10.0-10-amd64:CONFIG_SATA_MOBILE_LPM_POLICY=3
> > /boot/config-5.10.0-11-amd64:CONFIG_SATA_MOBILE_LPM_POLICY=3
> > /boot/config-5.10.0-12-amd64:CONFIG_SATA_MOBILE_LPM_POLICY=3
>
> Thanks. Debian testing also has the default at 3.
>
> Mario reported that Ubuntu and Arch also use 3, and that RHEL has 0 as
> default but changes it to 3 after boot.
>
> Gentoo default config is also 3. Checking CentOS and [open]SUSE now.
CentOS uses the RHEL configs and defaults to 0. I do agree that
renaming config options can be problematic, but the heads up from Damien
helped. It will not be an issue for Fedora, CentOS, and RHEL.
Justin
> So far, it is looking like 3 is a sane default.
>
> --
> Damien Le Moal
> Western Digital Research
next prev parent reply other threads:[~2022-03-24 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 6:56 [GIT PULL] ata changes for 5.18-rc1 Damien Le Moal
2022-03-23 22:10 ` Linus Torvalds
2022-03-23 23:04 ` Limonciello, Mario
2022-03-23 23:13 ` Linus Torvalds
2022-03-23 23:41 ` Damien Le Moal
2022-03-23 23:45 ` Damien Le Moal
2022-03-24 0:25 ` Limonciello, Mario
2022-03-24 0:38 ` Damien Le Moal
2022-03-24 6:28 ` Christoph Hellwig
2022-03-24 6:38 ` Damien Le Moal
2022-03-24 12:49 ` Justin Forbes [this message]
2022-03-23 23:40 ` Damien Le Moal
2022-03-23 23:36 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjxoz+fojG3csrVi@fedora64.linuxtx.org \
--to=jforbes@fedoraproject.org \
--cc=Mario.Limonciello@amd.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.