From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7928EC433F5 for ; Thu, 24 Mar 2022 14:37:31 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3CF493C9AA2 for ; Thu, 24 Mar 2022 15:37:29 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 753B13C96B4 for ; Thu, 24 Mar 2022 15:37:18 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id BB4E8200111 for ; Thu, 24 Mar 2022 15:37:17 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E2796210DB; Thu, 24 Mar 2022 14:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648132636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FAO7a5LZCH6hjRiBaikTgX6qT3FqxUWpV+JiT9Zx9yU=; b=dBlK6QC8j8ulmfPvYIdPV+UsWUgbTz8B7u0yLTBZf9c7KV5c7XfzE+5dO5jFlCRR4CkQIc QdQ3nKy+BOwjJJnH4V4UrU4NpDFUB0mi7lZvZPFffR26C5YYHcpojOTd7ZX1vJP8pODzLX R1ZoUVZvdleKSTBc/ZWbzS+Wtap+rns= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648132636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FAO7a5LZCH6hjRiBaikTgX6qT3FqxUWpV+JiT9Zx9yU=; b=Ixni9gaJNJ2sPM5INdqLyEfldYJ1g4Ov921TtjBhU2nM/82Wn2uAFCD8SExml3B1sGw1b0 930Y4lS5w9bLsYDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CE532132E9; Thu, 24 Mar 2022 14:37:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EwefMByCPGLlDQAAMHmgww (envelope-from ); Thu, 24 Mar 2022 14:37:16 +0000 Date: Thu, 24 Mar 2022 15:39:36 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20220315103254.7185-1-andrea.cervesato@suse.de> <20220315103254.7185-3-andrea.cervesato@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220315103254.7185-3-andrea.cervesato@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 02/10] Rewrite msg_comm.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > - if (msgsnd(id, &m, sizeof(struct sysv_msg) - sizeof(long), 0) == -1) { ^ I think that sizeof(m.mtext) would be cleaner As due to a padding the actuall size of a structure may be bigger than the sum of it's members... Other than that the rest of the code looks good. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp