From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1958575094874137652==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix minmax.cocci warnings Date: Wed, 06 Apr 2022 16:52:07 +0800 Message-ID: In-Reply-To: <202204061643.FyGA9V7U-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============1958575094874137652== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: ath9k-devel(a)qca.qualcomm.com CC: Kalle Valo CC: Jakub Kicinski CC: linux-wireless(a)vger.kernel.org CC: netdev(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/net/wireless/ath/ath9k/ar9003_phy.c:1829:19-21: WARNING opportunity= for min() Check for opencoded min(), max() implementations. Generated patches sometimes require adding a cast to fix compile warning. Warnings/patches scope intentionally limited to a function body. Generated by: scripts/coccinelle/misc/minmax.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 3e732ebf7316ac83e8562db7e64cc68aec390a18 commit: 5f66f73b9ff4dcabd4e2405ba9c32e80e02f9408 coccinelle: misc: add minm= ax script :::::: branch date: 15 hours ago :::::: commit date: 11 months ago Please take the patch only if it's a positive warning. Thanks! drivers/net/wireless/ath/ath9k/ar9003_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.c @@ -1826,7 +1826,7 @@ static void ar9003_hw_tx99_set_txpower(s static u8 p_pwr_array[ar9300RateSize] =3D { 0 }; unsigned int i; = - txpower =3D txpower <=3D MAX_RATE_POWER ? txpower : MAX_RATE_POWER; + txpower =3D min(txpower, MAX_RATE_POWER); for (i =3D 0; i < ar9300RateSize; i++) p_pwr_array[i] =3D txpower; =20 --===============1958575094874137652==--