From: Andrew Lunn <andrew@lunn.ch>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, lorenzo.bianconi@redhat.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
thomas.petazzoni@bootlin.com, linux@armlinux.org.uk,
jbrouer@redhat.com, ilias.apalodimas@linaro.org,
jdamato@fastly.com
Subject: Re: [PATCH net-next] net: mvneta: add support for page_pool_get_stats
Date: Wed, 6 Apr 2022 14:49:51 +0200 [thread overview]
Message-ID: <Yk2Mb9zUZZFaFLGm@lunn.ch> (raw)
In-Reply-To: <e4a3bb0fb407ead607b85f7f041f24b586c8b99d.1649190493.git.lorenzo@kernel.org>
On Tue, Apr 05, 2022 at 10:32:12PM +0200, Lorenzo Bianconi wrote:
> Introduce support for the page_pool_get_stats API to mvneta driver.
> If CONFIG_PAGE_POOL_STATS is enabled, ethtool will report page pool
> stats.
Hi Lorenzo
There are a lot of #ifdef in this patch. They are generally not
liked. What does the patch actually depend on? mnveta has a select
PAGE_POOL so the page pool itself should always be available?
Andrew
next prev parent reply other threads:[~2022-04-06 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 20:32 [PATCH net-next] net: mvneta: add support for page_pool_get_stats Lorenzo Bianconi
2022-04-06 12:49 ` Andrew Lunn [this message]
2022-04-06 12:53 ` Ilias Apalodimas
2022-04-06 13:05 ` Lorenzo Bianconi
2022-04-06 13:38 ` Andrew Lunn
2022-04-06 14:02 ` Lorenzo Bianconi
2022-04-06 23:01 ` Joe Damato
2022-04-06 23:36 ` Andrew Lunn
2022-04-07 16:48 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk2Mb9zUZZFaFLGm@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.