From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3D3C433F5 for ; Thu, 7 Apr 2022 05:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240867AbiDGFZe (ORCPT ); Thu, 7 Apr 2022 01:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233735AbiDGFZa (ORCPT ); Thu, 7 Apr 2022 01:25:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8E44127580 for ; Wed, 6 Apr 2022 22:23:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3EC5F61CB6 for ; Thu, 7 Apr 2022 05:23:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75407C385A4; Thu, 7 Apr 2022 05:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649309009; bh=+w1a8dt1fV5qlA7rILm+6yNokb4b4CK6colJr3pghe8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L6GfYE9rDrMHLwpV2u5w9TaktO1KU/tPOuXpZBj7C2rtjpUAvcl7wliDTLnXoC709 r/zIIXRMrJCh6H4thP/85Ui02awnVIFaNmsMUUWYXyBGeB7X8yZgn5N4PoB47vSVMb 2ka/a59xNfTsxc+wMC+s07QLG6MVtiybP3TwlYGE= Date: Thu, 7 Apr 2022 07:23:24 +0200 From: Greg Kroah-Hartman To: Jakub Kicinski Cc: Vladimir Oltean , "netdev@vger.kernel.org" , Paolo Abeni , "David S. Miller" , Andrew Lunn , Heiner Kallweit , Russell King , Florian Fainelli , Geert Uytterhoeven , Robin Murphy Subject: Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ provider is missing Message-ID: References: <20220406202323.3390405-1-vladimir.oltean@nxp.com> <20220406153443.51ad52f8@kernel.org> <20220406231956.nwe6kb6vgli2chln@skbuf> <20220406172550.6408c990@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406172550.6408c990@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 06, 2022 at 05:25:50PM -0700, Jakub Kicinski wrote: > On Wed, 6 Apr 2022 23:19:57 +0000 Vladimir Oltean wrote: > > On Wed, Apr 06, 2022 at 03:34:43PM -0700, Jakub Kicinski wrote: > > > > + if (rc == -EPROBE_DEFER) > > > > + rc = driver_deferred_probe_check_state(&phy->mdio.dev); > > > This one's not exported, allmodconfig build fails. > > > > Oops, I didn't realize that all its callers except for FWNODE_MDIO are built-in. > > > > Do you prefer me exporting the symbol as part of the same patch or a different one? > > I presume single patch is fine, but driver_deferred_probe_check_state() > lives in Greg's realm, so let's add Greg in case he prefers a separate > patch or more. separate patch that I can NAK as I do not understand why this is needed at all :) thanks, greg k-h