From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thorsten Glaser <t.glaser@tarent.de>
Cc: Vlad Buslov <vladbu@mellanox.com>,
stable@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Lee Jones <lee.jones@linaro.org>,
Daniel.Fleischer@orbit.de, Marcel.Krause@orbit.de,
christian.hampe@telekom.de, haye.haehne@telekom.de,
keith.lloyd@telekom.de
Subject: Re: v4.19.221 breaks qdisc modules
Date: Mon, 28 Mar 2022 07:50:25 +0200 [thread overview]
Message-ID: <YkFMoe4t1dRkHlEX@kroah.com> (raw)
In-Reply-To: <425d1b7-abb9-903c-4ae4-11f27ef06313@tarent.de>
On Sun, Mar 27, 2022 at 11:44:59PM +0200, Thorsten Glaser wrote:
> On Sun, 27 Mar 2022, Thorsten Glaser wrote:
>
> > But this makes it more tricky… or can I “just” change this
> > to KERNEL_VERSION(4, 19, 221) ?
>
> Well, of course not:
>
> $ cat /usr/src/linux-headers-4.19.0-19-amd64/include/generated/uapi/linux/version.h
> #define LINUX_VERSION_CODE 267263
> #define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
> $ print $(((267263 >> 16) & 0xFF)).$(((267263 >> 8) & 0xFF)).$((267263 & 0xFF))
> 4.19.255
>
> Whose bright idea was *that*?
>
> How can I make this module compatible with *both* 4.19 variants?
Ah, external code, sorry, you are on your own.
As for how to test for larger numbers, see the answer in the email
archives, others have done this successfully.
good luck!
greg k-h
next prev parent reply other threads:[~2022-03-28 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 21:39 v4.19.221 breaks qdisc modules Thorsten Glaser
2022-03-27 21:44 ` Thorsten Glaser
2022-03-28 5:50 ` Greg Kroah-Hartman [this message]
2022-03-28 20:23 ` Thorsten Glaser
2022-03-28 21:37 ` Thorsten Glaser
2022-03-28 5:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkFMoe4t1dRkHlEX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Daniel.Fleischer@orbit.de \
--cc=Marcel.Krause@orbit.de \
--cc=christian.hampe@telekom.de \
--cc=davem@davemloft.net \
--cc=haye.haehne@telekom.de \
--cc=jiri@mellanox.com \
--cc=keith.lloyd@telekom.de \
--cc=lee.jones@linaro.org \
--cc=stable@vger.kernel.org \
--cc=t.glaser@tarent.de \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.