All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, ying.huang@intel.com,
	mgorman@techsingularity.net
Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones
Date: Mon, 28 Mar 2022 10:14:10 +0200	[thread overview]
Message-ID: <YkFuUsWe2LAuQa3n@localhost.localdomain> (raw)
In-Reply-To: <20220327024101.10378-1-richard.weiyang@gmail.com>

On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote:
> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
> reclaim from zones with pages managed by the buddy allocator") , reclaim
> only affects managed_zones.
> 
> Let's adjust the code and comment accordingly.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

LGTM,

Reviewed-by: Oscar Salvador <osalvador@suse.de>

We still have some other places scattered all over where we use
populated_zone().
I think it should be great to check whether all those usages are
right.


-- 
Oscar Salvador
SUSE Labs


  parent reply	other threads:[~2022-03-28  8:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27  2:41 [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Wei Yang
2022-03-27  2:41 ` [PATCH 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone Wei Yang
2022-03-28  1:08   ` Huang, Ying
2022-03-28  7:23     ` Miaohe Lin
2022-03-29  0:45       ` Wei Yang
2022-03-29  1:55         ` Miaohe Lin
2022-03-29  0:41     ` Wei Yang
2022-03-29  0:43       ` Huang, Ying
2022-03-29  1:52         ` Wei Yang
2022-03-29  2:05           ` Huang, Ying
2022-03-30  0:14             ` Wei Yang
2022-03-29  2:22           ` Matthew Wilcox
2022-03-29 23:59             ` Wei Yang
2022-03-28  7:11 ` [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Miaohe Lin
2022-03-28  7:33 ` David Hildenbrand
2022-03-28  8:14 ` Oscar Salvador [this message]
2022-03-29  0:48   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkFuUsWe2LAuQa3n@localhost.localdomain \
    --to=osalvador@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=richard.weiyang@gmail.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.