From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D1BC433EF for ; Mon, 28 Mar 2022 08:25:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbiC1I1F (ORCPT ); Mon, 28 Mar 2022 04:27:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231705AbiC1I1E (ORCPT ); Mon, 28 Mar 2022 04:27:04 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 31AA7DEBF for ; Mon, 28 Mar 2022 01:25:24 -0700 (PDT) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 2D3FE63004; Mon, 28 Mar 2022 10:22:16 +0200 (CEST) Date: Mon, 28 Mar 2022 10:25:21 +0200 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [conntrack-tools PATCH 0/8] Fixes for a recent Coverity tool run Message-ID: References: <20220325105003.26621-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220325105003.26621-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org LGTM On Fri, Mar 25, 2022 at 11:49:55AM +0100, Phil Sutter wrote: > Phil Sutter (8): > hash: Flush tables when destroying > cache: Fix features array allocation > Fix potential buffer overrun in snprintf() calls > helpers: ftp: Avoid ugly casts > read_config_yy: Drop extra argument from dlog() call > Don't call exit() from signal handler > Drop pointless assignments > connntrack: Fix for memleak when parsing -j arg > > src/cache.c | 4 ++-- > src/conntrack.c | 2 ++ > src/hash.c | 1 + > src/helpers/ftp.c | 20 +++++++++----------- > src/helpers/ssdp.c | 1 - > src/main.c | 2 +- > src/process.c | 2 +- > src/queue.c | 4 ++-- > src/read_config_yy.y | 2 +- > src/run.c | 2 +- > 10 files changed, 20 insertions(+), 20 deletions(-) > > -- > 2.34.1 >