From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CF6C433EF for ; Mon, 28 Mar 2022 13:21:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243121AbiC1NXR (ORCPT ); Mon, 28 Mar 2022 09:23:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243131AbiC1NXQ (ORCPT ); Mon, 28 Mar 2022 09:23:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EBFA5E15E for ; Mon, 28 Mar 2022 06:21:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DEBDBB81123 for ; Mon, 28 Mar 2022 13:21:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F014C004DD; Mon, 28 Mar 2022 13:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648473691; bh=dj0P98xJRjma2BN5nz+V+Utih45W2JtRslqigLVy2m0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fC7jHqBwQSl6mlTzPtL8J/D7uspJkjMkaJFVbEmnVdYfMQ4nP0qLwrLUQEyu6U+gT 3Owyd59htscBe5Pwb0wr4S5E8WGbBTMAd/y88hlPVbPX9fgTCCxaSLbm+kC4jx53Wz dY4wX7DiTMsKEky9XODdbFnGRcjBLQrvdcz/Y8SQoBk57Vdbmwi2AFgexN9XF+ILnX H2E8wfTKEH4HQrBYLg5x/xMQuaehGxvIXhZCQ9IJulQJdPVoYvHLi+f05A5j+k7bl5 BI2pR+tcIPi/5lj79cbqENe0O8/P3qdhWuWqBXOEVBvje5ItGiqDTyI0KB/mnsqua2 Bk3LIQnWZBl+w== Date: Mon, 28 Mar 2022 14:21:28 +0100 From: Filipe Manana To: Johannes Thumshirn Cc: Naohiro Aota , "linux-btrfs@vger.kernel.org" Subject: Re: [PATCH] btrfs: fix outstanding extents calculation Message-ID: References: <06cc127b5d3c535917e90fbdce0534742dcde478.1648470587.git.naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Mar 28, 2022 at 01:14:02PM +0000, Johannes Thumshirn wrote: > On 28/03/2022 15:09, Filipe Manana wrote: > > On Mon, Mar 28, 2022 at 09:32:05PM +0900, Naohiro Aota wrote: > >> Running generic/406 causes the following WARNING in btrfs_destroy_inode() > >> which tells there is outstanding extents left. > > > > I can't trigger the warning with generic/406. > > Any special setup or config to trigger it? > > > > The change looks fine to me, however I'm curious why this isn't triggered > > with generic/406, nor anyone else reported it before, since the test is > > fully deterministic. > > > > I am able to trigger the WARN() with a different test (which is for a different, > not yet solved problem) on my zoned setup. With this patch, the WARN() is gone. I have no doubts about the fix being correct. I'm just puzzled why I can't trigger it with generic/406, given that it's a very deterministic test. If there's any special config or setup (mount options, zoned fs, etc), I would like to have it explicitly mentioned in the changelog.