From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65C15C433F5 for ; Mon, 28 Mar 2022 17:37:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3FCB10E73E; Mon, 28 Mar 2022 17:37:53 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26ABF10E73E; Mon, 28 Mar 2022 17:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648489073; x=1680025073; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Da/QX/7vIx1vKY1vsXt0hktcYMgaUWMSJdMfot3bs4o=; b=ln2V/2MGpL97k4y9kuVEMaCFcl9l4GXderEx0j621y0FeQjSH2qO9Xk6 Wsh6TsaSdKHeQpLEeSj7Bcdv4UordISdK4TilQvj/bgt9C1gDzC29EkPE WQrzvEfx/O0juFwHRc0VmCdltUVU9e5NcsrKy2EUycD6nn/sjKiFmHYbS zmLfjwgOhQjBeuaV3fCLFGoCNNGk/1XJSfLbOsLVUH5neOxbdvsB3JV5U PoE2uw4ZVvFC/213niO7OVcZ/OBY0bG8x7znOi2Fcd9rLIYggFE3S+9Xg /8pkU9LnRWE6yOGf9SwnAmq840ObuPpseADDtLhJ4LGQoHmZO8iYNK6hJ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="241219187" X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="241219187" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 10:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="604208252" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.61]) by fmsmga008.fm.intel.com with SMTP; 28 Mar 2022 10:37:49 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 28 Mar 2022 20:37:49 +0300 Date: Mon, 28 Mar 2022 20:37:49 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <9b617068d2349a574a837ad6207b1d45c4d79eb5.1648477901.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9b617068d2349a574a837ad6207b1d45c4d79eb5.1648477901.git.jani.nikula@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH v3 08/12] drm/edid: constify struct detailed_timing in parsing callbacks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Mar 28, 2022 at 05:34:29PM +0300, Jani Nikula wrote: > Moving one level higher, constify struct detailed_timing pointers in > callbacks. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 40 ++++++++++++++++++++------------------ > 1 file changed, 21 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 6d1461991ba4..47234cf211ca 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2349,7 +2349,7 @@ static bool is_detailed_timing_descriptor(const struct detailed_timing *descript > return descriptor->pixel_clock != 0; > } > > -typedef void detailed_cb(struct detailed_timing *timing, void *closure); > +typedef void detailed_cb(const struct detailed_timing *timing, void *closure); > > static void > cea_for_each_detailed_block(u8 *ext, detailed_cb *cb, void *closure) > @@ -2408,7 +2408,7 @@ drm_for_each_detailed_block(u8 *raw_edid, detailed_cb *cb, void *closure) > } > > static void > -is_rb(struct detailed_timing *descriptor, void *data) > +is_rb(const struct detailed_timing *descriptor, void *data) > { > bool *res = data; > > @@ -2438,9 +2438,9 @@ drm_monitor_supports_rb(struct edid *edid) > } > > static void > -find_gtf2(struct detailed_timing *descriptor, void *data) > +find_gtf2(const struct detailed_timing *descriptor, void *data) > { > - struct detailed_timing **res = data; > + const struct detailed_timing **res = data; > > if (!is_display_descriptor(descriptor, EDID_DETAIL_MONITOR_RANGE)) > return; > @@ -2455,7 +2455,7 @@ find_gtf2(struct detailed_timing *descriptor, void *data) > static int > drm_gtf2_hbreak(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2467,7 +2467,7 @@ drm_gtf2_hbreak(struct edid *edid) > static int > drm_gtf2_2c(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2479,7 +2479,7 @@ drm_gtf2_2c(struct edid *edid) > static int > drm_gtf2_m(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2491,7 +2491,7 @@ drm_gtf2_m(struct edid *edid) > static int > drm_gtf2_k(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2503,7 +2503,7 @@ drm_gtf2_k(struct edid *edid) > static int > drm_gtf2_2j(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -3009,7 +3009,7 @@ drm_cvt_modes_for_range(struct drm_connector *connector, struct edid *edid, > } > > static void > -do_inferred_modes(struct detailed_timing *timing, void *c) > +do_inferred_modes(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > const struct detailed_non_pixel *data = &timing->data.other_data; > @@ -3091,7 +3091,7 @@ drm_est3_modes(struct drm_connector *connector, const struct detailed_timing *ti > } > > static void > -do_established_modes(struct detailed_timing *timing, void *c) > +do_established_modes(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > > @@ -3142,7 +3142,7 @@ add_established_modes(struct drm_connector *connector, struct edid *edid) > } > > static void > -do_standard_modes(struct detailed_timing *timing, void *c) > +do_standard_modes(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > const struct detailed_non_pixel *data = &timing->data.other_data; > @@ -3255,7 +3255,7 @@ static int drm_cvt_modes(struct drm_connector *connector, > } > > static void > -do_cvt_mode(struct detailed_timing *timing, void *c) > +do_cvt_mode(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > > @@ -3284,7 +3284,7 @@ add_cvt_modes(struct drm_connector *connector, struct edid *edid) > static void fixup_detailed_cea_mode_clock(struct drm_display_mode *mode); > > static void > -do_detailed_mode(struct detailed_timing *timing, void *c) > +do_detailed_mode(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > struct drm_display_mode *newmode; > @@ -4517,17 +4517,19 @@ drm_parse_hdmi_vsdb_audio(struct drm_connector *connector, const u8 *db) > } > > static void > -monitor_name(struct detailed_timing *t, void *data) > +monitor_name(const struct detailed_timing *timing, void *data) > { > - if (!is_display_descriptor(t, EDID_DETAIL_MONITOR_NAME)) > + const char **res = data; > + > + if (!is_display_descriptor(timing, EDID_DETAIL_MONITOR_NAME)) > return; > > - *(u8 **)data = t->data.other_data.data.str.str; > + *res = timing->data.other_data.data.str.str; > } > > static int get_monitor_name(struct edid *edid, char name[13]) > { > - char *edid_name = NULL; > + const char *edid_name = NULL; > int mnl; > > if (!edid || !name) > @@ -5247,7 +5249,7 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > } > > static > -void get_monitor_range(struct detailed_timing *timing, > +void get_monitor_range(const struct detailed_timing *timing, > void *info_monitor_range) > { > struct drm_monitor_range_info *monitor_range = info_monitor_range; > -- > 2.30.2 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6858C433F5 for ; Mon, 28 Mar 2022 17:37:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 715BD10E741; Mon, 28 Mar 2022 17:37:54 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26ABF10E73E; Mon, 28 Mar 2022 17:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648489073; x=1680025073; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Da/QX/7vIx1vKY1vsXt0hktcYMgaUWMSJdMfot3bs4o=; b=ln2V/2MGpL97k4y9kuVEMaCFcl9l4GXderEx0j621y0FeQjSH2qO9Xk6 Wsh6TsaSdKHeQpLEeSj7Bcdv4UordISdK4TilQvj/bgt9C1gDzC29EkPE WQrzvEfx/O0juFwHRc0VmCdltUVU9e5NcsrKy2EUycD6nn/sjKiFmHYbS zmLfjwgOhQjBeuaV3fCLFGoCNNGk/1XJSfLbOsLVUH5neOxbdvsB3JV5U PoE2uw4ZVvFC/213niO7OVcZ/OBY0bG8x7znOi2Fcd9rLIYggFE3S+9Xg /8pkU9LnRWE6yOGf9SwnAmq840ObuPpseADDtLhJ4LGQoHmZO8iYNK6hJ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="241219187" X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="241219187" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2022 10:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,218,1643702400"; d="scan'208";a="604208252" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.61]) by fmsmga008.fm.intel.com with SMTP; 28 Mar 2022 10:37:49 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 28 Mar 2022 20:37:49 +0300 Date: Mon, 28 Mar 2022 20:37:49 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Subject: Re: [PATCH v3 08/12] drm/edid: constify struct detailed_timing in parsing callbacks Message-ID: References: <9b617068d2349a574a837ad6207b1d45c4d79eb5.1648477901.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9b617068d2349a574a837ad6207b1d45c4d79eb5.1648477901.git.jani.nikula@intel.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 28, 2022 at 05:34:29PM +0300, Jani Nikula wrote: > Moving one level higher, constify struct detailed_timing pointers in > callbacks. > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 40 ++++++++++++++++++++------------------ > 1 file changed, 21 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 6d1461991ba4..47234cf211ca 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2349,7 +2349,7 @@ static bool is_detailed_timing_descriptor(const struct detailed_timing *descript > return descriptor->pixel_clock != 0; > } > > -typedef void detailed_cb(struct detailed_timing *timing, void *closure); > +typedef void detailed_cb(const struct detailed_timing *timing, void *closure); > > static void > cea_for_each_detailed_block(u8 *ext, detailed_cb *cb, void *closure) > @@ -2408,7 +2408,7 @@ drm_for_each_detailed_block(u8 *raw_edid, detailed_cb *cb, void *closure) > } > > static void > -is_rb(struct detailed_timing *descriptor, void *data) > +is_rb(const struct detailed_timing *descriptor, void *data) > { > bool *res = data; > > @@ -2438,9 +2438,9 @@ drm_monitor_supports_rb(struct edid *edid) > } > > static void > -find_gtf2(struct detailed_timing *descriptor, void *data) > +find_gtf2(const struct detailed_timing *descriptor, void *data) > { > - struct detailed_timing **res = data; > + const struct detailed_timing **res = data; > > if (!is_display_descriptor(descriptor, EDID_DETAIL_MONITOR_RANGE)) > return; > @@ -2455,7 +2455,7 @@ find_gtf2(struct detailed_timing *descriptor, void *data) > static int > drm_gtf2_hbreak(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2467,7 +2467,7 @@ drm_gtf2_hbreak(struct edid *edid) > static int > drm_gtf2_2c(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2479,7 +2479,7 @@ drm_gtf2_2c(struct edid *edid) > static int > drm_gtf2_m(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2491,7 +2491,7 @@ drm_gtf2_m(struct edid *edid) > static int > drm_gtf2_k(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -2503,7 +2503,7 @@ drm_gtf2_k(struct edid *edid) > static int > drm_gtf2_2j(struct edid *edid) > { > - struct detailed_timing *descriptor = NULL; > + const struct detailed_timing *descriptor = NULL; > > drm_for_each_detailed_block((u8 *)edid, find_gtf2, &descriptor); > > @@ -3009,7 +3009,7 @@ drm_cvt_modes_for_range(struct drm_connector *connector, struct edid *edid, > } > > static void > -do_inferred_modes(struct detailed_timing *timing, void *c) > +do_inferred_modes(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > const struct detailed_non_pixel *data = &timing->data.other_data; > @@ -3091,7 +3091,7 @@ drm_est3_modes(struct drm_connector *connector, const struct detailed_timing *ti > } > > static void > -do_established_modes(struct detailed_timing *timing, void *c) > +do_established_modes(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > > @@ -3142,7 +3142,7 @@ add_established_modes(struct drm_connector *connector, struct edid *edid) > } > > static void > -do_standard_modes(struct detailed_timing *timing, void *c) > +do_standard_modes(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > const struct detailed_non_pixel *data = &timing->data.other_data; > @@ -3255,7 +3255,7 @@ static int drm_cvt_modes(struct drm_connector *connector, > } > > static void > -do_cvt_mode(struct detailed_timing *timing, void *c) > +do_cvt_mode(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > > @@ -3284,7 +3284,7 @@ add_cvt_modes(struct drm_connector *connector, struct edid *edid) > static void fixup_detailed_cea_mode_clock(struct drm_display_mode *mode); > > static void > -do_detailed_mode(struct detailed_timing *timing, void *c) > +do_detailed_mode(const struct detailed_timing *timing, void *c) > { > struct detailed_mode_closure *closure = c; > struct drm_display_mode *newmode; > @@ -4517,17 +4517,19 @@ drm_parse_hdmi_vsdb_audio(struct drm_connector *connector, const u8 *db) > } > > static void > -monitor_name(struct detailed_timing *t, void *data) > +monitor_name(const struct detailed_timing *timing, void *data) > { > - if (!is_display_descriptor(t, EDID_DETAIL_MONITOR_NAME)) > + const char **res = data; > + > + if (!is_display_descriptor(timing, EDID_DETAIL_MONITOR_NAME)) > return; > > - *(u8 **)data = t->data.other_data.data.str.str; > + *res = timing->data.other_data.data.str.str; > } > > static int get_monitor_name(struct edid *edid, char name[13]) > { > - char *edid_name = NULL; > + const char *edid_name = NULL; > int mnl; > > if (!edid || !name) > @@ -5247,7 +5249,7 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > } > > static > -void get_monitor_range(struct detailed_timing *timing, > +void get_monitor_range(const struct detailed_timing *timing, > void *info_monitor_range) > { > struct drm_monitor_range_info *monitor_range = info_monitor_range; > -- > 2.30.2 -- Ville Syrjälä Intel