From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70653C433FE for ; Mon, 28 Mar 2022 19:48:44 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id DA4CC3C9AF3 for ; Mon, 28 Mar 2022 21:48:41 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 234073C985F for ; Mon, 28 Mar 2022 21:48:31 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 9CBC5100093A for ; Mon, 28 Mar 2022 21:48:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 988E81F858; Mon, 28 Mar 2022 19:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648496909; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RgDWJnLiujkVyHGM8DsHindNGqg1Gwnyp1gUSJud0pE=; b=CjFw/+uzm+OSBvVsioIEg839cZ+uw7w2YTIWG0ShAtCP752IEToptPhf4zIhlI4zmfv3j1 BRcQK65TDTEsJjmnBv70Di4AybER4eu7DFpkkUyVDFZyLWpdhWzfyCwmp0LYvd2Dwhh0we HFDCE8QCQBSo0vhbOLI8qSz0gaELpmQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648496909; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RgDWJnLiujkVyHGM8DsHindNGqg1Gwnyp1gUSJud0pE=; b=JqE1keGit/sCz0KOO2aQ/hnGCousLiQdf/2wCaO3jFCrEBjtkYHimyaj4F29Gg8/9PSBhM wXf+MvqrRT5UhOBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5667313215; Mon, 28 Mar 2022 19:48:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2a9dEQ0RQmKfOwAAMHmgww (envelope-from ); Mon, 28 Mar 2022 19:48:29 +0000 Date: Mon, 28 Mar 2022 21:48:26 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20220325184435.1206-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] lib: Retry safe_clone() on ENOSPC|EUSERS X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > + /* too fast creating namespaces => retrying */ > > + if (pid < 0 && (errno == ENOSPC || errno == EUSERS)) { > > + tst_res_(file, lineno, TINFO | TERRNO, "%s() failed => retrying", > > + pid == -2 ? "clone" : "clone3"); > > + usleep(100000); > > + pid = tst_clone(args); > Wouldn't it make sense to use the exponential backof macro we have in > tst_common.h? +1 => I'll send v2. -- Mailing list info: https://lists.linux.it/listinfo/ltp