Re: [PATCH 1/2] usb: host: xhci: Remove msi irq reconfigure on resume

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 29, 2022 at 09:44:05AM -0600, Josue David Hernandez Gutierrez wrote:
> xhci_resume function is cleaning up msi irqs to avoid
> conflicts when xhci_run is called, because xhci_run
> is going to setup those msi irqs and it is called at
> the end of xhci_resume, then creating a new start
> callback for the xhci-pci driver to setup msi
> irqs and removing this msi irq setup from xhci_run
> reconfigure msi irqs won't be needed in xhci_resume.

You do have a full 72 columns to use in your changelog body :)

> This change also allows us move the msi setup code to
> the correct place, that is from xhci.c to xhci-pci.c

When you have "also" in a changelog text, it almost always means it
should be multiple patches.

Please break this up into "move the code" and "modify the code" patches
to make it easier to review.

As it is, it's pretty impossible to notice if anything has changed in
the logic or not.

Would you want to review this?

thanks,

greg k-h