All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: huangy81@chinatelecom.cn
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
	"Juan Quintela" <quintela@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v21 8/9] migration-test: Export migration-test util funtions
Date: Tue, 29 Mar 2022 14:54:27 -0400	[thread overview]
Message-ID: <YkNV42fFoD0xZ4cd@xz-m1.local> (raw)
In-Reply-To: <dc7f8ce5fadc148dc2c2e14bc43940d58cd205bc.1647435820.git.huangy81@chinatelecom.cn>

On Wed, Mar 16, 2022 at 09:07:20PM +0800, huangy81@chinatelecom.cn wrote:
> +void wait_for_serial(const char *tmpfs, const char *side)

Passing over tmpfs over and over (even if it's mostly a constant) doesn't
sound appealing to me..

I hope there's still a way that we could avoid doing that when spliting the
file.  Or, how about you just add a new test into migration-test?  After
all all migration tests (including auto-converge) is there, and I don't
strongly feel that we need a separate file urgently.

Thanks,

-- 
Peter Xu



  reply	other threads:[~2022-03-29 18:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 13:07 [PATCH v21 0/9] support dirty restraint on vCPU huangy81
2022-03-16 13:07 ` [PATCH v21 1/9] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping huangy81
2022-03-16 13:07 ` [PATCH v21 2/9] cpus: Introduce cpu_list_generation_id huangy81
2022-03-16 13:07 ` [PATCH v21 3/9] migration/dirtyrate: Refactor dirty page rate calculation huangy81
2022-03-16 13:07 ` [PATCH v21 4/9] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically huangy81
2022-03-16 13:07 ` [PATCH v21 5/9] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function huangy81
2022-03-16 13:07 ` [PATCH v21 6/9] softmmu/dirtylimit: Implement virtual CPU throttle huangy81
2022-03-16 13:07 ` [PATCH v21 7/9] softmmu/dirtylimit: Implement dirty page rate limit huangy81
2022-03-16 13:07 ` [PATCH v21 8/9] migration-test: Export migration-test util funtions huangy81
2022-03-29 18:54   ` Peter Xu [this message]
2022-03-31 15:35     ` Hyman
2022-03-16 13:07 ` [PATCH v21 9/9] tests: Add dirty page rate limit test huangy81
2022-03-29 19:54   ` Peter Xu
2022-03-31 17:28     ` Hyman
2022-03-21 15:21 ` [PATCH v21 0/9] support dirty restraint on vCPU Hyman Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkNV42fFoD0xZ4cd@xz-m1.local \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=huangy81@chinatelecom.cn \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.