Re: (2) Request for reverting the commit for Samsung HID driver

["gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>]

On Wed, Mar 30, 2022 at 05:09:37PM +0900, 조준완 wrote:
> 
> Dear Jiri Kosina,
> 
> Thank you for your propt reponse.
> 
> 
> Please refer to accossories below.
> 
> 
> static const struct hid_device_id samsung_devices[] = {
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_IR_REMOTE) },
> 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
>     { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD) },
>     { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_GAMEPAD) },
>     { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_ACTIONMOUSE) },
>     { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_UNIVERSAL_KBD) },
>     { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_SAMSUNG_ELECTRONICS, USB_DEVICE_ID_SAMSUNG_WIRELESS_MULTI_HOGP_KBD) },
> 	{ }
> };
> MODULE_DEVICE_TABLE(hid, samsung_devices);
> 
> 
> Mobile users prefer to use Bluetooth devices instead of USB devices.
> The commit should be reverted for Bluetooth accessories.
> 
> Due to internal problem, it takes time to upload Samsung's patch.
> So, please first revert the commit :)

No, not at all.

The commit is correct, as the driver code, as contained in the kernel
tree, requires that check to solve a problem where this driver can be
used to exploit the system.

Any out-of-tree changes you make, you are required to maintain and keep
up to date in order to have them remain working.  That is a requirement
of you, we have no idea what changes anyone else makes, that would be
impossible.

This is the real cost of keeping out-of-tree changes, your management
knows this and plans for it in their budgeting.  There is nothing that
we can do about this.

So the change needs to remain in order for the code to be correct.
Without it, you have a broken and totally insecure system.

If you wish to make the changes you list above to the driver, you now
need to make more changes in order to properly handle the fixes we made
to the code.  Please submit your changes so that we can review them and
accept them if they are correct.

thanks,

greg k-h