From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Michal Hocko <mhocko@suse.com>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>,
minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, s.suk@samsung.com,
jaewon31.kim@gmail.com
Subject: Re: [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs_malloc
Date: Wed, 30 Mar 2022 17:41:43 +0900 [thread overview]
Message-ID: <YkQXx+pLr6FxY1XZ@google.com> (raw)
In-Reply-To: <YkQPefdRc+hxIXEV@dhcp22.suse.cz>
On (22/03/30 10:06), Michal Hocko wrote:
> On Wed 30-03-22 14:25:02, Jaewon Kim wrote:
> > The page allocation with GFP_NOIO may fail. And zram can handle this
> > allocation failure. We do not need to print log for this.
>
> GFP_NOIO doesn't have any special meaning wrt to failures. zram
> allocates from the memory reclaim context which is a bad design IMHO.
Agreed.
> Is the memory allocation failure gracefully recoverable?
No, it's not. I agree that we want to see that allocation warning
in the logs.
next prev parent reply other threads:[~2022-03-30 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220330052214epcas1p250cff6b3168a1c9c253e1fe70e68ca8b@epcas1p2.samsung.com>
2022-03-30 5:25 ` [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs_malloc Jaewon Kim
2022-03-30 8:06 ` Michal Hocko
2022-03-30 8:41 ` Sergey Senozhatsky [this message]
2022-03-30 8:49 ` Michal Hocko
2022-03-30 9:11 ` Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkQXx+pLr6FxY1XZ@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=jaewon31.kim@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=s.suk@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.