From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/3] broken_ip-nexthdr.sh: Check IPv6 support before forcing it
Date: Wed, 30 Mar 2022 11:15:54 +0200 [thread overview]
Message-ID: <YkQfyh3ppXPGMarB@yuki> (raw)
In-Reply-To: <YjoUprPfTYN1nlt4@pevik>
Hi!
> I tried to implement this [1] (or [2] if I force push), and using getopts the
> end of the script only would require also to move loading '. tst_test.sh' at the
> end of *all* the test scripts because setup functions needs to be loaded before
> sourcing tst_test.sh. Do we want this?
Sounds reasonable. I would go even further and put the line that sources
the tst_test.sh to be last line in the test.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-30 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 19:46 [LTP] [PATCH v2 0/3] shell: Fixes for disabled IPv6 Petr Vorel
2022-02-04 19:46 ` [LTP] [PATCH v2 1/3] tst_net.sh: Fix " Petr Vorel
2022-03-02 11:00 ` Cyril Hrubis
2022-03-02 11:05 ` Petr Vorel
2022-02-04 19:46 ` [LTP] [PATCH v2 2/3] broken_ip-nexthdr.sh: Check IPv6 support before forcing it Petr Vorel
2022-03-02 14:18 ` Cyril Hrubis
2022-03-02 20:44 ` Petr Vorel
2022-03-22 18:25 ` Petr Vorel
2022-03-30 9:15 ` Cyril Hrubis [this message]
2022-03-30 9:17 ` Petr Vorel
2022-02-04 19:46 ` [LTP] [PATCH v2 3/3] netns: Rewrite to use tst_net.sh Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkQfyh3ppXPGMarB@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.