From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 136B4C433F5 for ; Wed, 30 Mar 2022 09:17:39 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9AF573C9F8E for ; Wed, 30 Mar 2022 11:17:36 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 2888E3C089F for ; Wed, 30 Mar 2022 11:17:25 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 681561400550 for ; Wed, 30 Mar 2022 11:17:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8DD821F38C; Wed, 30 Mar 2022 09:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648631843; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GN1p8UuXV+lsJY3Z2UaDVbeihQjx8hjGcksr9G2H/gs=; b=ovFCHwZrOEUDXjqg+AzwOhDPxGvVPhXYsIR5W4LxYJFLOoLZqXutWq40wdEle/EMfCpYyv deH98zjZ0dBPrU2sGzMoF7PbWqYHJ7QqUlkXXqQeehnENjlIKfdIhthcj9YSdKC9PSFRze Xq8/gDBxkBr+eE6klOHv3gZsJqNckfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648631843; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GN1p8UuXV+lsJY3Z2UaDVbeihQjx8hjGcksr9G2H/gs=; b=R661xYHEKc+lliJb1gE142oayiuN5G5FA/dnLsYTVDKmyuMgLHjLysfxmZvFjrxRs1jNzH uTT7l6ssJ8xgaqBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5871F13A60; Wed, 30 Mar 2022 09:17:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MF2PEyMgRGIKVwAAMHmgww (envelope-from ); Wed, 30 Mar 2022 09:17:23 +0000 Date: Wed, 30 Mar 2022 11:17:21 +0200 From: Petr Vorel To: Cyril Hrubis Message-ID: References: <20220204194648.32165-1-pvorel@suse.cz> <20220204194648.32165-3-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 2/3] broken_ip-nexthdr.sh: Check IPv6 support before forcing it X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > Hi! > > I tried to implement this [1] (or [2] if I force push), and using getopts the > > end of the script only would require also to move loading '. tst_test.sh' at the > > end of *all* the test scripts because setup functions needs to be loaded before > > sourcing tst_test.sh. Do we want this? > Sounds reasonable. I would go even further and put the line that sources > the tst_test.sh to be last line in the test. +1, I'll also update docs examples and mention it. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp