From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F293AC433EF for ; Thu, 31 Mar 2022 05:23:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229720AbiCaFZP (ORCPT ); Thu, 31 Mar 2022 01:25:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiCaFZO (ORCPT ); Thu, 31 Mar 2022 01:25:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A2F9FA20A; Wed, 30 Mar 2022 22:23:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0884961580; Thu, 31 Mar 2022 05:23:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B94DC340EE; Thu, 31 Mar 2022 05:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648704206; bh=eBy7+Ih0SkRIqoSoJt0V6SXGw5DK/vQX/BZHc0wYr8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mm/n9Jum+7wft5UX7zfI6APvwfOgo2tXy6SSzi8Uxk9pXWWxsELdnowKdRQd/TMh3 f+4RBVl+y29sVXfrd8HUN1KRH3T3wBQmUfmVT0pCm4CLF+PN2TiQNgFuTjg89WwOa3 5yzIvZjJ6ogpVE3Kp4AFTB9oP4lPeJRqlm/4JA5tNXiHZH6Ed/Idy5wYZ1sx0PcPja HBNQuls/byuxIqW23JCIpCrul84Lqk7idjq3nukNelghfHTCbNOp15Cqw5TL68z7RL IvKySAlilij5Dd7Wid7OIeY2kF/7Skz5S7vXX0ij+oJhZ6ncbsjpzyRogLmz4P+BSa 1mUhPhUjmgyjg== Date: Thu, 31 Mar 2022 10:53:22 +0530 From: Vinod Koul To: Martin =?utf-8?Q?Povi=C5=A1er?= Cc: Hector Martin , Sven Peter , Rob Herring , Krzysztof Kozlowski , Alyssa Rosenzweig , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH 1/2] dt-bindings: dma: Add Apple ADMAC Message-ID: References: <20220330164458.93055-1-povik+lin@cutebit.org> <20220330164458.93055-2-povik+lin@cutebit.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220330164458.93055-2-povik+lin@cutebit.org> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 30-03-22, 18:44, Martin Povišer wrote: > Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio > samples on Apple SoCs from the "Apple Silicon" family. > > Signed-off-by: Martin Povišer > --- > .../devicetree/bindings/dma/apple,admac.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/apple,admac.yaml > > diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml > new file mode 100644 > index 000000000000..34f76a9a2983 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/apple,admac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Audio DMA Controller (ADMAC) > + > +description: | > + Apple's Audio DMA Controller (ADMAC) is used to fetch and store > + audio samples on Apple SoCs from the "Apple Silicon" family. > + > +maintainers: > + - Martin Povišer > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t6000-admac > + - apple,t8103-admac > + - const: apple,admac > + > + reg: > + maxItems: 1 > + > + '#dma-cells': > + const: 1 > + > + apple,internal-irq-destination: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Index influencing internal routing of the IRQs > + within the peripheral. do you have more details for this, is this for peripheral and if so suited to be in dam-cells? > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - '#dma-cells' > + - dma-channels > + - apple,internal-irq-destination > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + dart_sio: iommu@235004000 { > + compatible = "apple,t8103-dart", "apple,dart"; > + reg = <0x2 0x35004000 0x0 0x4000>; > + interrupt-parent = <&aic>; > + interrupts = ; > + #iommu-cells = <1>; > + }; > + > + admac: dma-controller@238200000 { > + compatible = "apple,t8103-admac", "apple,admac"; > + reg = <0x2 0x38200000 0x0 0x34000>; > + dma-channels = <12>; > + interrupt-parent = <&aic>; > + interrupts = ; > + #dma-cells = <1>; > + iommus = <&dart_sio 2>; > + apple,internal-irq-destination = <1>; > + }; > -- > 2.33.0 -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38934C433EF for ; Thu, 31 Mar 2022 05:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NkyPZd8IJDtZP7TjqtKWvFJpcWrsAfsJvddBWf5A4+A=; b=OEl8QnJq5KwRIN 50o0TlI17fhnNYl8gV1zOlvmCAwOelunTSLOODPxl6HyjdTT7/ROM6wqAbqkU6zWd5YVGXmTMA7M3 ODNDykmHGNl+Coi3VWsQ/CDL8YmHPxHA4vbTEOQxT38j/ZZZ1/IlGnoLsbgUyeCwDM6lhtSB1tovR q/ii8BHMRl5yxRcWs72tG/1NyWmab+a0KlThZkfSutn/brUTrgQ+uBJvbvKf4lygFVPcfwBDdNLPB bFl6149jW4SDAAqIqw42pbscUOiH/xaO39D5HoBGYPfrjOVlbi8QwIIPiODZrY0HbEApg7aQy1Zqg JYyvCFpk5ST+6hBx7Rkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZnHO-000h4C-JX; Thu, 31 Mar 2022 05:23:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZnHL-000h31-DS for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 05:23:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 053526157E; Thu, 31 Mar 2022 05:23:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B94DC340EE; Thu, 31 Mar 2022 05:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648704206; bh=eBy7+Ih0SkRIqoSoJt0V6SXGw5DK/vQX/BZHc0wYr8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mm/n9Jum+7wft5UX7zfI6APvwfOgo2tXy6SSzi8Uxk9pXWWxsELdnowKdRQd/TMh3 f+4RBVl+y29sVXfrd8HUN1KRH3T3wBQmUfmVT0pCm4CLF+PN2TiQNgFuTjg89WwOa3 5yzIvZjJ6ogpVE3Kp4AFTB9oP4lPeJRqlm/4JA5tNXiHZH6Ed/Idy5wYZ1sx0PcPja HBNQuls/byuxIqW23JCIpCrul84Lqk7idjq3nukNelghfHTCbNOp15Cqw5TL68z7RL IvKySAlilij5Dd7Wid7OIeY2kF/7Skz5S7vXX0ij+oJhZ6ncbsjpzyRogLmz4P+BSa 1mUhPhUjmgyjg== Date: Thu, 31 Mar 2022 10:53:22 +0530 From: Vinod Koul To: Martin =?utf-8?Q?Povi=C5=A1er?= Cc: Hector Martin , Sven Peter , Rob Herring , Krzysztof Kozlowski , Alyssa Rosenzweig , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH 1/2] dt-bindings: dma: Add Apple ADMAC Message-ID: References: <20220330164458.93055-1-povik+lin@cutebit.org> <20220330164458.93055-2-povik+lin@cutebit.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220330164458.93055-2-povik+lin@cutebit.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220330_222327_565343_3137D507 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMzAtMDMtMjIsIDE4OjQ0LCBNYXJ0aW4gUG92acWhZXIgd3JvdGU6Cj4gQXBwbGUncyBBdWRp byBETUEgQ29udHJvbGxlciAoQURNQUMpIGlzIHVzZWQgdG8gZmV0Y2ggYW5kIHN0b3JlIGF1ZGlv Cj4gc2FtcGxlcyBvbiBBcHBsZSBTb0NzIGZyb20gdGhlICJBcHBsZSBTaWxpY29uIiBmYW1pbHku Cj4gCj4gU2lnbmVkLW9mZi1ieTogTWFydGluIFBvdmnFoWVyIDxwb3ZpaytsaW5AY3V0ZWJpdC5v cmc+Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9hcHBsZSxhZG1hYy55YW1s ICB8IDczICsrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDczIGluc2VydGlv bnMoKykKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9kbWEvYXBwbGUsYWRtYWMueWFtbAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZG1hL2FwcGxlLGFkbWFjLnlhbWwgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZG1hL2FwcGxlLGFkbWFjLnlhbWwKPiBuZXcgZmlsZSBtb2Rl IDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMC4uMzRmNzZhOWEyOTgzCj4gLS0tIC9kZXYvbnVs bAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvYXBwbGUsYWRt YWMueWFtbAo+IEBAIC0wLDAgKzEsNzMgQEAKPiArIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjog R1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZQo+ICslWUFNTCAxLjIKPiArLS0tCj4gKyRpZDog aHR0cDovL2RldmljZXRyZWUub3JnL3NjaGVtYXMvZG1hL2FwcGxlLGFkbWFjLnlhbWwjCj4gKyRz Y2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9tZXRhLXNjaGVtYXMvY29yZS55YW1sIwo+ICsK PiArdGl0bGU6IEFwcGxlIEF1ZGlvIERNQSBDb250cm9sbGVyIChBRE1BQykKPiArCj4gK2Rlc2Ny aXB0aW9uOiB8Cj4gKyAgQXBwbGUncyBBdWRpbyBETUEgQ29udHJvbGxlciAoQURNQUMpIGlzIHVz ZWQgdG8gZmV0Y2ggYW5kIHN0b3JlCj4gKyAgYXVkaW8gc2FtcGxlcyBvbiBBcHBsZSBTb0NzIGZy b20gdGhlICJBcHBsZSBTaWxpY29uIiBmYW1pbHkuCj4gKwo+ICttYWludGFpbmVyczoKPiArICAt IE1hcnRpbiBQb3ZpxaFlciA8cG92aWsrbGluQGN1dGViaXQub3JnPgo+ICsKPiArYWxsT2Y6Cj4g KyAgLSAkcmVmOiAiZG1hLWNvbnRyb2xsZXIueWFtbCMiCj4gKwo+ICtwcm9wZXJ0aWVzOgo+ICsg IGNvbXBhdGlibGU6Cj4gKyAgICBpdGVtczoKPiArICAgICAgLSBlbnVtOgo+ICsgICAgICAgICAg LSBhcHBsZSx0NjAwMC1hZG1hYwo+ICsgICAgICAgICAgLSBhcHBsZSx0ODEwMy1hZG1hYwo+ICsg ICAgICAtIGNvbnN0OiBhcHBsZSxhZG1hYwo+ICsKPiArICByZWc6Cj4gKyAgICBtYXhJdGVtczog MQo+ICsKPiArICAnI2RtYS1jZWxscyc6Cj4gKyAgICBjb25zdDogMQo+ICsKPiArICBhcHBsZSxp bnRlcm5hbC1pcnEtZGVzdGluYXRpb246Cj4gKyAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55YW1s Iy9kZWZpbml0aW9ucy91aW50MzIKPiArICAgIGRlc2NyaXB0aW9uOiBJbmRleCBpbmZsdWVuY2lu ZyBpbnRlcm5hbCByb3V0aW5nIG9mIHRoZSBJUlFzCj4gKyAgICAgIHdpdGhpbiB0aGUgcGVyaXBo ZXJhbC4KCmRvIHlvdSBoYXZlIG1vcmUgZGV0YWlscyBmb3IgdGhpcywgaXMgdGhpcyBmb3IgcGVy aXBoZXJhbCBhbmQgaWYgc28Kc3VpdGVkIHRvIGJlIGluIGRhbS1jZWxscz8KCj4gKwo+ICsgIGlu dGVycnVwdHM6Cj4gKyAgICBtYXhJdGVtczogMQo+ICsKPiArcmVxdWlyZWQ6Cj4gKyAgLSBjb21w YXRpYmxlCj4gKyAgLSByZWcKPiArICAtICcjZG1hLWNlbGxzJwo+ICsgIC0gZG1hLWNoYW5uZWxz Cj4gKyAgLSBhcHBsZSxpbnRlcm5hbC1pcnEtZGVzdGluYXRpb24KPiArICAtIGludGVycnVwdHMK PiArCj4gK2FkZGl0aW9uYWxQcm9wZXJ0aWVzOiBmYWxzZQo+ICsKPiArZXhhbXBsZXM6Cj4gKyAg LSB8Cj4gKyAgICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvYXBw bGUtYWljLmg+Cj4gKyAgICAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xs ZXIvaXJxLmg+Cj4gKwo+ICsgICAgZGFydF9zaW86IGlvbW11QDIzNTAwNDAwMCB7Cj4gKyAgICAg IGNvbXBhdGlibGUgPSAiYXBwbGUsdDgxMDMtZGFydCIsICJhcHBsZSxkYXJ0IjsKPiArICAgICAg cmVnID0gPDB4MiAweDM1MDA0MDAwIDB4MCAweDQwMDA+Owo+ICsgICAgICBpbnRlcnJ1cHQtcGFy ZW50ID0gPCZhaWM+Owo+ICsgICAgICBpbnRlcnJ1cHRzID0gPEFJQ19JUlEgNjM1IElSUV9UWVBF X0xFVkVMX0hJR0g+Owo+ICsgICAgICAjaW9tbXUtY2VsbHMgPSA8MT47Cj4gKyAgICB9Owo+ICsK PiArICAgIGFkbWFjOiBkbWEtY29udHJvbGxlckAyMzgyMDAwMDAgewo+ICsgICAgICBjb21wYXRp YmxlID0gImFwcGxlLHQ4MTAzLWFkbWFjIiwgImFwcGxlLGFkbWFjIjsKPiArICAgICAgcmVnID0g PDB4MiAweDM4MjAwMDAwIDB4MCAweDM0MDAwPjsKPiArICAgICAgZG1hLWNoYW5uZWxzID0gPDEy PjsKPiArICAgICAgaW50ZXJydXB0LXBhcmVudCA9IDwmYWljPjsKPiArICAgICAgaW50ZXJydXB0 cyA9IDxBSUNfSVJRIDYyNiBJUlFfVFlQRV9MRVZFTF9ISUdIPjsKPiArICAgICAgI2RtYS1jZWxs cyA9IDwxPjsKPiArICAgICAgaW9tbXVzID0gPCZkYXJ0X3NpbyAyPjsKPiArICAgICAgYXBwbGUs aW50ZXJuYWwtaXJxLWRlc3RpbmF0aW9uID0gPDE+Owo+ICsgICAgfTsKPiAtLSAKPiAyLjMzLjAK Ci0tIAp+Vmlub2QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK