From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6852090792663403449==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] drivers/hw_random: fix platform_get_irq.cocci warnings Date: Thu, 31 Mar 2022 14:12:33 +0800 Message-ID: In-Reply-To: <202203311416.FRqOJZon-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============6852090792663403449== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org BCC: lkp(a)intel.com CC: linux-kernel(a)vger.kernel.org TO: Huan Feng CC: Emil Renner Berthing From: kernel test robot drivers/char/hw_random/starfive-vic-rng.c:209:2-9: line 209 is redundant be= cause platform_get_irq() already prints an error Remove dev_err() messages after platform_get_irq*() failures Generated by: scripts/coccinelle/api/platform_get_irq.cocci CC: Huan Feng Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/esmil/linux visionfive head: 6c7cd35771680c033c40b4af48cbe7e3093eab3d commit: 1d3f42fdd786e76c5138aff9663180a7f17c68bd [28/62] drivers/hw_random:= Add StarFive JH7100 Random Number Generator driver :::::: branch date: 14 hours ago :::::: commit date: 9 days ago Please take the patch only if it's a positive warning. Thanks! drivers/char/hw_random/starfive-vic-rng.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/char/hw_random/starfive-vic-rng.c +++ b/drivers/char/hw_random/starfive-vic-rng.c @@ -206,7 +206,6 @@ static int vic_rng_probe(struct platform = irq =3D platform_get_irq(pdev, 0); if (irq <=3D 0) { - dev_err(&pdev->dev, "Couldn't get irq %d\n", irq); return irq; } =20 --===============6852090792663403449==--