From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77E30C433F5 for ; Thu, 31 Mar 2022 07:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ig1xicqcX5gj4Fi9hIXfYLU01p0twcJua6bRzmYsnHw=; b=oO/Owmxy7Ogfvq OqpNo1QW7JBvQadbB+aowZwP6v7zbR+weCXDHiIaXibYAHNUNR4EmWvnMj7FVThahFsmdYnpSTt2D hnqwH2oQUmc0VdBr/0W7fcEo2hSTtcPA6F9jVWEJ8n5w6Nyd6agRnBzhHVi/P369gY4cYeqoSF+ZZ W9M9A5IchzWfpmlWgH27q1+9DkAW5B5TKyr8THpUijJ+UvFN6lGs4ug8FGJm3o1nXHSzHgYvd4vPr 32yY/82tNaFLcctUOBc5g3H93l6PdWqkWhykL0jGe5iP4y9j99LgJBzqx48v39qyb7Ls38Kvic+Mf ut5zdjjmnFiX2CDY2MTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZox1-0010hd-5y; Thu, 31 Mar 2022 07:10:35 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZoww-0010g6-09 for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 07:10:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VtSyhCBRl6DDd411G5kv1lVJwnclO4BJfyyDJEiIIQQ=; b=r44vCvmN1Q4mZOvdEid41+bbQ5 VKde0jyZ1PAJJAX0DQvXUNXjYSbMR1O5y/GpPW12E/zBP4Ou/3pxCBLCxNGgEagFfeZZKdrYbAvAK ElofHY/yYSPxonnlV2KM5fTIjQ2+rvQoVtrymkk0xUq8gX6TW5utiHtovTWK4jzin952Psuu6hRKh 7XhKlR1bR4UQ5Y74um1Q+1n2mTwtQr6cdP50g3hD7RHVsQB3J8jJfAIuBGcTtClXl+iNWZrfzScZ3 YN52iT+ZbYPjxUAHzZiKDZToAUJtGC+XPCl/vloKT8jPTEFjb5Tt+uPvmme/N9OFiiVv4KXbl6ahh 1wgxDnqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58038) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nZowt-0004L7-2C; Thu, 31 Mar 2022 08:10:26 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nZowp-0007QG-Sx; Thu, 31 Mar 2022 08:10:23 +0100 Date: Thu, 31 Mar 2022 08:10:23 +0100 From: "Russell King (Oracle)" To: Austin Kim Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, austin.kim@lge.com, p4ranlee@gmail.com Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel=' Message-ID: References: <20220330110715.GA1534@raspberrypi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220330110715.GA1534@raspberrypi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_001030_115622_02D45E5D X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote: > From: Austin Kim > > Add invalid value check expression when no crashkernel= or invalid value > specified using kdump. Hi, I think you mean when "crashkernel=0" is specified, as other invalid input should result in -EINVAL being returned. Please update the patch description and comment. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA74EC433F5 for ; Thu, 31 Mar 2022 07:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231844AbiCaHMn (ORCPT ); Thu, 31 Mar 2022 03:12:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231757AbiCaHMW (ORCPT ); Thu, 31 Mar 2022 03:12:22 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC2F65B3D0 for ; Thu, 31 Mar 2022 00:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VtSyhCBRl6DDd411G5kv1lVJwnclO4BJfyyDJEiIIQQ=; b=r44vCvmN1Q4mZOvdEid41+bbQ5 VKde0jyZ1PAJJAX0DQvXUNXjYSbMR1O5y/GpPW12E/zBP4Ou/3pxCBLCxNGgEagFfeZZKdrYbAvAK ElofHY/yYSPxonnlV2KM5fTIjQ2+rvQoVtrymkk0xUq8gX6TW5utiHtovTWK4jzin952Psuu6hRKh 7XhKlR1bR4UQ5Y74um1Q+1n2mTwtQr6cdP50g3hD7RHVsQB3J8jJfAIuBGcTtClXl+iNWZrfzScZ3 YN52iT+ZbYPjxUAHzZiKDZToAUJtGC+XPCl/vloKT8jPTEFjb5Tt+uPvmme/N9OFiiVv4KXbl6ahh 1wgxDnqA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58038) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nZowt-0004L7-2C; Thu, 31 Mar 2022 08:10:26 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nZowp-0007QG-Sx; Thu, 31 Mar 2022 08:10:23 +0100 Date: Thu, 31 Mar 2022 08:10:23 +0100 From: "Russell King (Oracle)" To: Austin Kim Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, austin.kim@lge.com, p4ranlee@gmail.com Subject: Re: [PATCH] arm: kdump: add invalid value check for 'crashkernel=' Message-ID: References: <20220330110715.GA1534@raspberrypi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330110715.GA1534@raspberrypi> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 12:07:15PM +0100, Austin Kim wrote: > From: Austin Kim > > Add invalid value check expression when no crashkernel= or invalid value > specified using kdump. Hi, I think you mean when "crashkernel=0" is specified, as other invalid input should result in -EINVAL being returned. Please update the patch description and comment. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!