From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2BBFC433F5 for ; Thu, 31 Mar 2022 09:15:39 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-375-zP24APhRP2eNXKSecDaqvg-1; Thu, 31 Mar 2022 05:15:35 -0400 X-MC-Unique: zP24APhRP2eNXKSecDaqvg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 951AD805F7C; Thu, 31 Mar 2022 09:15:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4ABCB400E43D; Thu, 31 Mar 2022 09:15:31 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E99A71947BBB; Thu, 31 Mar 2022 09:15:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A2D0619451F3 for ; Thu, 31 Mar 2022 09:15:30 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 82CCF5B083E; Thu, 31 Mar 2022 09:15:30 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F0765B083B for ; Thu, 31 Mar 2022 09:15:30 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 67AC8811E75 for ; Thu, 31 Mar 2022 09:15:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-548-iCVSQmcoPqeHr125qT9eBg-1; Thu, 31 Mar 2022 05:15:27 -0400 X-MC-Unique: iCVSQmcoPqeHr125qT9eBg-1 Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZqto-001ROG-Gh; Thu, 31 Mar 2022 09:15:24 +0000 Date: Thu, 31 Mar 2022 02:15:24 -0700 From: Christoph Hellwig To: Dennis Zhou Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Subject: Re: [dm-devel] can we reduce bio_set_dev overhead due to bio_associate_blkg? X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, Mike Snitzer , Christoph Hellwig , dm-devel@redhat.com, tj@kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Mar 30, 2022 at 10:52:13PM -0700, Dennis Zhou wrote: > I took a quick look. It seems with the new interface, > bio_clone_blkg_association() is unnecessary given the correct > association should be derived from the bio_alloc*() calls with the > passed in bdev. Also, blkcg_bio_issue_init() in clone seems wrong. Yes, I think you are right. > Maybe the right thing to do here for md-linear and btrfs (what I've > looked at) is to delay cloning until the map occurs and the right device > is already in hand? That would in general be the preferred option where possible. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76579C433F5 for ; Thu, 31 Mar 2022 09:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233696AbiCaJRM (ORCPT ); Thu, 31 Mar 2022 05:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbiCaJRM (ORCPT ); Thu, 31 Mar 2022 05:17:12 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A901B10781A for ; Thu, 31 Mar 2022 02:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NmduW1iwmBwQuxt8u8E9I4xdRNInpTYlPZnwFbf13L8=; b=0YqOVjVHUA/pWE6flu0hEhJgNR c6NDxH/8dHAlQvnDfD5MqguDJ77zoOmYDT4CfEhozthfCGQpaZLtPvel4WkmsELC0NrJFRIFvecrX 8n4oO0g7MBMmv3k2/n8e1TdRMvtG16J6b5kGsEzWwptmYmHYSOA9RN+yj/d03gfnZIRq+KKfKd0Z/ DTdLRWwksfvKyrQoO1qFWfhJWls/XOUkZnd02XvDqZDn9wbZF4/9KYcCkfSmqNMKf5NE+YtSxfHX3 GfNQPmnbljnHlxSF/9s3I90RgnHsS+iUxGVXHNUaUFfYU9mROhgy2GcalIhDOZoRQgLIish2tNuF1 Gbd6loEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZqto-001ROG-Gh; Thu, 31 Mar 2022 09:15:24 +0000 Date: Thu, 31 Mar 2022 02:15:24 -0700 From: Christoph Hellwig To: Dennis Zhou Cc: Christoph Hellwig , Mike Snitzer , tj@kernel.org, axboe@kernel.dk, linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: can we reduce bio_set_dev overhead due to bio_associate_blkg? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Mar 30, 2022 at 10:52:13PM -0700, Dennis Zhou wrote: > I took a quick look. It seems with the new interface, > bio_clone_blkg_association() is unnecessary given the correct > association should be derived from the bio_alloc*() calls with the > passed in bdev. Also, blkcg_bio_issue_init() in clone seems wrong. Yes, I think you are right. > Maybe the right thing to do here for md-linear and btrfs (what I've > looked at) is to delay cloning until the map occurs and the right device > is already in hand? That would in general be the preferred option where possible.