All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Christian Löhle" <CLoehle@hyperstone.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"digetx@gmail.com" <digetx@gmail.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>
Subject: Re: [PATCH 1/2] mmc: mmc_spi: parse speed mode options
Date: Thu, 31 Mar 2022 17:06:37 +0300	[thread overview]
Message-ID: <YkW1beKzd5LfxZgG@smile.fi.intel.com> (raw)
In-Reply-To: <20c6efa9a4c7423bbfb9352705c4a53a@hyperstone.com>

On Thu, Mar 31, 2022 at 07:28:47AM +0000, Christian Löhle wrote:
> Since SD and MMC Highspeed modes are also valid for SPI let's parse
> them too.

Makes sense to me.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
>  drivers/mmc/host/of_mmc_spi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 3629550528b6..bf54776fb26c 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -70,6 +70,10 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
>  	} else {
>  		oms->pdata.caps |= MMC_CAP_NEEDS_POLL;
>  	}
> +	if (device_property_read_bool(dev, "cap-sd-highspeed"))
> +		oms->pdata.caps |= MMC_CAP_SD_HIGHSPEED;
> +	if (device_property_read_bool(dev, "cap-mmc-highspeed"))
> +		oms->pdata.caps |= MMC_CAP_MMC_HIGHSPEED;
> 
>  	dev->platform_data = &oms->pdata;
>  	return dev->platform_data;
> --
> 2.34.1
> Hyperstone GmbH | Reichenaustr. 39a  | 78467 Konstanz
> Managing Director: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782
> 

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2022-03-31 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  7:28 [PATCH 1/2] mmc: mmc_spi: parse speed mode options Christian Löhle
2022-03-31  7:29 ` [PATCH 2/2] mmc: mmc_spi: enable Highspeed for above 25MHz Christian Löhle
2022-03-31 14:07   ` andriy.shevchenko
2022-04-05  9:20     ` Christian Löhle
2022-04-05 12:56       ` Ulf Hansson
2022-03-31 14:06 ` Andy Shevchenko [this message]
2022-04-06 14:55 ` [PATCH 1/2] mmc: mmc_spi: parse speed mode options Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkW1beKzd5LfxZgG@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=CLoehle@hyperstone.com \
    --cc=adrian.hunter@intel.com \
    --cc=avri.altman@wdc.com \
    --cc=digetx@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.