From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/3] i386: factor out x86_firmware_configure()
Date: Thu, 31 Mar 2022 14:33:07 +0100 [thread overview]
Message-ID: <YkWtk1OU7AU6rGSz@redhat.com> (raw)
In-Reply-To: <20220331083549.749566-3-kraxel@redhat.com>
On Thu, Mar 31, 2022 at 10:35:48AM +0200, Gerd Hoffmann wrote:
> move sev firmware setup to separate function so it can be used from
> other code paths. No functional change.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Tested-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> include/hw/i386/x86.h | 3 +++
> hw/i386/pc_sysfw.c | 36 ++++++++++++++++++++++--------------
> 2 files changed, 25 insertions(+), 14 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-03-31 13:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 8:35 [PATCH 0/3] i386: firmware parsing and sev setup for -bios loaded firmware Gerd Hoffmann
2022-03-31 8:35 ` [PATCH 1/3] i386: move bios load error message Gerd Hoffmann
2022-03-31 13:02 ` Daniel P. Berrangé
2022-03-31 20:45 ` Philippe Mathieu-Daudé
2022-03-31 8:35 ` [PATCH 2/3] i386: factor out x86_firmware_configure() Gerd Hoffmann
2022-03-31 13:07 ` Daniel P. Berrangé
2022-03-31 13:27 ` Gerd Hoffmann
2022-03-31 13:33 ` Daniel P. Berrangé [this message]
2022-03-31 21:11 ` Philippe Mathieu-Daudé
2022-04-01 5:08 ` Gerd Hoffmann
2022-04-01 5:28 ` Xiaoyao Li
2022-04-01 10:36 ` Philippe Mathieu-Daudé
2022-04-01 15:25 ` Xiaoyao Li
2022-03-31 8:35 ` [PATCH 3/3] i386: firmware parsing and sev setup for -bios loaded firmware Gerd Hoffmann
2022-03-31 13:10 ` Daniel P. Berrangé
2022-03-31 13:44 ` Gerd Hoffmann
2022-03-31 20:47 ` Philippe Mathieu-Daudé
2022-03-31 20:24 ` [PATCH 0/3] " Michael S. Tsirkin
2022-04-25 13:56 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkWtk1OU7AU6rGSz@redhat.com \
--to=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.