From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467F9C433FE for ; Thu, 31 Mar 2022 20:37:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241491AbiCaUje (ORCPT ); Thu, 31 Mar 2022 16:39:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235278AbiCaUje (ORCPT ); Thu, 31 Mar 2022 16:39:34 -0400 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 626C01DF855; Thu, 31 Mar 2022 13:37:46 -0700 (PDT) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-dee0378ce7so548243fac.4; Thu, 31 Mar 2022 13:37:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aC+tCijUVPKI7nGBwd+nln2pgwufchUfIBD5KMT91Xk=; b=d4KTSNUx6UH6VhBWqz1cAyewX/8B2f8E3+obuX/B5oYNl3b5I9zlp8PKy8Cvf+8xiS k7j2ww1jL73U8rKEvjf3Tx+n4BT4x2QN8JBpjJrAv12cdD8a12QbQDOgissYwYTQVNQo KAfbsVkHRd5Zb/CdsUYLSWfcn5/QqwzdilS7T99410N+TSJyVnSr+DxwAtv2/cbO42eR torTaPdcYYsQ5f+hiLUKNLgJgrfa8aCJEh6lhDVwuhCkdXKX8STlo5IMks6YHuqHihDb KjEPZbHkhR9HcrHkjLJYRX7Cpn1u/h94TPuezISCHjq1ixyQEmtpWLeYBLImH0DTwHXh u0pw== X-Gm-Message-State: AOAM5330aHL7YtEe3AhMF1aju1Hb1xpQDBoF0A2Bmm7HLbDIYxTlpSJc BAnxqnA3RGaPJPGpZmthag== X-Google-Smtp-Source: ABdhPJxZPwZTST4T5zDJ7hQZzH4dKiGtYUkP7MRT9ZWl+bcyWzED9bnOP3hWhIPAXY/E4rf4oXLl5Q== X-Received: by 2002:a05:6870:d1c7:b0:de:f3a2:c6f4 with SMTP id b7-20020a056870d1c700b000def3a2c6f4mr3571342oac.164.1648759065707; Thu, 31 Mar 2022 13:37:45 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q11-20020a4a330b000000b003289cbe97c6sm268863ooq.13.2022.03.31.13.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 13:37:45 -0700 (PDT) Received: (nullmailer pid 1450145 invoked by uid 1000); Thu, 31 Mar 2022 20:37:44 -0000 Date: Thu, 31 Mar 2022 15:37:44 -0500 From: Rob Herring To: Jacky Huang Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, cfli0@nuvoton.com Subject: Re: [PATCH 2/3] dt-bindings: clock: Document MA35D1 clock controller bindings Message-ID: References: <20220331024256.14762-1-ychuang3@nuvoton.com> <20220331024256.14762-3-ychuang3@nuvoton.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220331024256.14762-3-ychuang3@nuvoton.com> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, Mar 31, 2022 at 10:42:55AM +0800, Jacky Huang wrote: > Add documentation to describe Nuvoton MA35D1 clock driver bindings. > > Signed-off-by: Jacky Huang > --- > .../bindings/clock/nuvoton,ma35d1-clk.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > new file mode 100644 > index 000000000000..bf5474b10420 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/nuvoton,ma35d1-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Clock Control Module Binding > + > +maintainers: > + - Chi-Fang Li > + - Jacky Huang > + > +description: | > + The MA35D1 clock controller generates clocks for the whole chip, > + including system clocks and all peripheral clocks. > + > + See also: > + dt-bindings/clock/ma35d1-clk.h > + > +properties: > + compatible: > + const: nuvoton,ma35d1-clk > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > + clocks: > + maxItems: 1 > + > + assigned-clocks: > + maxItems: 4 These aren't usually in the clock controller... > + > + assigned-clock-rates: > + maxItems: 4 > + > + clock-pll-mode: > + maxItems: 4 What's this? Not a standard property. Needs a type, description, and vendor prefix. > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + # clock control module node: > + - | > + #include > + > + clk: clock-controller@40460200 { > + compatible = "nuvoton,ma35d1-clk"; > + reg = <0x40460200 0x100>; > + #clock-cells = <1>; > + }; > +... > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27197C433F5 for ; Thu, 31 Mar 2022 20:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jyo+R5m48uWfnyqht0rREWs+FHJ1FzYKGw/A1P6nWUI=; b=bZBymeKXqDK8SP yyrn8qhTdpnNUl/RkSodxxZ5A7r0v20rZ1K1TLsn/5RiY+rKQhhl8O1UNB1MoRWKJdffQ9pFh82R9 CDWWpi2kY1dG8ZYM6xiYcEsLDnnIrmslaYCumsKmmp4YKea3ouI7IPY0gkaxwl8Tpcr27E3kyVDV1 4+mjyxLSfUmzdXxmmI2vWCQ3O4W/Mj/Yvre+MaDNdD2t/dqFZ8K1algytiYRX1VwfB5bPn/FL1xNt NpZpL8C7DKHkgfgiWtPMJRVVYIDsgqtYHI6/pyT5MuJwpfYfZJzF4goQLBU9QegcNZaCBSEwcETD5 ovNFWouQUE0fQBivDMpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1na1YF-003cG6-Bt; Thu, 31 Mar 2022 20:37:51 +0000 Received: from mail-oa1-f52.google.com ([209.85.160.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1na1YB-003cFG-Mm for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 20:37:49 +0000 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-deb9295679so537113fac.6 for ; Thu, 31 Mar 2022 13:37:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aC+tCijUVPKI7nGBwd+nln2pgwufchUfIBD5KMT91Xk=; b=g4jQ4ixiTuPJhurAluppPKgsAiXNAJvg/NvM0/ddn5Fb7Gb/ZEbA4ZxynNvOfDxbH8 R8CspUX4FvcNRAEnnfymS4QCXfXJksOdK2PdZC/kk8JN7yQNRvoGpeCi+6I11hLBy/Vq yu/jxVVXCfrGUI+BaESSkdJ7+Y4FkLSrNlQ7h4PmGb2B1EdDnUzE8tyC81rDUmcOLWX8 f3L7KdfC0M4ABABTMvqylwQyBi+Y7NBO68Had7u0FIg9DGlZ0/bK4K1tR7bKKiClJ8EO hYsdUEHuaCRfZXNCRZsQIeRbpcDU5x0K5dTAoQx5qDJxPWnoq5sdxSn4iyFzFUh/uqnl iubA== X-Gm-Message-State: AOAM532ZR8NmaQ/sz+hyJaKfw0TTwds82xgTxvP07F01o7AkE7lvSQpn EtHHiVgFJAvDedlmeH8cFIY1C6FtCQ== X-Google-Smtp-Source: ABdhPJxZPwZTST4T5zDJ7hQZzH4dKiGtYUkP7MRT9ZWl+bcyWzED9bnOP3hWhIPAXY/E4rf4oXLl5Q== X-Received: by 2002:a05:6870:d1c7:b0:de:f3a2:c6f4 with SMTP id b7-20020a056870d1c700b000def3a2c6f4mr3571342oac.164.1648759065707; Thu, 31 Mar 2022 13:37:45 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id q11-20020a4a330b000000b003289cbe97c6sm268863ooq.13.2022.03.31.13.37.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 13:37:45 -0700 (PDT) Received: (nullmailer pid 1450145 invoked by uid 1000); Thu, 31 Mar 2022 20:37:44 -0000 Date: Thu, 31 Mar 2022 15:37:44 -0500 From: Rob Herring To: Jacky Huang Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, cfli0@nuvoton.com Subject: Re: [PATCH 2/3] dt-bindings: clock: Document MA35D1 clock controller bindings Message-ID: References: <20220331024256.14762-1-ychuang3@nuvoton.com> <20220331024256.14762-3-ychuang3@nuvoton.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220331024256.14762-3-ychuang3@nuvoton.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_133747_781788_504F7778 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 10:42:55AM +0800, Jacky Huang wrote: > Add documentation to describe Nuvoton MA35D1 clock driver bindings. > > Signed-off-by: Jacky Huang > --- > .../bindings/clock/nuvoton,ma35d1-clk.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > new file mode 100644 > index 000000000000..bf5474b10420 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/nuvoton,ma35d1-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Clock Control Module Binding > + > +maintainers: > + - Chi-Fang Li > + - Jacky Huang > + > +description: | > + The MA35D1 clock controller generates clocks for the whole chip, > + including system clocks and all peripheral clocks. > + > + See also: > + dt-bindings/clock/ma35d1-clk.h > + > +properties: > + compatible: > + const: nuvoton,ma35d1-clk > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > + clocks: > + maxItems: 1 > + > + assigned-clocks: > + maxItems: 4 These aren't usually in the clock controller... > + > + assigned-clock-rates: > + maxItems: 4 > + > + clock-pll-mode: > + maxItems: 4 What's this? Not a standard property. Needs a type, description, and vendor prefix. > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + # clock control module node: > + - | > + #include > + > + clk: clock-controller@40460200 { > + compatible = "nuvoton,ma35d1-clk"; > + reg = <0x40460200 0x100>; > + #clock-cells = <1>; > + }; > +... > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel